Keyboard Tabbing Order for PopupWidget in Reverse(shift-tabbing) is out-of-order
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tam-edwin-microsoft
	Aug 7 2020, 6:48 PM

Description

In T257165
The fixed added functionality to close the popup when the user tabs away
however, reverse tabbing (shift-tab) doesn't obey this logic

Keyboard navigate to a popup

shift-tab to traverse in a reverse order

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Update OOUI to v0.40.3	mediawiki/core	master	+254 -121
Update OOUI to v0.40.2	mediawiki/core	master	+179 -98
Follow-up I669cfeeb: Fix the removing of windows being broken by `this` scoping issue	oojs/ui	master	+17 -2
PopupWidget: Fix reverse tabbing order when exiting popup	oojs/ui	master	+21 -4

Customize query in gerrit

Related Objects

Mentioned In: T245824: Error in "App closes on clicking the cancel button"
Mentioned Here: T257165: OOUI PopupWidget : need to Notify caller when popup widget closes

Event Timeline

Tam-edwin-microsoft created this task.Aug 7 2020, 6:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2020, 6:48 PM

Change 619031 had a related patch set uploaded (by Tam-edwin-microsoft; owner: Tam-edwin-microsoft):
[oojs/ui@master] PopupWidget: Fix reverse tabbing order when exiting popup

https://gerrit.wikimedia.org/r/619031

gerritbot added a project: Patch-For-Review.Aug 7 2020, 7:29 PM

Volker_E triaged this task as Medium priority.Aug 11 2020, 2:47 PM

Volker_E moved this task from Backlog to OOUI-0.40.3 on the OOUI board.

Volker_E edited projects, added OOUI (OOUI-0.40.3); removed OOUI.

Change 619031 merged by jenkins-bot:
[oojs/ui@master] PopupWidget: Fix reverse tabbing order when exiting popup

https://gerrit.wikimedia.org/r/619031

Maintenance_bot removed a project: Patch-For-Review.Aug 11 2020, 3:10 PM

Change 621711 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.40.2

https://gerrit.wikimedia.org/r/621711

gerritbot added a project: Patch-For-Review.Aug 21 2020, 11:54 AM

Reedy mentioned this in T245824: Error in "App closes on clicking the cancel button".Aug 22 2020, 4:31 PM

Change 621989 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[oojs/ui@master] Fix the removing of windows being broken by this scoping issue

https://gerrit.wikimedia.org/r/621989

Change 621989 merged by jenkins-bot:
[oojs/ui@master] Follow-up I669cfeeb: Fix the removing of windows being broken by this scoping issue

https://gerrit.wikimedia.org/r/621989

Change 623824 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.40.3

https://gerrit.wikimedia.org/r/623824

Change 621711 abandoned by Reedy:
[mediawiki/core@master] Update OOUI to v0.40.2

Reason:
Replaced by https://gerrit.wikimedia.org/r/c/mediawiki/core/ /623824