Page MenuHomePhabricator
Create Task
Maniphest T259916

"Uncaught Error: Widget not found" on Special:Undelete with no deleted revisions
Closed, ResolvedPublicBUG REPORT
Actions

Description

  1. Find a page that has been deleted but has been restored (e.g. Earth @ enwiki)
  2. (As a sysop) Click on the view/restore link from a deletion log entry for that page, or just navigate to Special:Undelete (http://en.wikipedia.org/wiki/Special:Undelete/Earth)
  3. Console error:
Uncaught Error: Widget not found
    at Object.OO.ui.Element.static.unsafeInfuse (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.ui&skin=vector&version=wl19d:161)
    at Object.OO.ui.Element.static.infuse (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.ui&skin=vector&version=wl19d:161)
    at Object.OO.ui.infuse (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.ui&skin=vector&version=wl19d:157)
    at HTMLDocument.<anonymous> (<anonymous>:199:7501)
    at mightThrow (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.ui&skin=vector&version=wl19d:49)
    at process (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.ui&skin=vector&version=wl19d:49)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Guard against 'Widget not found' errormediawiki/coreREL1_35+11 -1
Guard against 'Widget not found' errormediawiki/coremaster+11 -1
Customize query in gerrit

Event Timeline

Amorymeltzer created this task.Aug 7 2020, 7:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2020, 7:21 PM
Amorymeltzer changed the subtype of this task from "Task" to "Bug Report".Aug 7 2020, 7:21 PM
Reedy added a project: MediaWiki-Special-pages.Aug 7 2020, 9:46 PM
Ammarpad added a project: JavaScript.Aug 7 2020, 10:48 PM
Ammarpad subscribed.

Need to check for the existence of wpComment id before attempting infusion. It won't exist in case of going to Special:Undelete/Existingpage or even a page that simply never exist, because the comment field widget will not be built server side and so attempting to create the JS widget based on that element will fail.

Ammarpad claimed this task.Aug 8 2020, 12:24 AM
gerritbot added a comment.Aug 12 2020, 12:46 PM

Change 619744 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Guard against 'Widget not found' error

https://gerrit.wikimedia.org/r/619744

gerritbot added a project: Patch-For-Review.Aug 12 2020, 12:46 PM
gerritbot added a comment.Aug 17 2020, 9:31 PM

Change 619744 merged by jenkins-bot:
[mediawiki/core@master] Guard against 'Widget not found' error

https://gerrit.wikimedia.org/r/619744

matmarex closed this task as Resolved.Aug 17 2020, 9:35 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Aug 17 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 17 2020, 10:10 PM
gerritbot added a comment.Aug 21 2020, 2:46 PM

Change 621729 had a related patch set uploaded (by Reedy; owner: Ammarpad):
[mediawiki/core@REL1_35] Guard against 'Widget not found' error

https://gerrit.wikimedia.org/r/621729

gerritbot added a project: Patch-For-Review.Aug 21 2020, 2:46 PM
gerritbot added a comment.Aug 21 2020, 3:18 PM

Change 621729 merged by jenkins-bot:
[mediawiki/core@REL1_35] Guard against 'Widget not found' error

https://gerrit.wikimedia.org/r/621729

ReleaseTaggerBot added a project: MW-1.35-notes.Aug 21 2020, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 21 2020, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits