I opened this bug to ask for the restoration of a function belonging to the enhanced editing toolbar, not working in some browsers such as Opera and IE8.
This is the function "find and replace", which you can also see marked with red arrows in the following image:
[http://img697.imageshack.us/img697/7231/scrrenwiki.png]
Thank you
Version: unspecified
Severity: major
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T65665 WikiEditor: Search and replace (tracking) | |||
| Resolved | TheDJ | T25992 Search&replace disabled in Internet Explorer 8–10, Opera |
Search&replace is disabled in these browsers because it was broken in them; I
will see if I can fix S&R for IE at least.
(In reply to comment #1)
Search&replace is disabled in these browsers because it was broken in them; I
will see if I can fix S&R for IE at least.
Some news about it?
accnospamtom wrote:
The button is enbaled now, but the function is completely broken in Opera.
Example:
I tried to replace the word "Lorem" with "Kamel" and the result is this diff:
Browser: Opera 11.x
MediaWiki: 1.18 r86333, 1.17wmf1 r87486
dawpa2000 wrote:
This is a bug in jquery.textSelection.js.
https://github.com/mediawiki/mediawiki-trunk-phase3/blob/master/resources/jquery/jquery.textSelection.js
See this thread:
http://my.opera.com/community/forums/topic.dml?id=1051742
See my user JS that fixes it:
https://gist.github.com/1712432/
Confirming for Windows XP, IE 7, 800x600px,
https://en.wikipedia.org/w/index.php?title=Louisiana_State_Archive_and_Research_Library&action=edit
on browserstack.com, not being logged in.
Same problem for Opera 12.14, not being logged in.
Works correctly in Google Chrome 24 (not logged in) and Firefox 18 (logged in).
dawpa2000 wrote:
Did anyone else take a look at "jquery.textSelection.js"? Like I said on
2012-02-07, the bug is on line 65:
getContents: function () {
return this.val();
},In "jquery.textSelection.js", there are a few bugs with handling newlines.
For Opera, the only change required is to the getContents function.
There are more bugs regarding Internet Explorer. The if statements in "jquery.textSelection.js" should be reversed. You want to check for W3C way first and then fallback to Internet Explorer way.
Furthermore, the newline strings should not be hardcoded. This causes problems when the browser has a different newline than what was expected, which results in off-by-one errors.
Experiment with the following example:
function getNewline() {
var document = window.document;
var textarea = document.createElement("textarea");
textarea.value = "\n";
return textarea.value;
}
var newline = getNewline();Running in IE8 mode and Opera 11.50, 11.60:
newline.length
2
newline === "\r\n"
true
newline === "\n"
false
Running in IE9 mode and Opera 11.64:
newline.length
1
newline === "\r\n"
false
newline === "\n"
true
Seems like 'search and replace' for IE & Opera are both disabled in jquery.wikiEditor.dialogs.config.js (line #1100)
'search-and-replace': { 'browsers': { // Left-to-right languages 'ltr': { 'msie': false, 'firefox': [['>=', 2]], 'opera': false, 'safari': [['>=', 3]], 'chrome': [['>=', 3]] }, // Right-to-left languages 'rtl': { 'msie': false, 'firefox': [['>=', 2]], 'opera': false, 'safari': [['>=', 3]], 'chrome': [['>=', 3]] } },
...No?
Seems like 'search and replace' for IE & Opera are both disabled in jquery.wikiEditor.dialogs.config.js (line #1100)
Yep, as comment 1 said.
Well that was 4 years and at least 2 versions of IE ago.
Do you think something might have changed in the interim?
We will never know unless some minimum version level(s) is reinstated.
since "replace" is fundamentally borked on *all* browsers ATM (can't recall bug#, sorry. you can try some simple replace operations to see the issue - *not* "replace all", just simple "replace"), i do not see much calue in enabling it for IE&opera.
IMO, s&r is very important, and should be fixed asap, first for the sane browsers (geko and webkit), and eventually for all, but unfortunately it seems this is low priority. maybe we can divert tiny potion of the resources currently dedicated to VE and fix s&r?
(
side note: one thing i would love to see is teaching s&r form to be persistent, i.e., retain its content between calls, even for different pages.
please see https://en.wikipedia.org/wiki/User:קיפודנחש/searchPersistence.js
)
If there is no value in enabling it for IE &/or Opera, then developers should either
Rendering a button that does nothing when selected in the layman's world means a function that should be available to them is not working. By that logic, its broke -- browser incompatibility & similar developer nuances be damned -- end of story.
It would not work now. IE8 is meant to be disabled for javascript in January in mediawiki.
Yes, but a fix could be backported to MediaWiki 1.26 (if small).
https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikiEditor/880116f5a67b9fbd5cc67b99cdd213dde3cc733b/modules%2Fjquery.wikiEditor.dialogs.config.js#L1005 activates the feature for Internet Explorer 11+.
@PlavorSeol for what reason? You believe that this only happens on IE8? Works for you on IE9+ and Edge?
There are no longer any browser exclusions in WikiEditor. All browser exclusions are dictated from where MediaWiki core provides support.