Page MenuHomePhabricator
Create Task
Maniphest T259929

Update watchlist handling for `anon` property
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Follow-up to T239883: Watchlist api: Anon flag omitted if false in formatversion=2

Now set to false instead of being omitted entirely

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/GlobalWatchlistmaster+0 -29Remove legacy handling of undefined `anon` property
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Aug 7 2020, 9:04 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptAug 7 2020, 9:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 triaged this task as Low priority.Aug 7 2020, 9:04 PM
DannyS712 set the point value for this task to 1.
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
DannyS712 moved this task from Next to Later on the User-DannyS712 board.Aug 7 2020, 9:23 PM
DannyS712 moved this task from Backlog to Later on the MediaWiki-extensions-GlobalWatchlist board.

Since currently the extension only requires MW 1.35+, this seems like a pretty weak reason to bump the requirement to 1.36+. Moving to later with the expectation that if the version requirement gets bumped for a different reason this should be done, but until then its not a big deal

DannyS712 mentioned this in T270752: Bump mediawiki requirement to 1.36.Dec 23 2020, 2:38 AM
gerritbot added a comment.Dec 23 2020, 2:47 AM

Change 651601 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Remove legacy handling of undefined anon property

https://gerrit.wikimedia.org/r/651601

gerritbot added a project: Patch-For-Review.Dec 23 2020, 2:47 AM
DannyS712 moved this task from Later to In progress on the MediaWiki-extensions-GlobalWatchlist board.Dec 23 2020, 2:48 AM
DannyS712 moved this task from Later to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.Dec 23 2020, 3:19 AM

Change 651601 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Remove legacy handling of undefined anon property

https://gerrit.wikimedia.org/r/651601

jenkins-bot mentioned this in rEGLW1e95fed77876: Remove legacy handling of undefined `anon` property.Dec 23 2020, 3:20 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 23 2020, 4:00 AM
DannyS712 closed this task as Resolved.Dec 23 2020, 4:07 AM
DannyS712 claimed this task.
DannyS712 removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL