Page MenuHomePhabricator
Create Task
Maniphest T259932

Canonicalize ZObjects upon storage
Closed, ResolvedPublic
Actions

Description

Implement a canonicalizer. It should:

  • trim keys
  • sort keys
  • ensure that strings are only represented as ZObjects when they need to be escaped
  • ensure that references are not represented as full ZObjects
  • ensure that lists are represented using the square bracket syntax

The canonicalizer should be called when storing content in the wiki.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Canonicalizing listsDVrandecicmediawiki/extensions/WikiLambdamaster+89 -2
Canonicalize Z9/Reference objectsDVrandecicmediawiki/extensions/WikiLambdamaster+25 -0
Canonicalize Z6/String objectsDVrandecicmediawiki/extensions/WikiLambdamaster+90 -3
Order keys when canonicalizingDVrandecicmediawiki/extensions/WikiLambdamaster+94 -4
Add canonicalization (for now, only key trimming)DVrandecicmediawiki/extensions/WikiLambdamaster+131 -0
Customize query in gerrit

Related Objects

Event Timeline

DVrandecic created this task.Aug 7 2020, 9:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2020, 9:32 PM
gerritbot added a comment.Aug 7 2020, 9:39 PM

Change 619044 had a related patch set uploaded (by DVrandecic; owner: DVrandecic):
[mediawiki/extensions/WikiLambda@master] Adding canonicalization, currently only key trimming.

https://gerrit.wikimedia.org/r/619044

gerritbot added a project: Patch-For-Review.Aug 7 2020, 9:39 PM
Jdforrester-WMF updated the task description. (Show Details)Aug 10 2020, 11:12 AM
gerritbot added a comment.Aug 10 2020, 11:22 AM

Change 619044 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Add canonicalization (for now, only key trimming)

https://gerrit.wikimedia.org/r/619044

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2020, 12:10 PM
gerritbot added a comment.Aug 12 2020, 11:36 PM

Change 619872 had a related patch set uploaded (by DVrandecic; owner: DVrandecic):
[mediawiki/extensions/WikiLambda@master] Order keys when canonicalizing

https://gerrit.wikimedia.org/r/619872

gerritbot added a project: Patch-For-Review.Aug 12 2020, 11:36 PM
DVrandecic mentioned this in T258894: Check for local ZObject well-formedness.Aug 13 2020, 12:27 AM
Jdforrester-WMF updated the task description. (Show Details)Aug 13 2020, 11:01 AM
gerritbot added a comment.Aug 13 2020, 11:05 AM

Change 619872 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Order keys when canonicalizing

https://gerrit.wikimedia.org/r/619872

Maintenance_bot removed a project: Patch-For-Review.Aug 13 2020, 11:10 AM
DVrandecic triaged this task as Medium priority.Aug 20 2020, 1:01 AM
DVrandecic lowered the priority of this task from Medium to Low.Aug 27 2020, 9:40 PM
gerritbot added a comment.Aug 28 2020, 8:49 PM

Change 623058 had a related patch set uploaded (by DVrandecic; owner: DVrandecic):
[mediawiki/extensions/WikiLambda@master] Canonicalize Z6/String objects

https://gerrit.wikimedia.org/r/623058

gerritbot added a project: Patch-For-Review.Aug 28 2020, 8:49 PM
gerritbot added a comment.Aug 31 2020, 5:32 PM

Change 623058 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Canonicalize Z6/String objects

https://gerrit.wikimedia.org/r/623058

Maintenance_bot removed a project: Patch-For-Review.Aug 31 2020, 6:11 PM
gerritbot added a comment.Sep 5 2020, 2:18 AM

Change 625025 had a related patch set uploaded (by DVrandecic; owner: DVrandecic):
[mediawiki/extensions/WikiLambda@master] Canonicalize Z9/Reference objects

https://gerrit.wikimedia.org/r/625025

gerritbot added a project: Patch-For-Review.Sep 5 2020, 2:18 AM
gerritbot added a comment.Sep 8 2020, 8:48 AM

Change 625025 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Canonicalize Z9/Reference objects

https://gerrit.wikimedia.org/r/625025

Jdforrester-WMF updated the task description. (Show Details)Sep 8 2020, 8:58 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 8 2020, 9:10 AM
gerritbot added a comment.Sep 13 2020, 6:40 PM

Change 626881 had a related patch set uploaded (by DVrandecic; owner: DVrandecic):
[mediawiki/extensions/WikiLambda@master] Canonicalizing lists

https://gerrit.wikimedia.org/r/626881

gerritbot added a project: Patch-For-Review.Sep 13 2020, 6:40 PM
DVrandecic mentioned this in T262770: Normalize ZObjects.Sep 13 2020, 7:04 PM
gerritbot added a comment.Sep 14 2020, 4:56 PM

Change 626881 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Canonicalizing lists

https://gerrit.wikimedia.org/r/626881

Maintenance_bot removed a project: Patch-For-Review.Sep 14 2020, 5:10 PM
DVrandecic closed this task as Resolved.Sep 14 2020, 8:31 PM
DVrandecic updated the task description. (Show Details)
Jdforrester-WMF mentioned this in T273561: Strings that look like references are stored as references.Feb 16 2021, 5:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits