Page MenuHomePhabricator
Create Task
Maniphest T259948

Remove manual construction of WikiPage objects
Open, LowPublic
Actions

Description

The WikiPage class is not @newable, but there are a lot of deployed manual constructions.

See https://codesearch.wmcloud.org/deployed/?q=new%5Cs%2B%5C%5C%3FWiki(File%7CCategory)%3FPage%5Cs*%5C(&i=nope&files=&excludeFiles=&repos=

These should be replaced with uses of the WikiPageFactory service

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+13 -21Use WikiPageFactory to instance WikiPage in Article classes
mediawiki/coremaster+59 -63tests: Use WikiPageFactory to create WikiPage object
mediawiki/extensions/ReplaceTextmaster+6 -1Use WikiPageFactory to create WikiPage object
mediawiki/extensions/GraphVizmaster+25 -3Use WikiPageFactory to create WikiPage object
mediawiki/extensions/WikiLexicalDatamaster+73 -10Use WikiPageFactory to create WikiPage object
mediawiki/extensions/TranslateSvgmaster+31 -3Use WikiPageFactory to create WikiPage object
mediawiki/extensions/Widgetsmaster+7 -1Use WikiPageFactory to create WikiPage object
mediawiki/extensions/TinyMCEmaster+6 -1Use WikiPageFactory to create WikiPage object
mediawiki/extensions/PhabTaskGraphmaster+14 -2Use WikiPageFactory to create WikiPage object
mediawiki/extensions/PageExchangemaster+18 -3Use WikiPageFactory to create WikiPage object
mediawiki/extensions/NewsTickermaster+22 -3Use WikiPageFactory to create WikiPage object
mediawiki/extensions/MultiBoilerplatemaster+7 -1Use WikiPageFactory to create WikiPage object
mediawiki/extensions/LegalLoginmaster+6 -1Use WikiPageFactory to create WikiPage object
mediawiki/extensions/CreateUserPagemaster+6 -1Use WikiPageFactory to create WikiPage object
mediawiki/extensions/DocBookExportmaster+6 -1Use WikiPageFactory to create WikiPage object
mediawiki/extensions/CloneDiffmaster+8 -1Use WikiPageFactory to create WikiPage object
mediawiki/extensions/AutoCreateCategoryPagesmaster+14 -1Use WikiPageFactory to create WikiPage object
mediawiki/extensions/Wikibasemaster+5 -6Use WikiPageFactory to create WikiPage object
mediawiki/extensions/Genealogymaster+14 -11Use WikiPageFactory to create WikiPage object
mediawiki/extensions/BibManagermaster+1 -1Use WikiPageFactory to create WikiPage object
mediawiki/extensions/CommentStreamsmaster+4 -5Use WikiPageFactory to create WikiPage object
mediawiki/extensions/MissedPagesmaster+1 -2Use WikiPageFactory to create WikiPage object
mediawiki/extensions/ConfirmAccountmaster+2 -2Use WikiPageFactory to create WikiPage object
mediawiki/coremaster+1 -1Use WikiPageFactory to instance WikiPage in namespaceDupes.php
mediawiki/coremaster+11 -3Inject WikiPageFactory into SpecialMyLanguage
Show related patches Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Aug 7 2020, 11:03 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptAug 7 2020, 11:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.Aug 7 2020, 11:03 PM
DannyS712 mentioned this in T259949: Inject dependencies into WikiPage.
gerritbot added a comment.Nov 11 2020, 9:16 PM

Change 640706 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Inject WikiPageFactory into SpecialMyLanguage

https://gerrit.wikimedia.org/r/640706

gerritbot added a project: Patch-For-Review.Nov 11 2020, 9:16 PM
gerritbot added a comment.Nov 11 2020, 10:10 PM

Change 640721 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Use WikiPageFactory to instance WikiPage in namespaceDupes.php

https://gerrit.wikimedia.org/r/640721

gerritbot added a comment.Nov 11 2020, 10:13 PM

Change 640722 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Use WikiPageFactory to instance WikiPage in Article class

https://gerrit.wikimedia.org/r/640722

gerritbot added a comment.Nov 18 2020, 7:32 PM

Change 640721 abandoned by Umherirrender:
[mediawiki/core@master] Use WikiPageFactory to instance WikiPage in namespaceDupes.php

Reason:
Needs another strategy

https://gerrit.wikimedia.org/r/640721

gerritbot added a comment.Nov 18 2020, 7:32 PM

Change 640722 abandoned by Umherirrender:
[mediawiki/core@master] Use WikiPageFactory to instance WikiPage in Article class

Reason:
Needs another strategy

https://gerrit.wikimedia.org/r/640722

gerritbot added a comment.Dec 1 2020, 4:04 PM

Change 640706 merged by jenkins-bot:
[mediawiki/core@master] Inject WikiPageFactory into SpecialMyLanguage

https://gerrit.wikimedia.org/r/640706

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 1 2020, 5:00 PM
gerritbot added a comment.Fri, Jun 24, 11:15 PM

Change 640721 restored by Umherirrender:

[mediawiki/core@master] Use WikiPageFactory to instance WikiPage in namespaceDupes.php

https://gerrit.wikimedia.org/r/640721

gerritbot added a comment.Fri, Jun 24, 11:16 PM

Change 640722 restored by Umherirrender:

[mediawiki/core@master] Use WikiPageFactory to instance WikiPage in Article class

https://gerrit.wikimedia.org/r/640722

gerritbot added a comment.Sat, Jun 25, 4:53 AM

Change 640721 merged by jenkins-bot:

[mediawiki/core@master] Use WikiPageFactory to instance WikiPage in namespaceDupes.php

https://gerrit.wikimedia.org/r/640721

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Sat, Jun 25, 5:00 AM
gerritbot added a comment.Sat, Jun 25, 12:15 PM

Change 808364 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BibManager@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808364

gerritbot added a comment.Sat, Jun 25, 12:19 PM

Change 808366 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CommentStreams@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808366

gerritbot added a comment.Sat, Jun 25, 12:20 PM

Change 808367 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ConfirmAccount@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808367

gerritbot added a comment.Sat, Jun 25, 1:48 PM

Change 808367 merged by jenkins-bot:

[mediawiki/extensions/ConfirmAccount@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808367

Umherirrender mentioned this in rECACa53d0706e95c: Use WikiPageFactory to create WikiPage object.Sat, Jun 25, 1:53 PM
gerritbot added a comment.Sat, Jun 25, 5:25 PM

Change 808374 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Genealogy@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808374

gerritbot added a comment.Sat, Jun 25, 5:28 PM

Change 808376 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MissedPages@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808376

gerritbot added a comment.Sat, Jun 25, 5:35 PM

Change 808380 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808380

gerritbot added a comment.Sat, Jun 25, 8:44 PM

Change 808376 merged by jenkins-bot:

[mediawiki/extensions/MissedPages@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808376

gerritbot added a comment.Sat, Jun 25, 8:45 PM

Change 808374 merged by jenkins-bot:

[mediawiki/extensions/Genealogy@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808374

Umherirrender mentioned this in rEGNEde848d180070: Use WikiPageFactory to create WikiPage object.Sat, Jun 25, 8:45 PM
gerritbot added a comment.Sat, Jun 25, 8:48 PM

Change 808366 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808366

gerritbot added a comment.Sat, Jun 25, 8:48 PM

Change 808364 merged by jenkins-bot:

[mediawiki/extensions/BibManager@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808364

Umherirrender mentioned this in rECOSc8b1d8c63479: Use WikiPageFactory to create WikiPage object.Sat, Jun 25, 8:49 PM
Umherirrender mentioned this in rEMIPbdfc883b1d61: Use WikiPageFactory to create WikiPage object.Sat, Jun 25, 8:51 PM
gerritbot added a comment.Sat, Jun 25, 9:03 PM

Change 808380 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808380

gerritbot added a comment.Sun, Jun 26, 5:21 PM

Change 808453 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AutoCreateCategoryPages@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808453

gerritbot added a comment.Sun, Jun 26, 5:23 PM

Change 808454 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CloneDiff@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808454

gerritbot added a comment.Sun, Jun 26, 5:25 PM

Change 808455 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CreateUserPage@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808455

gerritbot added a comment.Sun, Jun 26, 5:27 PM

Change 808456 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DocBookExport@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808456

gerritbot added a comment.Sun, Jun 26, 5:28 PM

Change 808458 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GraphViz@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808458

gerritbot added a comment.Sun, Jun 26, 5:29 PM

Change 808459 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LegalLogin@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808459

gerritbot added a comment.Sun, Jun 26, 5:30 PM

Change 808460 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MultiBoilerplate@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808460

gerritbot added a comment.Sun, Jun 26, 5:31 PM

Change 808461 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/NewsTicker@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808461

gerritbot added a comment.Sun, Jun 26, 5:31 PM

Change 808462 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageExchange@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808462

gerritbot added a comment.Sun, Jun 26, 5:33 PM

Change 808464 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PhabTaskGraph@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808464

gerritbot added a comment.Sun, Jun 26, 5:36 PM

Change 808466 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ReplaceText@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808466

gerritbot added a comment.Sun, Jun 26, 5:38 PM

Change 808468 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TinyMCE@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808468

gerritbot added a comment.Sun, Jun 26, 5:39 PM

Change 808469 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TranslateSvg@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808469

gerritbot added a comment.Sun, Jun 26, 5:40 PM

Change 808470 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Widgets@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808470

gerritbot added a comment.Sun, Jun 26, 5:47 PM

Change 808474 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikiLexicalData@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808474

gerritbot added a comment.Sun, Jun 26, 6:42 PM

Change 808453 merged by jenkins-bot:

[mediawiki/extensions/AutoCreateCategoryPages@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808453

gerritbot added a comment.Sun, Jun 26, 6:45 PM

Change 808454 merged by jenkins-bot:

[mediawiki/extensions/CloneDiff@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808454

gerritbot added a comment.Sun, Jun 26, 6:49 PM

Change 808456 merged by jenkins-bot:

[mediawiki/extensions/DocBookExport@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808456

Umherirrender mentioned this in rECDI9fcaf3348dd0: Use WikiPageFactory to create WikiPage object.Sun, Jun 26, 6:53 PM
gerritbot added a comment.Sun, Jun 26, 6:54 PM

Change 808455 merged by jenkins-bot:

[mediawiki/extensions/CreateUserPage@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808455

Umherirrender mentioned this in rECUPd26000a2b0ce: Use WikiPageFactory to create WikiPage object.Sun, Jun 26, 6:54 PM
Umherirrender mentioned this in rEDBE709095a76bda: Use WikiPageFactory to create WikiPage object.
gerritbot added a comment.Sun, Jun 26, 6:55 PM

Change 808458 merged by jenkins-bot:

[mediawiki/extensions/GraphViz@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808458

gerritbot added a comment.Sun, Jun 26, 6:55 PM

Change 808459 merged by jenkins-bot:

[mediawiki/extensions/LegalLogin@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808459

gerritbot added a comment.Sun, Jun 26, 6:55 PM

Change 808460 merged by jenkins-bot:

[mediawiki/extensions/MultiBoilerplate@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808460

gerritbot added a comment.Sun, Jun 26, 6:55 PM

Change 808461 merged by jenkins-bot:

[mediawiki/extensions/NewsTicker@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808461

gerritbot added a comment.Sun, Jun 26, 6:55 PM

Change 808462 merged by jenkins-bot:

[mediawiki/extensions/PageExchange@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808462

gerritbot added a comment.Sun, Jun 26, 6:55 PM

Change 808464 merged by jenkins-bot:

[mediawiki/extensions/PhabTaskGraph@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808464

Umherirrender mentioned this in rEPGE2e79ffb51120: Use WikiPageFactory to create WikiPage object.Sun, Jun 26, 6:55 PM
Umherirrender mentioned this in rEPTG1e2bae097c32: Use WikiPageFactory to create WikiPage object.
gerritbot added a comment.Sun, Jun 26, 6:56 PM

Change 808466 merged by jenkins-bot:

[mediawiki/extensions/ReplaceText@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808466

gerritbot added a comment.Sun, Jun 26, 6:57 PM

Change 808468 merged by jenkins-bot:

[mediawiki/extensions/TinyMCE@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808468

gerritbot added a comment.Sun, Jun 26, 6:57 PM

Change 808470 merged by jenkins-bot:

[mediawiki/extensions/Widgets@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808470

gerritbot added a comment.Sun, Jun 26, 6:58 PM

Change 808469 merged by jenkins-bot:

[mediawiki/extensions/TranslateSvg@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808469

Umherirrender mentioned this in rENWTc94ee8f32acf: Use WikiPageFactory to create WikiPage object.Sun, Jun 26, 7:00 PM
gerritbot added a comment.Sun, Jun 26, 7:02 PM

Change 808474 merged by jenkins-bot:

[mediawiki/extensions/WikiLexicalData@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808474

Umherirrender claimed this task.Sun, Jun 26, 8:15 PM
Umherirrender triaged this task as Low priority.
Umherirrender mentioned this in rELLO47527b801be1: Use WikiPageFactory to create WikiPage object.Sun, Jun 26, 8:32 PM
Umherirrender mentioned this in rEACP5bd47519e798: Use WikiPageFactory to create WikiPage object.Sun, Jun 26, 8:38 PM
Umherirrender mentioned this in rEMBPa9e6a26ec059: Use WikiPageFactory to create WikiPage object.
Umherirrender updated the task description. (Show Details)Sun, Jun 26, 8:47 PM
Umherirrender updated the task description. (Show Details)
gerritbot added a comment.Sun, Jun 26, 9:21 PM

Change 808540 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808540

gerritbot added a comment.Sun, Jun 26, 10:49 PM

Change 808540 merged by jenkins-bot:

[mediawiki/core@master] tests: Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808540

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL