Page MenuHomePhabricator
Create Task
Maniphest T259948

Remove manual construction of WikiPage objects
Open, LowPublic
Actions

Description

The WikiPage class is not @newable, but there are a lot of deployed manual constructions.

See https://codesearch.wmcloud.org/deployed/?q=new%5Cs%2B%5C%5C%3FWiki(File%7CCategory)%3FPage%5Cs*%5C(&i=nope&files=&excludeFiles=&repos=

These should be replaced with uses of the WikiPageFactory service

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Do not construct `WikiPage` directly, use WikiPageFactory serviceD3r1ck01mediawiki/coremaster+31 -39
tests: Use WikiPageFactory instead of constructing WikiPage directlyD3r1ck01mediawiki/extensions/ParserFunctionsmaster+3 -3
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/CirrusSearchmaster+17 -6
Use WikiPageFactory to instance WikiPage in Article classesUmherirrendermediawiki/coremaster+13 -21
tests: Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/coremaster+59 -63
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/ReplaceTextmaster+6 -1
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/GraphVizmaster+25 -3
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/WikiLexicalDatamaster+73 -10
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/TranslateSvgmaster+31 -3
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/Widgetsmaster+7 -1
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/TinyMCEmaster+6 -1
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/PhabTaskGraphmaster+14 -2
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/PageExchangemaster+18 -3
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/NewsTickermaster+22 -3
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/MultiBoilerplatemaster+7 -1
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/LegalLoginmaster+6 -1
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/CreateUserPagemaster+6 -1
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/DocBookExportmaster+6 -1
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/CloneDiffmaster+8 -1
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/AutoCreateCategoryPagesmaster+14 -1
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/Wikibasemaster+5 -6
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/Genealogymaster+14 -11
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/BibManagermaster+1 -1
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/CommentStreamsmaster+4 -5
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/MissedPagesmaster+1 -2
Use WikiPageFactory to create WikiPage objectUmherirrendermediawiki/extensions/ConfirmAccountmaster+2 -2
Use WikiPageFactory to instance WikiPage in namespaceDupes.phpUmherirrendermediawiki/coremaster+1 -1
Inject WikiPageFactory into SpecialMyLanguageUmherirrendermediawiki/coremaster+11 -3
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a project: User-DannyS712. · View Herald TranscriptAug 7 2020, 11:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.Aug 7 2020, 11:03 PM
DannyS712 mentioned this in T259949: Inject dependencies into WikiPage.
gerritbot added a comment.Nov 11 2020, 9:16 PM

Change 640706 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Inject WikiPageFactory into SpecialMyLanguage

https://gerrit.wikimedia.org/r/640706

gerritbot added a project: Patch-For-Review.Nov 11 2020, 9:16 PM
gerritbot added a comment.Nov 11 2020, 10:10 PM

Change 640721 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Use WikiPageFactory to instance WikiPage in namespaceDupes.php

https://gerrit.wikimedia.org/r/640721

gerritbot added a comment.Nov 11 2020, 10:13 PM

Change 640722 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Use WikiPageFactory to instance WikiPage in Article class

https://gerrit.wikimedia.org/r/640722

gerritbot added a comment.Nov 18 2020, 7:32 PM

Change 640721 abandoned by Umherirrender:
[mediawiki/core@master] Use WikiPageFactory to instance WikiPage in namespaceDupes.php

Reason:
Needs another strategy

https://gerrit.wikimedia.org/r/640721

gerritbot added a comment.Nov 18 2020, 7:32 PM

Change 640722 abandoned by Umherirrender:
[mediawiki/core@master] Use WikiPageFactory to instance WikiPage in Article class

Reason:
Needs another strategy

https://gerrit.wikimedia.org/r/640722

gerritbot added a comment.Dec 1 2020, 4:04 PM

Change 640706 merged by jenkins-bot:
[mediawiki/core@master] Inject WikiPageFactory into SpecialMyLanguage

https://gerrit.wikimedia.org/r/640706

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 1 2020, 5:00 PM
gerritbot added a comment.Jun 24 2022, 11:15 PM

Change 640721 restored by Umherirrender:

[mediawiki/core@master] Use WikiPageFactory to instance WikiPage in namespaceDupes.php

https://gerrit.wikimedia.org/r/640721

gerritbot added a comment.Jun 24 2022, 11:16 PM

Change 640722 restored by Umherirrender:

[mediawiki/core@master] Use WikiPageFactory to instance WikiPage in Article class

https://gerrit.wikimedia.org/r/640722

gerritbot added a comment.Jun 25 2022, 4:53 AM

Change 640721 merged by jenkins-bot:

[mediawiki/core@master] Use WikiPageFactory to instance WikiPage in namespaceDupes.php

https://gerrit.wikimedia.org/r/640721

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 25 2022, 5:00 AM
gerritbot added a comment.Jun 25 2022, 12:15 PM

Change 808364 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BibManager@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808364

gerritbot added a comment.Jun 25 2022, 12:19 PM

Change 808366 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CommentStreams@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808366

gerritbot added a comment.Jun 25 2022, 12:20 PM

Change 808367 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ConfirmAccount@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808367

gerritbot added a comment.Jun 25 2022, 1:48 PM

Change 808367 merged by jenkins-bot:

[mediawiki/extensions/ConfirmAccount@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808367

Umherirrender mentioned this in rECACa53d0706e95c: Use WikiPageFactory to create WikiPage object.Jun 25 2022, 1:53 PM
gerritbot added a comment.Jun 25 2022, 5:25 PM

Change 808374 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Genealogy@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808374

gerritbot added a comment.Jun 25 2022, 5:28 PM

Change 808376 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MissedPages@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808376

gerritbot added a comment.Jun 25 2022, 5:35 PM

Change 808380 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808380

gerritbot added a comment.Jun 25 2022, 8:44 PM

Change 808376 merged by jenkins-bot:

[mediawiki/extensions/MissedPages@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808376

gerritbot added a comment.Jun 25 2022, 8:45 PM

Change 808374 merged by jenkins-bot:

[mediawiki/extensions/Genealogy@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808374

Umherirrender mentioned this in rEGNEde848d180070: Use WikiPageFactory to create WikiPage object.Jun 25 2022, 8:45 PM
gerritbot added a comment.Jun 25 2022, 8:48 PM

Change 808366 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808366

gerritbot added a comment.Jun 25 2022, 8:48 PM

Change 808364 merged by jenkins-bot:

[mediawiki/extensions/BibManager@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808364

Umherirrender mentioned this in rECOSc8b1d8c63479: Use WikiPageFactory to create WikiPage object.Jun 25 2022, 8:49 PM
Umherirrender mentioned this in rEMIPbdfc883b1d61: Use WikiPageFactory to create WikiPage object.Jun 25 2022, 8:51 PM
gerritbot added a comment.Jun 25 2022, 9:03 PM

Change 808380 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808380

gerritbot added a comment.Jun 26 2022, 5:21 PM

Change 808453 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AutoCreateCategoryPages@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808453

gerritbot added a comment.Jun 26 2022, 5:23 PM

Change 808454 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CloneDiff@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808454

gerritbot added a comment.Jun 26 2022, 5:25 PM

Change 808455 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CreateUserPage@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808455

gerritbot added a comment.Jun 26 2022, 5:27 PM

Change 808456 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DocBookExport@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808456

gerritbot added a comment.Jun 26 2022, 5:28 PM

Change 808458 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GraphViz@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808458

gerritbot added a comment.Jun 26 2022, 5:29 PM

Change 808459 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LegalLogin@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808459

gerritbot added a comment.Jun 26 2022, 5:30 PM

Change 808460 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MultiBoilerplate@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808460

gerritbot added a comment.Jun 26 2022, 5:31 PM

Change 808461 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/NewsTicker@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808461

gerritbot added a comment.Jun 26 2022, 5:31 PM

Change 808462 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageExchange@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808462

gerritbot added a comment.Jun 26 2022, 5:33 PM

Change 808464 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PhabTaskGraph@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808464

gerritbot added a comment.Jun 26 2022, 5:36 PM

Change 808466 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ReplaceText@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808466

gerritbot added a comment.Jun 26 2022, 5:38 PM

Change 808468 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TinyMCE@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808468

gerritbot added a comment.Jun 26 2022, 5:39 PM

Change 808469 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TranslateSvg@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808469

gerritbot added a comment.Jun 26 2022, 5:40 PM

Change 808470 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Widgets@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808470

gerritbot added a comment.Jun 26 2022, 5:47 PM

Change 808474 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikiLexicalData@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808474

gerritbot added a comment.Jun 26 2022, 6:42 PM

Change 808453 merged by jenkins-bot:

[mediawiki/extensions/AutoCreateCategoryPages@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808453

gerritbot added a comment.Jun 26 2022, 6:45 PM

Change 808454 merged by jenkins-bot:

[mediawiki/extensions/CloneDiff@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808454

gerritbot added a comment.Jun 26 2022, 6:49 PM

Change 808456 merged by jenkins-bot:

[mediawiki/extensions/DocBookExport@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808456

Umherirrender mentioned this in rECDI9fcaf3348dd0: Use WikiPageFactory to create WikiPage object.Jun 26 2022, 6:53 PM
gerritbot added a comment.Jun 26 2022, 6:54 PM

Change 808455 merged by jenkins-bot:

[mediawiki/extensions/CreateUserPage@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808455

Umherirrender mentioned this in rECUPd26000a2b0ce: Use WikiPageFactory to create WikiPage object.Jun 26 2022, 6:54 PM
Umherirrender mentioned this in rEDBE709095a76bda: Use WikiPageFactory to create WikiPage object.
gerritbot added a comment.Jun 26 2022, 6:55 PM

Change 808458 merged by jenkins-bot:

[mediawiki/extensions/GraphViz@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808458

gerritbot added a comment.Jun 26 2022, 6:55 PM

Change 808459 merged by jenkins-bot:

[mediawiki/extensions/LegalLogin@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808459

gerritbot added a comment.Jun 26 2022, 6:55 PM

Change 808460 merged by jenkins-bot:

[mediawiki/extensions/MultiBoilerplate@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808460

gerritbot added a comment.Jun 26 2022, 6:55 PM

Change 808461 merged by jenkins-bot:

[mediawiki/extensions/NewsTicker@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808461

gerritbot added a comment.Jun 26 2022, 6:55 PM

Change 808462 merged by jenkins-bot:

[mediawiki/extensions/PageExchange@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808462

gerritbot added a comment.Jun 26 2022, 6:55 PM

Change 808464 merged by jenkins-bot:

[mediawiki/extensions/PhabTaskGraph@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808464

Umherirrender mentioned this in rEPGE2e79ffb51120: Use WikiPageFactory to create WikiPage object.Jun 26 2022, 6:55 PM
Umherirrender mentioned this in rEPTG1e2bae097c32: Use WikiPageFactory to create WikiPage object.
gerritbot added a comment.Jun 26 2022, 6:56 PM

Change 808466 merged by jenkins-bot:

[mediawiki/extensions/ReplaceText@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808466

gerritbot added a comment.Jun 26 2022, 6:57 PM

Change 808468 merged by jenkins-bot:

[mediawiki/extensions/TinyMCE@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808468

gerritbot added a comment.Jun 26 2022, 6:57 PM

Change 808470 merged by jenkins-bot:

[mediawiki/extensions/Widgets@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808470

gerritbot added a comment.Jun 26 2022, 6:58 PM

Change 808469 merged by jenkins-bot:

[mediawiki/extensions/TranslateSvg@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808469

Umherirrender mentioned this in rENWTc94ee8f32acf: Use WikiPageFactory to create WikiPage object.Jun 26 2022, 7:00 PM
gerritbot added a comment.Jun 26 2022, 7:02 PM

Change 808474 merged by jenkins-bot:

[mediawiki/extensions/WikiLexicalData@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808474

Umherirrender claimed this task.Jun 26 2022, 8:15 PM
Umherirrender triaged this task as Low priority.
Umherirrender mentioned this in rELLO47527b801be1: Use WikiPageFactory to create WikiPage object.Jun 26 2022, 8:32 PM
Umherirrender mentioned this in rEACP5bd47519e798: Use WikiPageFactory to create WikiPage object.Jun 26 2022, 8:38 PM
Umherirrender mentioned this in rEMBPa9e6a26ec059: Use WikiPageFactory to create WikiPage object.
Umherirrender updated the task description. (Show Details)Jun 26 2022, 8:47 PM
Umherirrender updated the task description. (Show Details)
gerritbot added a comment.Jun 26 2022, 9:21 PM

Change 808540 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808540

gerritbot added a comment.Jun 26 2022, 10:49 PM

Change 808540 merged by jenkins-bot:

[mediawiki/core@master] tests: Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/808540

gerritbot added a comment.Sep 6 2022, 6:29 PM

Change 640722 abandoned by Umherirrender:

[mediawiki/core@master] Use WikiPageFactory to instance WikiPage in Article classes

Reason:

https://gerrit.wikimedia.org/r/640722

Umherirrender removed Umherirrender as the assignee of this task.Sep 6 2022, 6:29 PM
Umherirrender removed a project: Patch-For-Review.
Umherirrender subscribed.
gerritbot added a comment.Dec 19 2022, 8:23 PM

Change 869288 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CirrusSearch@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/869288

gerritbot added a project: Patch-For-Review.Dec 19 2022, 8:23 PM
gerritbot added a comment.Dec 20 2022, 4:19 PM

Change 869288 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Use WikiPageFactory to create WikiPage object

https://gerrit.wikimedia.org/r/869288

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 20 2022, 5:00 PM
Umherirrender removed a project: Patch-For-Review.Dec 20 2022, 9:36 PM
Umherirrender unsubscribed.Oct 3 2023, 1:27 PM
Pppery subscribed.Jun 18 2024, 3:59 PM

Anything left to do here?

Pppery unsubscribed.May 18 2025, 3:06 AM
gerritbot added a comment.Sat, Jul 11, 5:38 PM

Change #1309786 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/ParserFunctions@master] tests: Use WikiPageFactory instead of constructing WikiPage directly

https://gerrit.wikimedia.org/r/1309786

gerritbot added a project: Patch-For-Review.Sat, Jul 11, 5:38 PM

Change #1309787 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] Do not construct `WikiPage` directly, use WikiPageFactory service

https://gerrit.wikimedia.org/r/1309787

xSavitar added subscribers: Pppery, xSavitar.Sat, Jul 11, 6:08 PM
In T259948#9903970, @Pppery wrote:

Anything left to do here?

Yes! Running the query in the task description returned 2 more callers in deployed code; I've updated them. Both patches have been submitted to Gerrit. You're invited to review if you like.

gerritbot added a comment.Sat, Jul 11, 7:27 PM

Change #1309786 merged by jenkins-bot:

[mediawiki/extensions/ParserFunctions@master] tests: Use WikiPageFactory instead of constructing WikiPage directly

https://gerrit.wikimedia.org/r/1309786

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.11; 2026-07-14).Sat, Jul 11, 8:00 PM
SomeRandomDeveloper subscribed.Thu, Jul 16, 3:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits