Inject dependencies into WikiPage
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	DannyS712
	Aug 7 2020, 11:03 PM

Description

While WikiPage is not @newable, it still has manually constructions in deployed code. Until those are replaced (T259948: Remove manual construction of WikiPage objects), the dependencies should be optional.

Details

	Subject	Repo	Branch	Lines +/-
	Inject dependencies to WikiPage, part 1	mediawiki/core	master	+148 -32

Customize query in gerrit

Related Objects

Mentioned Here: T259948: Remove manual construction of WikiPage objects

Event Timeline

DannyS712 created this task.Aug 7 2020, 11:03 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptAug 7 2020, 11:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 619047 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Inject dependencies to WikiPage

https://gerrit.wikimedia.org/r/619047

gerritbot added a project: Patch-For-Review.Aug 7 2020, 11:04 PM

@Pchelolo at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/619047/10#message-24357914ecb71813243d8566e0f7509c2ff30348

This goes countrary to the Service/ValueObject approach. WikiPage itself should probably become a value object and all the functionality in it should be extracted into separate services.

Are there currently plans to convert WikiPage to a value object?

Are there currently plans to convert WikiPage to a value object?

WikiPage should be broken up and cease to exist. Its function as an entity should be taken over by PageRecord.

In T259949#6371053, @Pchelolo wrote:

Are there currently plans to convert WikiPage to a value object?

WikiPage should be broken up and cease to exist. Its function as an entity should be taken over by PageRecord.

Until that happens, since we now have a WikiPageFactory, can we inject the dependencies needed?

In light of migration to PageIdentity/PageReference, etc.

Change 619047 abandoned by DannyS712:

[mediawiki/core@master] Inject dependencies to WikiPage, part 1

Reason: