CU 2.0: Tool link URLs do not have the correct IP
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Aug 8 2020, 11:15 AM

Description

What is the problem?

The tool links have a blank IP parameter (e.g. https://www.dnsstuff.com/tools/tracert.ch?ip=), so do not give information about the requested IP.

I think it tries to get the IP from the data-cuc_ip field, which no longer exists since T259106.

I think might be the same issue as T259964.

Steps to reproduce problem

Launch an investigation
For an IP cell, open the dropdown menu and click WHOIS/RDNS

Expected behavior: Takes you to https://www.robtex.com/ip-lookup/172.19.0.1 (or whatever IP is appropriate)
Observed behavior: Takes you to https://www.robtex.com/?dns=&whois=1

Environment

Wiki(s): Local vagrant: MediaWiki 1.36.0-alpha (004012c), CheckUser 2.5 (9ec06d4)

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/CheckUser	master	+9 -9	Always use data-value instead of the previous data-FIELDNAME

Customize query in gerrit

Related Objects

Mentioned In: T257891: Rollout Special:Investigate on French wikipedia
T259106: CU 2.0: Sticky highlighting does not always persist across pages for IPs
T259964: CU 2.0: Cannot add new targets to investigation
Mentioned Here: T256280: Update default tool links
T259106: CU 2.0: Sticky highlighting does not always persist across pages for IPs
T259964: CU 2.0: Cannot add new targets to investigation
rECHU9ec06d4de9f1: Merge "Fix table cell highlighting in Special:Investigate"
rMW004012c0041e: Merge "GlobalIdGenerator: Spelling correction in a comment"

Event Timeline

dom_walden created this task.Aug 8 2020, 11:15 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2020, 11:15 AM

dom_walden mentioned this in T259964: CU 2.0: Cannot add new targets to investigation.Aug 8 2020, 11:15 AM

dom_walden mentioned this in T259106: CU 2.0: Sticky highlighting does not always persist across pages for IPs.Aug 8 2020, 11:40 AM

dom_walden mentioned this in T257891: Rollout Special:Investigate on French wikipedia.

I believe this is resolved with the patch in T259964

Change 619126 had a related patch set uploaded (by Tchanders; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Always use data-value instead of the previous data-FIELDNAME

https://gerrit.wikimedia.org/r/619126

gerritbot added a project: Patch-For-Review.Aug 10 2020, 11:55 AM

Tchanders assigned this task to dbarratt.Aug 10 2020, 11:56 AM

Tchanders moved this task from Untriaged to The Letter Song on the Anti-Harassment board.

Tchanders edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.

Change 619126 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Always use data-value instead of the previous data-FIELDNAME

https://gerrit.wikimedia.org/r/619126

dbarratt moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Aug 10 2020, 12:47 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 10 2020, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2020, 1:10 PM

I tested that all the toollinks have the correct IP or username, as appropriate.

This included all the links listed in T256280:

Special:Contribs for both IPv4, IPv6 and usernames
Whois and Proxy check for IPv4 and IPv6

Other testing (including for possible regressions) done in T259964.

Niharika closed this task as Resolved.Aug 24 2020, 10:37 PM

CU 2.0: Tool link URLs do not have the correct IPClosed, ResolvedPublicBUG REPORTActions