Page MenuHomePhabricator

CU 2.0: Tool link URLs do not have the correct IP
Closed, ResolvedPublicBUG REPORT

Description

What is the problem?

The tool links have a blank IP parameter (e.g. https://www.dnsstuff.com/tools/tracert.ch?ip=), so do not give information about the requested IP.

I think it tries to get the IP from the data-cuc_ip field, which no longer exists since T259106.

I think might be the same issue as T259964.

Steps to reproduce problem
  1. Launch an investigation
  2. For an IP cell, open the dropdown menu and click WHOIS/RDNS

Expected behavior: Takes you to https://www.robtex.com/ip-lookup/172.19.0.1 (or whatever IP is appropriate)
Observed behavior: Takes you to https://www.robtex.com/?dns=&whois=1

Environment

Wiki(s): Local vagrant: MediaWiki 1.36.0-alpha (004012c), CheckUser 2.5 (9ec06d4)

Event Timeline

I believe this is resolved with the patch in T259964

Change 619126 had a related patch set uploaded (by Tchanders; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Always use data-value instead of the previous data-FIELDNAME

https://gerrit.wikimedia.org/r/619126

Change 619126 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Always use data-value instead of the previous data-FIELDNAME

https://gerrit.wikimedia.org/r/619126

I tested that all the toollinks have the correct IP or username, as appropriate.

This included all the links listed in T256280:

  • Special:Contribs for both IPv4, IPv6 and usernames
  • Whois and Proxy check for IPv4 and IPv6

Other testing (including for possible regressions) done in T259964.