Since T84277 wikimedia.org/research redirects to some external closed survey site from 2014.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Change redirect for wikimedia.org/research | operations/puppet | production | +3 -3 |
Event Timeline
Comment Actions
Change 619130 had a related patch set uploaded (by Aklapper; owner: Aklapper):
[operations/puppet@production] Change redirect for wikimedia.org/research
Comment Actions
If the survey has been closed since 2014 and no one has complained, we can probably just drop the redirect all together…
Comment Actions
I think this would typically go in https://wikitech.wikimedia.org/wiki/Puppet_request_window. These should be every Tues/Thurs at 16:00 UTC and can be found in the deployments calendar.
Comment Actions
@Aklapper I just saw this after you pinged us via email. sorry about that.
@bmansurov please look into this and see if you can help. thanks!
Comment Actions
Ping - how to get someone to make a decision (e.g. +2) for a trivial patch, after four months? Thanks in advance.
Comment Actions
@Dzahn Sorry to ping you personally. I'm hoping you can point me to the right person if you can't help. Can you help with this task? My understanding based on what Baha has explained to me is that someone from Operations should +2 and that we, Research, don't have such powers. :) I'd appreciate your help. (and to be clear: while the proposal makes sense to me, I don't feel sad if the answer is that it doesn't make sense to do it. A resolution will be helpful.)
Comment Actions
Happened to see this go by -- I've dropped a single comment on the review, requesting a test be updated to match, and then I'll merge ASAP. Apologies for letting it stall for so long!
For future patches, you can indeed add them to the twice-weekly Puppet request window on the deployment calendar. (Technically, Apache config changes are out of scope, because of the breathtaking variety of ways they can go wrong, but this kind of URL swap is easy to reason about.)
You can also always reach out to the SRE on clinic duty for the week, especially if something slips through SRE triage like this.
Sorry again!
Comment Actions
@leila It's about to get deployed. We apologize for this taking so long. Yes, Andre you are right that it needs to work to get reviews in Gerrit directly.
Comment Actions
Change 619130 merged by RLazarus:
[operations/puppet@production] Change redirect for wikimedia.org/research
Comment Actions
Deployed and tested:
rzl@cumin1001:~$ httpbb /srv/deployment/httpbb-tests/appserver/* --hosts mwdebug1002.eqiad.wmnet Sending to mwdebug1002.eqiad.wmnet... PASS: 105 requests sent to mwdebug1002.eqiad.wmnet. All assertions passed.
The change will be live on all appservers within 30 minutes.
Comment Actions
Quick correction -- this is now live on all appservers, but the old URL is still cached by the traffic layer for 24 hours or so. We could purge the cache if we were in a great hurry, but all things being equal, safer to let it expire -- I'll check back tomorrow and make sure this updated as expected.
Comment Actions
Quick correction-correction: Some more reading led me to the correct cache-purging solution for a single URL like this, so this should now be visible everywhere, modulo browser caches.