Page MenuHomePhabricator
Create Task
Maniphest T260036

Fix headers in shutterbug
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The headers in the screenshot overview are not working correctly. In some cases, they don't reflect the content of the image.

Acceptance Criteria

  • Vertical headers are reduced to 1.
  • Sub-dimensions are dropped; all dimension that do not fit go into the image badge
  • Vertical headers match the description in the image badges

Event Timeline

kai.nissen created this task.Aug 10 2020, 10:13 AM
Restricted Application added a project: WMDE-FUN-Team. · View Herald TranscriptAug 10 2020, 10:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kai.nissen updated the task description. (Show Details)Aug 10 2020, 10:18 AM
kai.nissen set the point value for this task to 8.
kai.nissen moved this task from Backlog to Sprint ready on the WMDE-Fundraising-Tech board.Aug 14 2020, 8:58 AM
AbbanWMDE added a project: WMDE-FUN-Sprint-2020-08-31.Sep 7 2020, 2:40 PM
AbbanWMDE moved this task from Sprint ready to Current Sprint on the WMDE-Fundraising-Tech board.
kai.nissen moved this task from Current Sprint to Sprint ready on the WMDE-Fundraising-Tech board.Sep 16 2020, 9:27 AM
kai.nissen added a project: WMDE-FUN-Sprint-2021-01-25.Jan 25 2021, 11:35 AM
kai.nissen moved this task from Sprint ready to Current Sprint on the WMDE-Fundraising-Tech board.
kai.nissen removed a project: WMDE-FUN-Sprint-2021-01-25.Jan 27 2021, 10:10 AM
kai.nissen moved this task from Current Sprint to Sprint ready on the WMDE-Fundraising-Tech board.Feb 16 2021, 11:55 AM
kai.nissen added a project: WMDE-FUN-Sprint-2021-03-29.Mar 29 2021, 11:38 AM
AbbanWMDE moved this task from Sprint ready to Current Sprint on the WMDE-Fundraising-Tech board.Apr 1 2021, 10:53 AM
gabriel-wmde moved this task from Todo to Review on the WMDE-FUN-Sprint-2021-03-29 board.Apr 9 2021, 6:26 PM
gabriel-wmde subscribed.

I accidentally pushed to master :(

This is the commit, please do a follow-up PR or send me some comments: https://github.com/wmde/shutterbug/commit/202e5fbd07bfec950832d9931cfa69060f305f87

gabriel-wmde added a comment.Apr 12 2021, 8:16 AM

I've reverted the push and created a proper pull request: https://github.com/wmde/shutterbug/pull/185

kai.nissen added a project: WMDE-FUN-Sprint-2021-04-12.Apr 12 2021, 10:38 AM
kai.nissen changed the point value for this task from 8 to 1.
  • add horizontal rulers between rows
  • try and add pills for meta data
AbbanWMDE moved this task from Todo to Done on the WMDE-FUN-Sprint-2021-04-12 board.Apr 13 2021, 10:56 AM
kai.nissen added a comment.Apr 21 2021, 10:08 AM

@gabriel-wmde When setting the column select to "platform", the screenshots don't match the columns. Looks like the files are put in alphabetical order. Apart from that, the fix looks fine!

kai.nissen changed the point value for this task from 1 to 2.Apr 26 2021, 10:20 AM
kai.nissen added a project: WMDE-FUN-Sprint-2021-06-07.Jun 7 2021, 11:16 AM
AbbanWMDE claimed this task.Jun 16 2021, 10:08 AM
AbbanWMDE moved this task from Todo to Doing on the WMDE-FUN-Sprint-2021-06-07 board.
AbbanWMDE removed AbbanWMDE as the assignee of this task.Jun 18 2021, 4:39 AM
AbbanWMDE moved this task from Doing to Test on the WMDE-FUN-Sprint-2021-06-07 board.
AbbanWMDE subscribed.
kai.nissen moved this task from Test to Done on the WMDE-FUN-Sprint-2021-06-07 board.Jun 18 2021, 3:28 PM
kai.nissen closed this task as Resolved.Aug 16 2021, 10:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL