Page MenuHomePhabricator
Create Task
Maniphest T260074

The button crawls out of the bounds of its column in the gallery
Closed, ResolvedPublicBUG REPORT
Actions

Description

Look at the bottom left corner. The 'Add new image' button crawls out of the bounds of its column in the gallery. Google Chrome, Win10.

Steps to Reproduce:

  1. Open https://ru.wikipedia.org/wiki/Dishonored?veaction=edit with Russian interface
  2. Open Gallery menu
  3. Click on any image

Actual Results:

image.png (655×715 px, 74 KB)

Details

SubjectRepoBranchLines +/-
ve.ui.MWGalleryDialog: Allow "Add new image" button label to wrapmediawiki/extensions/VisualEditormaster+10 -0
Customize query in gerrit

Event Timeline

Iniquity created this task.Aug 10 2020, 4:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2020, 4:46 PM
Iniquity updated the task description. (Show Details)Aug 10 2020, 4:48 PM
Ailbeve subscribed.Aug 10 2020, 4:53 PM
gerritbot added a comment.Aug 11 2020, 2:09 PM

Change 619474 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWGalleryDialog: Allow "Add new image" button label to wrap

https://gerrit.wikimedia.org/r/619474

gerritbot added a project: Patch-For-Review.Aug 11 2020, 2:09 PM
matmarex claimed this task.Aug 11 2020, 2:09 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Aug 20 2020, 1:41 PM

Change 619474 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWGalleryDialog: Allow "Add new image" button label to wrap

https://gerrit.wikimedia.org/r/619474

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 20 2020, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 20 2020, 2:10 PM
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Aug 20 2020, 3:57 PM
matmarex added a project: Skipped QA.
• ppelberg closed this task as Resolved.Aug 29 2020, 1:18 AM
• ppelberg subscribed.

Looks good:

Screen Shot 2020-08-28 at 6.18.20 PM.png (1×2 px, 680 KB)

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 29 2020, 1:18 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL