Expand the list of pages where max-width does not and does apply
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 10 2020, 10:18 PM

Description

The new max width in Vector is disabled on all special pages however it seems that logic should also apply to the following pages:

Pages we should consider

@ovasileva / @alexhollender feel free to expand/collapse this list.

In addition to the existing pages the following pages should NOT get max width:

Diffs
Wikisource page namespace e.g. https://en.wikisource.org/wiki/Page:Europe_in_China.djvu/391 [2]
Category pages e.g. https://en.wikipedia.org/wiki/Category:Cleanup_tagged_articles_with_a_reason_field_from_May_2020
https://en.wikipedia.org/w/index.php?title=OKK_Beograd&type=revision&diff=971366348&oldid=971176401&diffmode=source

The following pages should get max width

Special:Preferences (see T260091 for more context)

Notes

Wikisource Page namespace:

narrow-wikisource.png (702×1 px, 263 KB)

QA Results - Beta

AC	Status	Details
1	✅	T260091#6777248
2	❌	T260091#6777248
3	✅	T260091#6777248
4	✅	T260091#6777248
5	❌	T260091#6777248 - descoped.
6	✅	T260091#6777248

QA Results - Prod

AC	Status	Details
1	✅	T260091#6875858
2	✅	T260091#6875858
3	✅	T260091#6875858
4	✅	T260091#6875858
5	⬜	T260091#6875858 - descoped.
6	✅	T260091#6875858

Details

Subject	Repo	Branch	Lines +/-
Fixes max-width configuration for new Vector	operations/mediawiki-config	master	+1 -1
Disable max-width on page namespace for wikisource (take 2)	operations/mediawiki-config	master	+36 -0
Revert "Disable max-width on page namespace for wikisource"	operations/mediawiki-config	master	+0 -18
Disable max-width on page namespace for wikisource	operations/mediawiki-config	master	+18 -0
Allow more control over the max-width rules	mediawiki/skins/Vector	master	+249 -5

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ovasileva	T260091 Expand the list of pages where max-width does not and does apply
		Resolved		ovasileva	T306834 Add max-width to Log-in & Create account pages

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Jdlrobson renamed this task from Expand pages where max-width does not apply to Expand the list of pages where max-width does not apply.Aug 11 2020, 3:57 PM

Hazard-SJ subscribed.Aug 13 2020, 1:16 AM

What do you think? Are there any other pages we should consider based on feedback?

@Jdlrobson not that I know of. I think it would be great to get the ones listed here fixed, and then we can always do this again if we find more.

FYI @ppelberg @iamjessklein we're planning to allow the source editor to be full-width. Has this been discussed with y'all?

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Aug 18 2020, 10:18 PM

Note from medium estimation:

Namespaces can be generalized so start there. The class is added in the OutputPageBodyAttributes hooks so we can easily check namespace on the server
Diff is not an action, so there handling for edit and diff cannot be generalized.
There is risk the editor may require adding/removing the class in JavaScript which adds an additional layer

Jdlrobson moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Aug 19 2020, 5:16 PM

Jdlrobson changed the point value for this task from 5 to 3.

Jdlrobson changed the point value for this task from 3 to 5.

Jdlrobson changed the point value for this task from 5 to 3.Aug 19 2020, 5:20 PM

Please also consider adding main pages to the list, given that they usually already use two-column layout, which may make your changes quite breaking given the different expectations in new Vector and other skins.

ovasileva updated the task description. (Show Details)Aug 31 2020, 10:01 AM

SGill subscribed.Aug 31 2020, 10:40 AM

ovasileva updated the task description. (Show Details)Sep 1 2020, 3:53 PM

ovasileva mentioned this in T261663: Add max-width CSS rule to the Special:Preferences page.

ovasileva updated the task description. (Show Details)Sep 1 2020, 4:08 PM

ovasileva moved this task from Ready for Development to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Oct 15 2020, 5:55 PM

Jdlrobson updated the task description. (Show Details)Oct 15 2020, 6:05 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson renamed this task from Expand the list of pages where max-width does not apply to Expand the list of pages where max-width does not and does apply.Oct 15 2020, 6:08 PM

Jdlrobson updated the task description. (Show Details)

ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Oct 28 2020, 1:55 PM

ovasileva moved this task from Ready for Development to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Nov 2 2020, 6:21 PM

Jdlrobson claimed this task.Jan 6 2021, 4:59 PM

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson merged a task: T261663: Add max-width CSS rule to the Special:Preferences page.Jan 6 2021, 8:18 PM

Change 654678 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] Allow more control over the max-width rules

https://gerrit.wikimedia.org/r/654678

gerritbot added a project: Patch-For-Review.Jan 6 2021, 9:50 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 6 2021, 9:51 PM

phuedx moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 8 2021, 6:45 PM

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 11 2021, 11:15 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 12 2021, 10:40 PM

Per @DannyS712's review.

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 20 2021, 6:11 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 20 2021, 7:10 PM

Jdlrobson reassigned this task from Jdlrobson to phuedx.Jan 21 2021, 6:09 PM

Change 654678 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Allow more control over the max-width rules

https://gerrit.wikimedia.org/r/654678

Jdlrobson reassigned this task from phuedx to Edtadros.Jan 21 2021, 7:47 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 21 2021, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 21 2021, 8:12 PM

@Edtadros to clarify, as discussed in standup, here is what we mean by pages with and without max-width:

pages with max-width	pages without max-width

example page	example page

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

In addition to the existing pages the following pages should NOT get max-width:

✅ AC1: Diffs

Screen Shot 2021-01-26 at 6.18.55 AM.png (996×1 px, 291 KB)

❌ AC2: Wikisource page namespace e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Page:Illegality_of_the_trial_of_John_W._Webster_-_Spooner_-_1850.pdf/10

Screen Shot 2021-01-26 at 6.21.21 AM.png (998×1 px, 259 KB)

✅ AC3: Category pages e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Category:Wikipedia_how-to

Screen Shot 2021-01-26 at 6.22.52 AM.png (1×1 px, 298 KB)

✅ AC4: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Wikipedia:New_user_landing_page&curid=188487&diff=472400&oldid=470167&diffmode=source

Screen Shot 2021-01-26 at 6.25.35 AM.png (1×1 px, 219 KB)

❌ AC5: TBD: Source editor https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Wikipedia:New_user_landing_page&action=edit

Screen Shot 2021-01-26 at 6.26.47 AM.png (998×1 px, 284 KB)

The following pages should get max-width

✅ AC6: Special:Preferences (see T260091 for more context)

Screen Shot 2021-01-26 at 6.28.17 AM.png (998×1 px, 170 KB)

Edtadros updated the task description. (Show Details)Jan 26 2021, 2:35 PM

Wikisource will require a configuration change and to be QAed in production. I'll get to that this week.

As for editing, the acceptance criteria said "to be decided" (TBD) @ovasileva @alexhollender can you confirm that it should be disabled on editor? Note there is no obvious way to target source editor separately from VisualEditor so this would be all editing experiences. If needed, the editing team would be better placed to do this.

Will do config change.

In T260091#6777871, @Jdlrobson wrote:

Wikisource will require a configuration change and to be QAed in production. I'll get to that this week.

As for editing, the acceptance criteria said "to be decided" (TBD) @ovasileva @alexhollender can you confirm that it should be disabled on editor? Note there is no obvious way to target source editor separately from VisualEditor so this would be all editing experiences. If needed, the editing team would be better placed to do this.

Discussed this in standup. Let's hold on any changes to editing for now and I'll follow up with @ppelberg

Change 659079 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Disable max-width on page namespace for wikisource

https://gerrit.wikimedia.org/r/659079

gerritbot added a project: Patch-For-Review.Jan 27 2021, 8:46 PM

Change 659079 merged by jenkins-bot:
[operations/mediawiki-config@master] Disable max-width on page namespace for wikisource

https://gerrit.wikimedia.org/r/659079

Maintenance_bot removed a project: Patch-For-Review.Jan 28 2021, 12:10 AM

Change 659106 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Revert "Disable max-width on page namespace for wikisource"

https://gerrit.wikimedia.org/r/659106

Change 659106 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Disable max-width on page namespace for wikisource"

https://gerrit.wikimedia.org/r/659106

Change 659102 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Disable max-width on page namespace for wikisource (take 2)

https://gerrit.wikimedia.org/r/659102

Change 659102 merged by jenkins-bot:
[operations/mediawiki-config@master] Disable max-width on page namespace for wikisource (take 2)

https://gerrit.wikimedia.org/r/659102

Mentioned in SAL (#wikimedia-operations) [2021-01-28T00:49:19Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: 87c304c5439b1b7898f951db61d0a0a8a11ee4f7: Disable max-width on page namespace for wikisource (T260091; 2nd take) (duration: 01m 00s)

Maintenance_bot removed a project: Patch-For-Review.Jan 28 2021, 1:10 AM

AC2 is still not working.

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 1 2021, 6:16 PM

Change 667688 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Fixes max-width configuration for new Vector

https://gerrit.wikimedia.org/r/667688

gerritbot added a project: Patch-For-Review.Mar 1 2021, 6:49 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 1 2021, 6:50 PM

Change 667688 merged by jenkins-bot:
[operations/mediawiki-config@master] Fixes max-width configuration for new Vector

https://gerrit.wikimedia.org/r/667688

Mentioned in SAL (#wikimedia-operations) [2021-03-02T00:46:26Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 61647cd191b9bc5e2d8672fa4813b57d958f1a68: Fixes max-width configuration for new Vector (T260091) (duration: 00m 56s)

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Mar 2 2021, 1:11 AM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Wikisource should now be fixed. Please run through QA steps again. Sorry for the delay on this one.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki, wikisource
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

In addition to the existing pages the following pages should NOT get max-width:

✅ AC1: Diffs

Screen Shot 2021-03-02 at 9.54.25 AM.png (1×1 px, 394 KB)

✅ AC2: Wikisource page namespace e.g. https://en.wikisource.org/wiki/Page:Europe_in_China.djvu/391 [2]

Screen Shot 2021-03-02 at 10.38.13 AM.png (1×1 px, 1 MB)

✅ AC3: Category pages e.g. https://en.wikipedia.org/wiki/Category:Cleanup_tagged_articles_with_a_reason_field_from_May_2020

Screen Shot 2021-03-02 at 10.12.16 AM.png (1×1 px, 324 KB)

✅ AC4: https://en.wikipedia.org/w/index.php?title=OKK_Beograd&type=revision&diff=971366348&oldid=971176401&diffmode=source

Screen Shot 2021-03-02 at 10.13.15 AM.png (1×1 px, 314 KB)

⬜ AC5: Source editor is not in scope.

The following pages should get max-width

✅ AC6: Special:Preferences (see T260091 for more context)

Screen Shot 2021-03-02 at 10.16.06 AM.png (1×1 px, 206 KB)

Edtadros updated the task description. (Show Details)Mar 2 2021, 7:45 PM

stjn unsubscribed.Mar 3 2021, 2:10 PM

All done!

• alexhollender_WMF mentioned this in T306353: Adjust placement of tabs for full-width pages.Apr 18 2022, 3:59 PM

• alexhollender_WMF added a subtask: T306834: Add max-width to Log-in & Create account pages.Apr 25 2022, 6:55 PM

ovasileva closed subtask T306834: Add max-width to Log-in & Create account pages as Resolved.Apr 28 2022, 10:18 AM

	F34131929: Screen Shot 2021-03-02 at 10.13.15 AM.png
	Mar 2 2021, 6:39 PM

	F34131931: Screen Shot 2021-03-02 at 10.16.06 AM.png
	Mar 2 2021, 6:39 PM

	F34131927: Screen Shot 2021-03-02 at 10.12.16 AM.png
	Mar 2 2021, 6:39 PM

	F34131987: Screen Shot 2021-03-02 at 10.38.13 AM.png
	Mar 2 2021, 6:39 PM

	F34131925: Screen Shot 2021-03-02 at 9.54.25 AM.png
	Mar 2 2021, 6:39 PM

	F34026230: Screen Shot 2021-01-26 at 6.28.17 AM.png
	Jan 26 2021, 2:31 PM

	F34026217: Screen Shot 2021-01-26 at 6.22.52 AM.png
	Jan 26 2021, 2:31 PM

	F34026226: Screen Shot 2021-01-26 at 6.26.47 AM.png
	Jan 26 2021, 2:31 PM

Expand the list of pages where max-width does not and does applyClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Pages we should consider

Notes

QA Results - Beta

QA Results - Prod

Details

Related ObjectsSearch...

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Expand the list of pages where max-width does not and does apply
Closed, ResolvedPublic3 Estimated Story Points
Actions

Related Objects
Search...