Page MenuHomePhabricator

Pick a sentence: Card for already translated sentences
Closed, ResolvedPublic

Description

As part of the "Pick a sentence" step (T251551) of the Section Translation mobile editor, users can select sentences that have been already translated. In such case, the card does not show the proposed translation (T259502), but information on the translation provided by the user and an option to edit it.

The affected text is shown highlighted in blue, and options to inspect the whole paragraph may be available.

Messages:

Your translation
X% edited by you
No edits by you

You can check for more details in the parent ticket: T251551: Section Translation Editor: Pick a sentence

Event Timeline

Pginer-WMF created this task.

Change 650018 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Pick a sentence: Add card for already translated segments

https://gerrit.wikimedia.org/r/650018

A participant on the early feedback about Section translation at the test server mentioned as a missing aspect progress information such as "your translation contains xx% of unmodified text" which this ticket is related to.

Change 657815 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Translated Segment Card: Add support for paragraph tab

https://gerrit.wikimedia.org/r/657815

Change 650018 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX Pick a sentence: Add card for already translated segments

https://gerrit.wikimedia.org/r/650018

Change 657815 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX Translated Segment Card: Add support for paragraph tab

https://gerrit.wikimedia.org/r/657815

There was a relevant question about color contrast. currently the yellow and green used does not provide enough contrast. Here we can use the darker versions (Yellow30 and Green30) instead. I'll update the spec in the description.

Change 659241 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Translated Segment Card: Fix color contrast for MT progress bars

https://gerrit.wikimedia.org/r/659241

There was a relevant question about color contrast. currently the yellow and green used does not provide enough contrast. Here we can use the darker versions (Yellow30 and Green30) instead. I'll update the spec in the description.

Fixed in above patch

There was a relevant question about color contrast. currently the yellow and green used does not provide enough contrast. Here we can use the darker versions (Yellow30 and Green30) instead. I'll update the spec in the description.

Fixed in above patch

Perfect. Thanks!

I noticed that once I add a sentence by starting from an empty sentence, the card no longer appears when I try to select the sentence I added later.

This may be already known or in the works, but I can create a new ticket otherwise.

@Pginer-WMF I was not aware about this. Please create a new ticket about it.

@Pginer-WMF I was not aware about this. Please create a new ticket about it.

Sure. Just created T273444: Card for already translated sentences disappear after starting with an empty sentence.
Please let me know if anything is missing there.

Change 659241 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX Translated Segment Card: Fix color contrast for MT progress bars

https://gerrit.wikimedia.org/r/659241

As mentioned in the patch notes by Nik, the accessibility requirements are not met yet.

A participant on the early feedback about Section translation at the test server mentioned as a missing aspect progress information such as "your translation contains xx% of unmodified text" which this ticket is related to.

did this user use content translation before?

@Pginer-WMF when I make a small change (delete one space) to the text it still says "no edits by you".
It should say "1%" and then grow from there, correct?

@Pginer-WMF there's no way to restart the translation (retranslate with MT or start with blank) once I click apply?

@Pginer-WMF when I make a small change (delete one space) to the text it still says "no edits by you".
It should say "1%" and then grow from there, correct?

Overall, we don't aim for perfect precision, but I agree that a change like that (from no edit to some edit) seems worth reflecting to acknowledge the change. Technically a small change may represent less than 1% of the content (depending on the length of it). One approach we could consider is to round upwards. In this way, the initial progress will happen with any change. We need to think on the implications for MT limits, but I don't think it would be problematic.

@Pginer-WMF there's no way to restart the translation (retranslate with MT or start with blank) once I click apply?

No. We are assuming a linear workflow where user move from one sentence to the next correcting and applying the translation, with occasionally editing the translated text. We want to avoid surfacing too many options on a smaller device. Having said that, during research we'll observe usage patterns to see if those assumptions are correct.

Just for clarification: the algorithm used for calculating MT percentages on the client side is far from optimal. We are using a quite naive implementation with fast-levenshtein algorithm to calculate distance between active and suggested translation. Since this is only the first version of this feature, it was a trade-off so that we can have something working properly as early as possible. We can always refine our logic afterwards. For now I would agree about rounding up MT percentages.

Just for clarification: the algorithm used for calculating MT percentages on the client side is far from optimal. We are using a quite naive implementation with fast-levenshtein algorithm to calculate distance between active and suggested translation. Since this is only the first version of this feature, it was a trade-off so that we can have something working properly as early as possible. We can always refine our logic afterwards. For now I would agree about rounding up MT percentages.

is this going to be done in this task (meaning, one single change goes to 1%) or want me to create a new task?

No. We are assuming a linear workflow where user move from one sentence to the next correcting and applying the translation, with occasionally editing the translated text. We want to avoid surfacing too many options on a smaller device. Having said that, during research we'll observe usage patterns to see if those assumptions are correct.

it makes sense and it will probably be the case where a user goes through the normal flow without going back.

I suggest to create a new ticket for that but I'll leave it to Pau

I suggest to create a new ticket for that but I'll leave it to Pau

Agree. Let's have a separate ticket. In this way we can decide late whether to take it independently or as part of the general review of the MT limits.