Page MenuHomePhabricator

Pick a sentence: Feedback when tapping on selected sentences
Closed, ResolvedPublic

Description

As part of the "Pick a sentence" step (T251551) of the Section Translation mobile editor, users manipulate sentences in the translation using the card at the bottom. We want to provide feedback for users trying to interact directly with the active sentence to direct their attention to the card below.

Tapping the highlighted sentence makes the "Proposed translation" card at the bottom to "jump" in order to attract the user attention.

Pending: Tapping on a sentence that is not highlighted already should not produce any "jump"

Pick a sentence - Translated Tapping.png (768×1 px, 113 KB)

highlight-jump.gif (626×334 px, 1 MB)

You can check for more details in the parent ticket: T251551: Section Translation Editor: Pick a sentence

Event Timeline

Pginer-WMF created this task.

Change 623350 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXSentenceSelector: Bounce proposed translation on selected sentence click

https://gerrit.wikimedia.org/r/623350

Change 623350 merged by Santhosh:
[mediawiki/extensions/ContentTranslation@master] SXSentenceSelector: Bounce proposed translation on selected sentence click

https://gerrit.wikimedia.org/r/623350

As mentioned in T259500#6473909:

The jump for the translation card (T260129) is only intended for cases when the user selects a sentence that was already highlighted. The card should not jump when selecting a sentence that is not already highlighted.

However, in the current implementation, the jump occurs when tapping on any sentence (being previously selected or not).

Pginer-WMF lowered the priority of this task from Medium to Low.Sep 24 2020, 8:26 AM
Pginer-WMF updated the task description. (Show Details)

Change 629648 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXSentenceSelector: Fix regression glitch for selected sentence bounce

https://gerrit.wikimedia.org/r/629648

Change 629648 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SXSentenceSelector: Fix regression for selected sentence bounce

https://gerrit.wikimedia.org/r/629648

Pginer-WMF updated the task description. (Show Details)