Page MenuHomePhabricator

Follow-up after publishing: Panel to confirm publication
Closed, ResolvedPublic

Description

As part of the "Show follow-up options after publishing" step (T241592) of the section translation workflow, users get an invite to translate another section as they get confirmation that it was published.

This ticket is focused on showing the panel at the bottom of the viewport with the confirmation message. The action to translate another section (T260137) and the highlight for the section (T260139) are covered in other tickets.

More details available in the parent ticket: T241592: Section Translation: Show follow-up options after publishing

Event Timeline

Pginer-WMF triaged this task as Medium priority.Aug 11 2020, 1:57 PM
Pginer-WMF created this task.

Change 639181 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXPublishConfirmer: Add confirmation panel

https://gerrit.wikimedia.org/r/639181

Change 639181 abandoned by Nik Gkountas:
[mediawiki/extensions/ContentTranslation@master] SXPublishConfirmer: Add confirmation panel

Reason:

https://gerrit.wikimedia.org/r/639181

Pginer-WMF raised the priority of this task from Medium to High.Dec 1 2020, 9:24 AM

Change 657304 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Add confirmation panel in target article after publishing

https://gerrit.wikimedia.org/r/657304

Change 657304 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX Add confirmation panel in target article after publishing

https://gerrit.wikimedia.org/r/657304

Jpita added a subscriber: Jpita.

2 issues:

  • panel doesn't fit the viewport, I need to scroll horizontally to see the X button to close

  • X close button only closes the top part of the banner , not the invite

@ngkountas moving this to In Progress to be fixed

@Jpita I'm not able to replicate this one on test server.

. Even when there is some extra space on the right, I see that the "follow-up" panel is always fixed to 100% of width and close button is visible to me. By the way this extra space is caused by unrelated mediawiki's errors and is not being caused by this panel.
. Could you help me reproducing or check again to see if it's still happening?

Could you help me reproducing or check again to see if it's still happening?

Steps:
0-set chrome devtools mobile view to "Moto G4"
1-go to sx main page
2-click "Translate "Salt" from English to French"
3-select the first section and translate 3 sentences (click apply 3 times)
4-publish the translation
5-scroll down until you see the banner and then scroll right