Page MenuHomePhabricator

Follow-up after publishing: Highlight published section and scroll to it
Closed, ResolvedPublic

Description

As part of the "Show follow-up options after publishing" step (T241592) of the section translation workflow, users get an invite to translate another section as they get confirmation that it was published.

This ticket is focused on highlighting the published section. When the user arrives to the article page, automatically (using mobile editor) or manually (using Content Translation), the article page is shown first to provide context, and a transition scrolls the page down and highlights the published section.

Contribute again - Highlight.png (768×1 px, 138 KB)
Contribute again - Highlight Dimensions.png (768×1 px, 72 KB)

Transition:

Contribute again - Transition.png (768×1 px, 262 KB)

More details available in the parent ticket: T241592: Section Translation: Show follow-up options after publishing

Event Timeline

Change 639087 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Follow-up after publishing: Create SFC

https://gerrit.wikimedia.org/r/639087

Change 639087 abandoned by Nik Gkountas:
[mediawiki/extensions/ContentTranslation@master] SX Follow-up after publishing: Create SFC

Reason:

https://gerrit.wikimedia.org/r/639087

ngkountas added a subscriber: ngkountas.

Change 656926 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Highlight published section after publishing and scroll to it

https://gerrit.wikimedia.org/r/656926

Change 656926 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX Highlight published section after publishing and scroll to it

https://gerrit.wikimedia.org/r/656926

Copying from Gerrit for visibility:

NL: Another comment with regards to non-unique titles. When I tested this and added another section with same name, that section was appended to the end, but the one that was highlighted was the older one. This likely doesn't happen much in practice and isn't easily fixed, so I think it's okay.

NG: I agree this is not expected to occur very often. I guess article pages aren't supposed to have duplicate sections (although it can be more often when publishing in sandbox)

Jpita added a subscriber: Jpita.

2 issues:

first screensecond screen after manual scrolling (no auto-scroll)
image.png (1×828 px, 137 KB)
image.png (1×802 px, 64 KB)

New ticket or you'll fix it on this ticket @ngkountas ?

The first issue seems like a mediawiki core issue. @KartikMistry is it something that can be fixed by pulling latest updates for objectcache package? About the second one I'll take care of it, no need for additional ticket.

2 issues:

first screensecond screen after manual scrolling (no auto-scroll)
image.png (1×828 px, 137 KB)
image.png (1×802 px, 64 KB)

New ticket or you'll fix it on this ticket @ngkountas ?

@Jpita I can make this work on mobile. See screenshots:

First screenSecond screen after manual scrolling (no auto-scroll)
Screenshot_20210203-115547.jpg (1×720 px, 130 KB)
Screenshot_20210203-115644.jpg (1×720 px, 312 KB)

The first issue seems like a mediawiki core issue. @KartikMistry is it something that can be fixed by pulling latest updates for objectcache package? About the second one I'll take care of it, no need for additional ticket.

We have ticket for first issue: https://phabricator.wikimedia.org/T273364

This comment was removed by ngkountas.

Change 661717 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Highlight published section: Fix for section titles with spaces

https://gerrit.wikimedia.org/r/661717

@Jpita @ngkountas @Pginer-WMF I've tried this in other mobile device and I saw that the "new" indicator is aligned to right. See screenshots:

Screenshot_20210204-151356_Chrome.jpg (1×971 px, 148 KB)

Screenshot_20210204-151515_Chrome.jpg (1×947 px, 320 KB)

Also missing is the title of the new and published section (the section header) must be in a serif font with bold font weight, and the "new" indicator must be in a sans serif font with font weight "bold" instead of a serif font.

Change 661717 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX Highlight published section: Fix for section titles with spaces

https://gerrit.wikimedia.org/r/661717

[...]the "new" indicator must be in a sans serif font with font weight "bold" instead of a serif font.

That's correct. In addition the background for such label looks like an ellipsis. However, the spec was using a rectangle with the rounding only at their sides. I think this can be achieved with a 1em border radius.

In any case, these are smaller adjustments that can go in a separate ticket if that's preferred.

2 issues:

first screensecond screen after manual scrolling (no auto-scroll)
image.png (1×828 px, 137 KB)
image.png (1×802 px, 64 KB)

New ticket or you'll fix it on this ticket @ngkountas ?

This fix is now ready:

Screenshot_20210210-111957.jpg (1×720 px, 306 KB)

And in desktop:

image.png (768×1 px, 232 KB)

In desktop with mobile view:
image.png (768×1 px, 173 KB)

Waiting for Nik's feedback on if we fix those issues here or on a new ticket

Please feel free to create new tickets about these issues, I think these are not important blockers for this task.

Please feel free to create new tickets about these issues, I think these are not important blockers for this task.

I created a separate ticket: T274856: New section label style needs polishing

@Jpita feel free to move to "done" if there are no other issues apart from those described in the ticket, or continue the QA process if there were more aspects to evaluate.