Page MenuHomePhabricator
Create Task
Maniphest T260156

PopupToolGroup cannot be accessed by Keyboard unless PopupWidget is opened
Closed, InvalidPublic
Actions

Description

In T257165
The fixed added functionality to close the popup when the user tabs away

It has been observed that once PopupWidget was accessed, PopupToolGroup can no longer be traversed to by keyboard and closes right away.

PopupKeyboardNav.gif (527×502 px, 216 KB)

If PopupWidget is opened and stay open, PopupToolGroup can be access

Details

ProjectBranchLines +/-Subject
oojs/uimaster+24 -20PopupToolGroup: Fix keyboard nav not working
Customize query in gerrit

Related Objects

Event Timeline

Tam-edwin-microsoft created this task.Aug 11 2020, 3:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2020, 3:48 PM
gerritbot added a comment.Aug 11 2020, 4:16 PM

Change 619494 had a related patch set uploaded (by Tam-edwin-microsoft; owner: Tam-edwin-microsoft):
[oojs/ui@master] PopupToolGroup: Fix keyboard nav not working

https://gerrit.wikimedia.org/r/619494

gerritbot added a project: Patch-For-Review.Aug 11 2020, 4:16 PM
Tam-edwin-microsoft renamed this task from Popup ToolGroup cannot be accessed by Keyboard unless PopupWidget is opened to PopupToolGroup cannot be accessed by Keyboard unless PopupWidget is opened.Aug 11 2020, 4:25 PM
Tam-edwin-microsoft added a comment.Dec 19 2020, 7:48 AM

Just want to double check on the status of this patch. Looks like it's still pending review. Thanks!

matmarex added a subscriber: matmarex.Jul 15 2021, 12:29 PM

I can't reproduce this.

gerritbot added a comment.Aug 18 2021, 11:48 PM

Change 619494 abandoned by VolkerE:

[oojs/ui@master] PopupToolGroup: Fix keyboard nav not working

Reason:

Not reproducible as currently described.

https://gerrit.wikimedia.org/r/619494

Volker_E closed this task as Invalid.Aug 18 2021, 11:48 PM
Volker_E added a subscriber: Volker_E.

Not reproducible as currently described. Feel free to re-open with a clearer test case.

Volker_E removed Tam-edwin-microsoft as the assignee of this task.Aug 18 2021, 11:49 PM
Volker_E removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL