Page MenuHomePhabricator

Translation dashboard lists: Suggestions list update
Closed, ResolvedPublic

Description

As part of the update of the Translation Dashboard to support section translation (T253253), we want to make sure that translations in all states are properly represented.

This ticket focuses on the suggestions list. For section translation it is divided in two separate groups ("New pages" and "Expand with new sections"):

Dashboard lists - Suggestions.png (768×1 px, 272 KB)

More details available in the parent ticket: T253253: Section translation: Add support for translation dashboard lists

Event Timeline

Pginer-WMF renamed this task from Translation dashboard lists: Suggestions lists to Translation dashboard lists: Suggestions list update.Aug 11 2020, 4:36 PM
Pginer-WMF created this task.
Pginer-WMF triaged this task as Medium priority.Sep 3 2020, 8:29 AM
Pginer-WMF moved this task from Backlog to Entry points on the SectionTranslation board.
Pginer-WMF raised the priority of this task from Medium to High.Jan 12 2021, 1:43 PM

Change 664773 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Dashboard: Add refresh section suggestion list button

https://gerrit.wikimedia.org/r/664773

Change 664773 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX Dashboard: Add refresh section suggestion list button

https://gerrit.wikimedia.org/r/664773

@KartikMistry is there a reason why the version tag is missing on this task?

From gerrit's patch

image.png (364×896 px, 28 KB)

@ngkountas I can't see any "New Pages"

image.png (144×1 px, 23 KB)

I can only see "Expand with new sections", how can I make it load different articles?

@Pginer-WMF the "Refresh suggestions" button only works 3 times, then it always show the same articles.
according to the doc it should always refresh

image.png (460×1 px, 263 KB)

Also it only shows 5 articles instead of 6

Thanks for the comments, @Jpita. You touch relevant areas where there may be some moving pieces. I'll provide more detail below:

@ngkountas I can't see any "New Pages"

Section translation does not support yet the creation of new articles (T260144). Thus, suggestions for creating new articles were hidden (T270691) to avoid leading users towards a dead-end. This is the reason why only the "New Pages" group is shown right now. This will change once T260144 is completed.

@Pginer-WMF the "Refresh suggestions" button only works 3 times, then it always show the same articles.
according to the doc it should always refresh

image.png (460×1 px, 263 KB)

"always show the same articles" does it mean that it remains with the last set shown, or that it cycles back to the first set of articles again?

Refresh should show a new set of articles after taping the button. Because of our basic suggestion approach it is ok if there is a limited set of articles and we cycle through them, but we should avoid the situation where tapping "refresh" results in no change at all in the list.

Also it only shows 5 articles instead of 6

Once we support creation of new articles, the idea is to suggest 3 creations and 3 expansions. While we only provide suggestions to expand existing articles we can show 6. However, if making this change is not really trivial, it is ok to wait until we can provide both kinds of suggestions and then adjust this as per the spec.

"always show the same articles" does it mean that it remains with the last set shown, or that it cycles back to the first set of articles again?

cycle back to the first set.

all is good then

Change 676017 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Fix CXArticleItem action slot

https://gerrit.wikimedia.org/r/676017

Change 676018 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Fix CXTranslationSuggestion info slot

https://gerrit.wikimedia.org/r/676018

Change 676028 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CXSuggestionList.vue: Add discard section suggestion functionality

https://gerrit.wikimedia.org/r/676028

Change 676028 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CXSuggestionList.vue: Add discard section suggestion functionality

https://gerrit.wikimedia.org/r/676028

Change 676018 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CXTranslationSuggestion: Fix info to display missing sections count

https://gerrit.wikimedia.org/r/676018

this one is still available and also not doing anything, is this OK?

image.png (228×804 px, 19 KB)

this one is still available and also not doing anything, is this OK?

image.png (228×804 px, 19 KB)

This is part fo the confirmation step which will be revamped soon (T276221). In the new implementation it would be worth not to include the icon until the feature for "Keeping for later" is supported. ( CC @ngkountas )