Page MenuHomePhabricator

Incorrect browser URL when viewing diffs and visual differences
Closed, DuplicatePublicBUG REPORT

Description

Steps to Reproduce:

  • Enable the Visual differences beta feature
  • Navigate to a diff on a page and expand the Revision-Slider ( does not matter if consecutive diff or not )
  • Browse the diff history using the slider or by clicking Previous edit or Next edit

Actual Results:

  • For a second you can see the "correct, fitting" revision ids being update in the URL as you move
  • A moment later the ids will be overriden and you can only see the ids of the firstly selected diff

Expected

  • See the fitting diffs reflecting the movement with the slider or links clicked

This makes it really difficult to send page links to revisions after using Revision Slider.

A fix would be greatly appreciated.
Thanks!
Ivi104

Event Timeline

Aklapper changed the task status from Open to Stalled.Aug 12 2020, 10:51 AM

Hi @Ivi104, thanks for taking the time to report this!

Cannot reproduce:

  1. Firefox 79
  2. I go to https://hr.wikipedia.org/w/index.php?title=Petra_Kova%C4%8Devi%C4%87&action=history (random page)
  3. I select the last two revisions and I click Usporedi izabrane inačice
  4. I click Pregledaj povijest
  5. I move the RevisionSlider sliders to other revisions

The diff and oldid URL parameters get updated.

Which web browser and version is used? Can you also reproduce with another web browser? Please also see https://www.mediawiki.org/wiki/How_to_report_a_bug - thanks!

Browser: MS Edge version 84.0.522.59 (Official) (64-bit)

I tried the steps above again, and noticed that the URL updates for a split second (shows index.php?diff= and then resets to the faulty one (shows index.php?title=).

I replicated the issue with and without safemode in MS Edge and Firefox versions 76.0.1 (64-bit) and 79.0 (64-bit).

I tried debug=true&safemode=1 in MS Edge and got the following warnings (no errors) - idk if they are relevant to the issue:

[Intervention] Images loaded lazily and replaced with placeholders. Load events are deferred. See https://go.microsoft.com/fwlink/?linkid=2048113
content.js:5 --------init----------- https://hr.wikipedia.org/w/index.php?title=Petra_Kova%C4%8Devi%C4%87&type=revision&diff=5553699&oldid=5553688&diffmode=source&debug=true&safemode=1
jquery.migrate.js?075cf:81 JQMIGRATE: Migrate is installed with logging active, version 3.1.0
jquery.migrate.js?075cf:114 JQMIGRATE: jQuery.fn.delegate() is deprecated
migrateWarn @ jquery.migrate.js?075cf:114
delegate @ jquery.migrate.js?075cf:562
bindHover @ jquery.ui.datepicker.js?9edde:1780
Datepicker @ jquery.ui.datepicker.js?9edde:113
(anonymous) @ jquery.ui.datepicker.js?9edde:1837
(anonymous) @ jquery.ui.datepicker.js?9edde:1846
76[Violation] Added non-passive event listener to a scroll-blocking <some> event. Consider marking event handler as 'passive' to make the page more responsive. See <URL>
jquery.js?11c05:3623 [Violation] 'setTimeout' handler took 72ms
jquery.js?11c05:3623 [Violation] 'setTimeout' handler took 52ms
Aklapper changed the task status from Stalled to Open.Aug 13 2020, 9:50 AM
Aklapper removed a subscriber: Revision-Slider.
thiemowmde changed the subtype of this task from "Task" to "Bug Report".

Hi @Ivi104. I'm also not able to reproduce the issue you reported neither in FF nor MS Edge. Therefore I guess that it might be related to specific gadgets or user scripts you use. It would be helpful if you could either:

  • deactivate any gadgets and user script code and see if the issue is still appearing
  • or post the list of gadgets enabled and quote the user script code used so I could try to reproduce with these settings

Thanks in advance!

@WMDE-Fisch Thank you for responding. I've managed to isolate the issue. The problem only happens when VisualDiff beta feature is enabled. Please confirm if you can reproduce the issue when enabling VisualDiff and doing the steps described in my previous comment.

@WMDE-Fisch Thank you for responding. I've managed to isolate the issue. The problem only happens when VisualDiff beta feature is enabled. Please confirm if you can reproduce the issue when enabling VisualDiff and doing the steps described in my previous comment.

Yes, I can confirm this. When using the VisualEditor-VisualDiffs beta feature the URL will be overwritten by some JS trigger and instead of the correct, changed parameters you see the firstly selected revision ids. - I will update the ticket accordingly.

WMDE-Fisch renamed this task from Incorrect browser URL when viewing non-consecutive diffs to Incorrect browser URL when viewing diffs and visual differences.Nov 20 2020, 11:17 AM
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch moved this task from Currently in sprint to Maintenance Backlog on the WMDE-TechWish board.

Needs to be triaged before the next maintenance sprint.