at ve.ce.Surface.prototype.getViewportRange URL1:509:864 at ve.ui.FindAndReplaceDialog.prototype.renderFragments URL1:772:417 at ve.ui.FindAndReplaceDialog.prototype.onWindowScroll URL1:769:832 at run URL2:605:645 URL1: https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.base%2Ccore%2CdesktopTarget%2Cdiffing%2Cicons%2Clanguage%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsignature%2Cmwtransclusion%2Cmwwikitext%2Csanitize%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core&skin=vector&version=ag0wg URL2: https://www.mediawiki.org/w/load.php?lang=en&modules=ext.centralNotice.choiceData%2CgeoIP%2CstartUp%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.discussionTools.init%7Cext.echo.api%2Cinit%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.uls.common%2Ccompactlinks%2Cinit%2Cinterface%2Cpreferences%2Cwebfonts%7Cext.wikimediaEvents.loggedin%7Cjquery%2Cmoment%2Coojs%2Coojs-router%2Coojs-ui-core%2Coojs-ui-windows%2Crangefix%2Csite%7Cjquery.client%2Ccookie%2Cspinner%2CtextSelection%7Cjquery.spinner.styles%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Ctoc%2Cuser%2Cutil%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%2Cstartup%7Cmediawiki.page.watch.ajax%7Cmediawiki.ui.button%7Cmmv.bootstrap%2Chead%7Cmmv.bootstrap.autostart%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-windows.icons%7Coojs-ui.styles.indicators%7Cskins.vector.js%7Cuser.defaults%7Cwikibase.client.linkitem.init&skin=vector&version=1ibx7
Description
Description
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | matmarex | T264487 Confirm client-side errors are no longer occurring | |||
| Resolved | Esanders | T260212 TypeError: dimensions is null |
Event Timeline
Comment Actions
Message: TypeError: dimensions is null
Useragent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0
at ve.ce.Surface.prototype.getViewportRange <url> at ve.ui.FindAndReplaceDialog.prototype.renderFragments <url> at ve.ui.FindAndReplaceDialog.prototype.onWindowScroll <url>
Comment Actions
This is the same as T261522 except when there are more than 50 results.
Both can be semi-reproduced by opening find-and-replace, removing the surface ($('.ve-ui-surface').remove()), then resizing the window to trigger onScroll.
Comment Actions
Change 626476 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] More direct fix for find-and-replace running after teardown issues
Comment Actions
Change 626476 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] More direct fix for find-and-replace running after teardown issues
Comment Actions
Change 626737 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (22a771930)
Comment Actions
Change 626737 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (22a771930)
Comment Actions
Instead of QA, we should check the logs to confirm this error has disappeared after the patches are deployed.
Comment Actions
@ppelberg is going to file a parent task for the engineers to check a batch of these in two weeks.
Comment Actions
Search URL: https://logstash.wikimedia.org/goto/9b4b464010ae4d9ced89485a893ae0c8
Hasn't come back, but also wasn't that frequent before the fix.
Comment Actions
Deployed with wmf.9 on 17 September. No new errors since then: https://logstash.wikimedia.org/goto/ce8fd4b1e80a7911276113c2302c4d72
