I wonder if wp_bundle_eligible should be False if the user hasn't agreed to the terms of use, but I'm not sure that's easily implementable since we only update wp_bundle_eligible on login and via the cron. I don't think we should spend that much time on this.

I don't think this rises to a level of needing to be security protected.

I am claiming this task and will find out a solution since I am running MWVagrant.

MWVagrant won't help you here unfortunately - the Library Card platform is a tool hosted on Cloud VPS. See https://github.com/wikipedialibrary/twlight for information on how to set this tool up :)

I have got that, in the progress of being built.

Anyway. I claimed the task, and I will do my best in fixing this.

Thanks! Let me know if you have any questions.

We discussed checking terms agreement in all code that works with user auths. The idea is that if the user hasn't agree to terms, the platform should behave as if the user had no auths and display a warning message indicating that they need to agree to terms.

My recollection is that this should just impact a few views, and maybe email tasks and/or management commands.
We also discussed that terms agreement should be a part of the bundle eligibility check.

This task is flagged as good first task.

I have removed the good first task tag to avoid further confusion. Thanks for pointing that out!

Github PR can be found here

merged!