Page MenuHomePhabricator

Getting Gerrit emails for changes I have not interacted with/not subscribed to (due to being starred changes?)
Closed, ResolvedPublic

Description

For the some time now, I am getting streams of Gerrit email for a patch that I have no relation. I was not added as reviewer, I didn't add myself. I didn't interact with the patch.

I'd expect Gerrit to not not send me such emails.

I can't remember the topics of the earlier ones, but the two most recent are

  1. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalWatchlist/+/616976
  2. https://gerrit.wikimedia.org/r/c/jquery-client/+/619134

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2020, 12:50 PM
Ammarpad added a subscriber: hashar.
Ammarpad updated the task description. (Show Details)Aug 12 2020, 1:00 PM
Ammarpad added a comment.EditedAug 12 2020, 1:21 PM

No, it's empty. I am aware about that setting and I know I did not add any project. I am watching none too.

QChris added a subscriber: QChris.Aug 12 2020, 7:31 PM

According to Gerrit's backend storage, the above mentioned changes are both starred by you. So the emails you received are expected.

Not sure though, how they got starred.
Do you recall starring them? (Either through the API or by clicking the star icon (see red arrow on

) on the change pages?
Otherwise, maybe Gerrit had a glitch?
Not sure.

Anyway, the star should show blue for you. Click it again, and it should become white again, and you unstarred a change. Then you should no longer receive emails for that change (unless you are reviewer, cc, ...)

Do you recall starring them? (Either through the API or by clicking the star icon (see red arrow on ) on the change pages?

No. I can clearly recall that the first time I am seeing each patch is after I followed the email link. The stars are indeed blue but I didn't take the action on any of the patches. I knew what the star does, but for the changes I am reporting I am confident I didn't star them. As I said in the task, it happened before these, some few weeks ago, but I decided not report unless it recurs and it did today again, hence this report. I admit there's no way to prove this beyond just saying.

Anyway, the star should show blue for you. Click it again, and it should become white again, and you unstarred a change. Then you should no longer >receive emails for that change (unless you are reviewer, cc, ...)

I have unstarred, though both changes are already merged so unlikely to receive any further activity. I just hope this is a temporary glitch.

Aklapper renamed this task from Getting Gerrit emails for changes I have not interacted with/not subscribed to. to Getting Gerrit emails for changes I have not interacted with/not subscribed to (due to being starred changes?).Aug 13 2020, 9:30 AM
hashar closed this task as Resolved.Aug 13 2020, 12:42 PM
hashar claimed this task.

Starring of changes is save in the All-Users.git repository in the form refs/starred-changes/XX/<change id>/<account id>. When the star is removed, the reference is simply removed and I don't think there is any history of star/unstarring.

You can find the list of changes you have starred at: https://gerrit.wikimedia.org/r/q/owner:self+is:starred

Note: you most probably have starred a change by unintentionally using the s keyboard shortcut on the change page or while browsing a list of changes and having one of them selected. That seems the most likely solution ;)

hashar reassigned this task from hashar to QChris.Aug 13 2020, 12:43 PM

Assign to @QChris since he found out that was due to the change being starred.

I just hope this is a temporary glitch.

Same here :-)