| • apaskulin | |
| Aug 12 2020, 10:35 PM |
| F32086296: Screen Shot 2020-08-07 at 3.54.43 PM.png | |
| Aug 12 2020, 10:35 PM |
| F32086274: Screen Shot 2020-08-07 at 3.54.47 PM.png | |
| Aug 12 2020, 10:35 PM |
Page: All pages except the main page
Expected behavior: To comply with the style guide, the shadow on the border between the header and the body should be being cast onto the header by the body. The style used by the style guide is: box-shadow:rgba(0, 0, 0, 0.25) 0px 1px 4px 0px;
Up-close screenshot of the style guide:
Observed behavior: The shadow is being cast by the header:.
Up-close screenshot of the beta site:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Change direction on header shadow | mediawiki/skins/WikimediaApiPortal | master | +6 -4 |
Change 624983 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/skins/WikimediaApiPortal@master] Change direction on header shadow
Currently, the content on the page scrolls behind the fixed header. If the shadow is being cast by the page onto the header, that would mean that the page is above the header, so the scrolling behavior wouldn't make visual sense. In the style guide, the header is fixed, but it is behind the content, so the page scrolls over the header, obscuring it.
Change 624983 abandoned by Cicalese:
[mediawiki/skins/WikimediaApiPortal@master] Change direction on header shadow
Reason:
Parent task was declined.
Based on Cindy's last comment, we can't change the direction of the header shadow without unfixing the header. Since having a fixed header provides usability value in terms of being able to access navigation and search, we've decided to leave the shadow as-is and decline this task.