Page MenuHomePhabricator
Create Task
Maniphest T260340

Stop using deprecated Language static methods in Wikibase extensions
Closed, ResolvedPublic
Actions

Description

Most of Language’s static methods (::factory, ::fetchLanguageName, etc.) were deprecated in MediaWiki 1.34 or 1.35.
We should stop using them, and migrate to their replacement services (LanguageFactory, LanguageNameUtils, etc.), ideally with proper dependency injection.

I could put a list of affected methods here, but I think the few non-deprecated public static methods that Language still has are probably not used by Wikibase anyways, so it seems simpler to codesearch Language:: and work through that whole list (except Language::class).

This should be done in all of our extensions

  • Wikibase
  • Cognate
  • WikibaseLexeme
  • PropertySuggestor
  • EntitySchema
  • WikibaseQualityConstraints
  • ArticlePlaceholder
  • Wikidata.org
  • WikimediaBadges
  • InterwikiSorting

Acceptance Criteria:

  • Don't use deprecated Language methods (use replacement services with DI)

Details

SubjectRepoBranchLines +/-
Inject language services into MediaWikiLanguageDirectionalityLookupmediawiki/extensions/Wikibasemaster+67 -10
Replace deprecated Language::factorymediawiki/extensions/WikibaseLexememaster+36 -21
Replace deprecated Language::getConvertermediawiki/extensions/Wikibasemaster+3 -3
tests: Replace deprecated Language::factorymediawiki/extensions/WikibaseQualityConstraintsmaster+12 -15
Inject LanguageNameUtils into ViolationMessageRenderer(Factory)mediawiki/extensions/WikibaseQualityConstraintsmaster+53 -40
Inject LanguageNameUtils into MetaContentLanguagesmediawiki/extensions/Wikibasemaster+52 -11
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Aug 13 2020, 10:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2020, 10:01 AM
gerritbot added a comment.Aug 19 2020, 11:27 AM

Change 621010 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Inject LanguageNameUtils into MetaContentLanguages

https://gerrit.wikimedia.org/r/621010

gerritbot added a project: Patch-For-Review.Aug 19 2020, 11:27 AM
gerritbot added a comment.Aug 20 2020, 1:26 PM

Change 621010 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Inject LanguageNameUtils into MetaContentLanguages

https://gerrit.wikimedia.org/r/621010

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 20 2020, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 20 2020, 2:10 PM
WMDE-leszek added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Dec 15 2020, 11:16 AM
WMDE-leszek edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
WMDE-leszek moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
Addshore edited projects, added [DEPRECATED] wdwb-tech (legacy-backlog); removed [DEPRECATED] wdwb-tech.Jan 22 2021, 11:05 PM
Addshore moved this task from Incoming to 3. Hard Slogs (-I +E) on the [DEPRECATED] wdwb-tech (legacy-backlog) board.Jan 22 2021, 11:11 PM
Addshore set Due Date to Jun 30 2021, 11:00 PM.Jan 22 2021, 11:44 PM
Addshore removed Due Date.
Addshore renamed this task from Stop using deprecated Language static methods in Wikibase to Stop using deprecated Language static methods in Wikibase extensions.Feb 23 2021, 1:32 PM
Addshore updated the task description. (Show Details)
Addshore edited projects, added [DEPRECATED] wdwb-tech; removed [DEPRECATED] wdwb-tech (legacy-backlog).Mar 18 2021, 12:34 PM
Addshore moved this task from Inbox to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.
Addshore triaged this task as Low priority.Jul 14 2021, 9:36 AM
Addshore removed a project: Wikidata-Campsite.
Addshore subscribed.

Prioritized very low, so removing from Wikidata-Campsite

Addshore moved this task from Triaged Low (0-50) to Triaged Big on the [DEPRECATED] wdwb-tech board.Jul 16 2021, 8:46 AM
gerritbot added a comment.Dec 5 2022, 5:48 PM

Change 864799 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Inject LanguageNameUtils into ViolationMessageRenderer(Factory)

https://gerrit.wikimedia.org/r/864799

gerritbot added a project: Patch-For-Review.Dec 5 2022, 5:48 PM
gerritbot added a comment.Dec 9 2022, 11:15 AM

Change 864799 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Inject LanguageNameUtils into ViolationMessageRenderer(Factory)

https://gerrit.wikimedia.org/r/864799

Maintenance_bot removed a project: Patch-For-Review.Dec 9 2022, 11:30 AM
Umherirrender updated the task description. (Show Details)Dec 27 2022, 12:45 PM
gerritbot added a comment.Dec 27 2022, 12:59 PM

Change 872445 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseLexeme@master] Replace deprecated Language::factory

https://gerrit.wikimedia.org/r/872445

gerritbot added a project: Patch-For-Review.Dec 27 2022, 12:59 PM
gerritbot added a comment.Dec 27 2022, 1:05 PM

Change 872447 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseQualityConstraints@master] Replace deprecated Language::factory

https://gerrit.wikimedia.org/r/872447

gerritbot added a comment.Dec 27 2022, 1:20 PM

Change 872450 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Replace deprecated Language::getConverter

https://gerrit.wikimedia.org/r/872450

gerritbot added a comment.Dec 28 2022, 12:58 AM

Change 872447 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] tests: Replace deprecated Language::factory

https://gerrit.wikimedia.org/r/872447

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 28 2022, 1:00 AM
gerritbot added a comment.Dec 28 2022, 1:01 AM

Change 872450 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace deprecated Language::getConverter

https://gerrit.wikimedia.org/r/872450

gerritbot added a comment.Dec 28 2022, 1:04 AM

Change 872445 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Replace deprecated Language::factory

https://gerrit.wikimedia.org/r/872445

gerritbot added a comment.Dec 28 2022, 2:05 PM

Change 872989 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Inject language services into MediaWikiLanguageDirectionalityLookup

https://gerrit.wikimedia.org/r/872989

Umherirrender updated the task description. (Show Details)Dec 29 2022, 12:22 PM
Umherirrender updated the task description. (Show Details)Dec 29 2022, 6:15 PM
gerritbot added a comment.Jan 4 2023, 5:09 PM

Change 872989 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Inject language services into MediaWikiLanguageDirectionalityLookup

https://gerrit.wikimedia.org/r/872989

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.18; 2023-01-09); removed MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Jan 4 2023, 6:00 PM
Addshore unsubscribed.Jun 27 2023, 12:43 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 27 2023, 1:12 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Aug 11 2023, 2:19 PM
Lucas_Werkmeister_WMDE claimed this task.

I think the last bits of this actually got done in Replace deprecated Language::factory (T325986), I don’t see any deprecated calls in git grep -F Language:: anymore.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Aug 11 2023, 2:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL