Page MenuHomePhabricator

Review page corruption (dirty diffs) caused by DiscussionTools
Closed, ResolvedPublic

Description

This week and last week we had two bugs that caused some damage to pages (both tracked in T259855). We should check how much damage exactly.

Event Timeline

matmarex created this task.Aug 13 2020, 8:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2020, 8:45 PM

I wrote a script to review the diffs on the wikis where DiscussionTools is available as a beta feature. It checks the recent changes tagged with our tag, downloads every diff, and then outputs a list of diffs that made any changes to the page other than adding content.

I then manually reviewed the results:

  • Only 2 edits were affected by the bug this week
  • About 50-100 edits were affected by the bug last week (there are 126 suspicious diffs and I didn't look at every one, just estimating)

Most of the suspicious diffs are harmless: DiscussionTools apparently sometimes removes spaces at the end of the previous comment. This shouldn't happen, but it's pretty low priority.

Full results:

ppelberg added a subscriber: ppelberg.
ppelberg closed this task as Resolved.Aug 14 2020, 12:33 AM

I wrote a script to review the diffs on the wikis where DiscussionTools is available as a beta feature. It checks the recent changes tagged with our tag, downloads every diff, and then outputs a list of diffs that made any changes to the page other than adding content.

Awesome work, Bartsoz!