Page MenuHomePhabricator
Create Task
Maniphest T260413

Watchlist Expiry: Popup expiry dropdown cut off in Visual Editor
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Samwilson
Authored By
dom_walden
Aug 14 2020, 10:12 AM
Tags
Referenced Files
F32358439: Screen Shot 2020-09-21 at 7.22.45 PM.png
Sep 21 2020, 11:25 PM
F32358441: Screen Shot 2020-09-21 at 7.22.28 PM.png
Sep 21 2020, 11:25 PM
F32357941: ve_toolbar_overlap_vector_legacy.png
Sep 21 2020, 2:19 PM
F32143984: Screen Shot 2020-08-14 at 5.24.09 PM.png
Aug 14 2020, 9:27 PM
F32130613: ve_dropdown.png
Aug 14 2020, 10:12 AM
Subscribers
Aklapper
dmaza
dom_walden
HMonroy
ifried

Description

As a Watchlist Expiry user, I want the pop-up (for watch via star) to be fully displayed when I'm in VisualEditor, so that I can successfully watch a page temporarily.

Background: If you use the watchstar in Visual Editor, the expiry dropdown can get cut off, obscuring some of the options. See screenshot. This occurs on Vector and MonoBook. I cannot use the watchstar in VE when using Timeless.

Acceptance Criteria:

  • Adjust pop-up so that it is fully displayed when user chooses to watch via star and in VE mode

Steps to reproduce problem:

  1. Find a short article on the wiki.
  2. Open the Visual Editor.
  3. Click the watch star
  4. In the popup, open the expiry menu

Expected behavior: You can see all the options in the dropdown.
Observed behavior: Some of the options are cut off.

N.B. Sometimes you are not able to interact with the watch popup in VE. I think this happens when you click the watchstar while VE is still loading (when the loading bar is still there).

Environment:

Screenshot examples:

ve_dropdown.png (329×591 px, 20 KB)

Screen Shot 2020-08-14 at 5.24.09 PM.png (424×1 px, 78 KB)

Details

SubjectRepoBranchLines +/-
Move notification area to end of bodymediawiki/coremaster+9 -4
Move notification overlay outside $contentmediawiki/coremaster+20 -5
Move notification overlay outside $contentmediawiki/coremaster+17 -4
Customize query in gerrit

Related Objects

Event Timeline

dom_walden created this task.Aug 14 2020, 10:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 14 2020, 10:12 AM
dom_walden updated the task description. (Show Details)Aug 14 2020, 12:37 PM
ifried moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Aug 14 2020, 2:38 PM
ifried updated the task description. (Show Details)Aug 14 2020, 9:27 PM
gerritbot added a comment.Aug 18 2020, 6:19 AM

Change 620145 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Move notification overlay outside mw-body

https://gerrit.wikimedia.org/r/620145

gerritbot added a project: Patch-For-Review.Aug 18 2020, 6:19 AM
Samwilson claimed this task.Aug 18 2020, 7:30 AM
Samwilson edited projects, added Community-Tech (Kanban-2020-21-Q1); removed Community-Tech.
Samwilson moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q1) board.
Samwilson mentioned this in T260262: Watchlist Expiry: popup is blocked by other elements in Monobook.Aug 18 2020, 7:59 AM
dmaza subscribed.EditedAug 18 2020, 8:27 PM
In T260413#6391947, @gerritbot wrote:

Change 620145 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Move notification overlay outside mw-body

https://gerrit.wikimedia.org/r/620145

If I'm not mistaken, moving the notification overlay outside of mw-body could potentially fix T260432: Watchlist Expiry: Watchstar popup not always usable on VisualEditor

HMonroy subscribed.Aug 20 2020, 1:39 AM
In T260413#6394591, @dmaza wrote:
In T260413#6391947, @gerritbot wrote:

Change 620145 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Move notification overlay outside mw-body

https://gerrit.wikimedia.org/r/620145

If I'm not mistaken, moving the notification overlay outside of mw-body could potentially fix T260432: Watchlist Expiry: Watchstar popup not always usable on VisualEditor

It might fix T260262: Watchlist Expiry: popup is blocked by other elements in Monobook as well.

Samwilson moved this task from Review/Feedback 💬 to In Development 💻 on the Community-Tech (Kanban-2020-21-Q1) board.Aug 20 2020, 2:07 AM
Samwilson moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q1) board.Aug 21 2020, 12:37 AM
Samwilson moved this task from Review/Feedback 💬 to In Development 💻 on the Community-Tech (Kanban-2020-21-Q1) board.Aug 25 2020, 2:24 AM
Samwilson moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q1) board.Sep 7 2020, 3:07 AM
gerritbot added a comment.Sep 10 2020, 6:33 PM

Change 620145 merged by jenkins-bot:
[mediawiki/core@master] Move notification overlay outside $content

https://gerrit.wikimedia.org/r/620145

Maintenance_bot removed a project: Patch-For-Review.Sep 10 2020, 7:11 PM
ARamirez_WMF moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q1) board.Sep 10 2020, 10:06 PM
gerritbot added a comment.Sep 11 2020, 10:32 PM

Change 626783 had a related patch set uploaded (by HMonroy; owner: HMonroy):
[mediawiki/core@master] Move notification overlay outside $content

https://gerrit.wikimedia.org/r/626783

gerritbot added a project: Patch-For-Review.Sep 11 2020, 10:32 PM
gerritbot added a comment.Sep 14 2020, 1:24 AM

Change 626918 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Move notification area to end of body

https://gerrit.wikimedia.org/r/626918

Samwilson moved this task from QA 🐛 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q1) board.Sep 14 2020, 8:21 AM
gerritbot added a comment.Sep 14 2020, 6:43 PM

Change 626783 abandoned by HMonroy:
[mediawiki/core@master] Move notification overlay outside $content

Reason:
A new solution has been developed in patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/ /626918

https://gerrit.wikimedia.org/r/626783

gerritbot added a comment.Sep 16 2020, 4:13 AM

Change 626918 merged by jenkins-bot:
[mediawiki/core@master] Move notification area to end of body

https://gerrit.wikimedia.org/r/626918

Samwilson moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q1) board.Sep 16 2020, 6:08 AM
dom_walden moved this task from QA 🐛 to Product sign-off 🤘🏻 on the Community-Tech (Kanban-2020-21-Q1) board.Sep 21 2020, 2:19 PM

I cannot reproduce this anymore.

To maximise the chance of spotting an issue I tried to make the watch popup as large as possible relative to the VE interface. I chose a short article with a long title (so the watch popup is taller) and tested with the browser zoomed to about 150-170%.

I could not see any issues on Firefox and Safari on MonoBook, Vector new and Legacy, Minerva, Modern and Timeless.

In some skins the popup overlaps the VE toolbar to some extent, which might interfere with users, e.g.:

ve_toolbar_overlap_vector_legacy.png (1×1 px, 180 KB)

This occurs on Vector legacy (and new if the screen is small enough), Modern, MonoBook.

For some of the other testing I did around this change, see T260432.

Test Environment: Various different versions of https://en.wikipedia.beta.wmflabs.org.

ifried closed this task as Resolved.Sep 21 2020, 11:25 PM
ifried moved this task from Product sign-off 🤘🏻 to Done 🏁 on the Community-Tech (Kanban-2020-21-Q1) board.
ifried subscribed.

I have tested this on https://en.wikipedia.beta.wmflabs.org, and the pop-up is no longer blocked while editing a short page in VE (screenshot examples provided below). I'm marking this work as Done.

Screen Shot 2020-09-21 at 7.22.45 PM.png (379×918 px, 81 KB)

Screen Shot 2020-09-21 at 7.22.28 PM.png (377×881 px, 68 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL