Page MenuHomePhabricator

Mentioning an email address in DiscussionTools makes the system think I'm going to mention someone
Open, Needs TriagePublic

Description

Hello,

I just noticed that when I'm writing an email address in DiscussionTools, the system starts to show me a list of users, just like when I'm going to mention someone.

I think the regex/whatever is responsible for catching the at sign should require a word boundary, so it doesn't do its job when the at sign is in a middle of the word.

Thanks for your awesome work,

Martin Urbanec

Event Timeline

Urbanecm created this task.Aug 14 2020, 3:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 14 2020, 3:57 PM

We have discussed this in T255153 – originally the autocompletion was only done after word boundaries, but we realized that this would make it useless in languages there there aren't word boundaries, like Chinese.

ppelberg added a subscriber: ppelberg.EditedAug 14 2020, 10:44 PM

@Urbanecm for context: were you able to successfully include the email address you were intending to in the comment you were writing?

@Urbanecm for context: were you able to successfully include the email address you were intending to in the comment you were writing?

Yes, but the username selector surprised me quite a bit. Maybe make that configurable by a config flag?

You can also cancel the suggestions dropdown by pressing Escape (it was a bit buggy and would reappear, but T259277 fixes that).

DLynch added a subscriber: DLynch.Aug 31 2020, 3:29 PM

Making it configurable would be technically doable, as it's just a lightly modified reversion of the original removal.

There'd be an argument about whether to make it a user config or a wiki-level config. It'd also add to the general matrix of behaviors to test, which can be inconvenient.

I'd say this would be higher priority if we ever gave in to one of the "automatically link usernames" tickets, since as-is you can just not-interact with the popup and you'll get your desired output.