Having `BatchRowIterator::next` as the fname of the caller to $db->select() is not helpful
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	Reedy
	Aug 15 2020, 10:50 AM

Description

As seen on T260232, having BatchRowIterator::next passed as the fname caller is not helpful for debugging purposes.

We obviously cannot pass it in on the iteractor next call... But could we do something in the constructor, or have a setCaller type function to set the caller at point of query execution, so we have some idea where the caller is coming from, rather than having to work out from the sql query being generated?

Related Objects

Mentioned In: T261014: Make use of (BatchRowIterator|BatchRowWriter)::setCaller
Mentioned Here: T260232: BatchRowIterator slow query on commonswiki

Event Timeline

Reedy created this task.Aug 15 2020, 10:50 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 15 2020, 10:50 AM

Reedy updated the task description. (Show Details)Aug 15 2020, 11:01 AM

Reedy updated the task description. (Show Details)Aug 15 2020, 11:13 AM

Reedy closed this task as a duplicate of T260354: Allow to set a caller on BatchRowIterator and BatchRowWriter.Aug 15 2020, 12:06 PM

Reedy mentioned this in T261014: Make use of (BatchRowIterator|BatchRowWriter)::setCaller.Aug 21 2020, 7:59 PM

Having `BatchRowIterator::next` as the fname of the caller to $db->select() is not helpfulClosed, DuplicatePublicActions

Description

Related Objects

Event Timeline

Having `BatchRowIterator::next` as the fname of the caller to $db->select() is not helpful
Closed, DuplicatePublic
Actions