Page MenuHomePhabricator

Check if specified transcode set contains known/valid keys
Closed, ResolvedPublic

Description

When consumers configure incorrect keys in wgEnabledTranscodeSet or wgEnabledAudioTranscodeSet, the only feedback given to the consumer is:

Notice: Undefined index: oga in /var/www/OUR WEBSITE/www/w/extensions/TimedMediaHandler/includes/WebVideoTranscode/WebVideoTranscode.php on line 1070

Basically a error when attempting to build the sources list. We should simply validate the variable keys to the list of known profiles in WebVideoTranscode and create a more specific error.

Event Timeline

Change 621579 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/TimedMediaHandler@master] Validate the configuration for transcoding

https://gerrit.wikimedia.org/r/621579

TheDJ triaged this task as Lowest priority.Aug 20 2020, 7:44 PM

Change 621579 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Validate the configuration for transcoding

https://gerrit.wikimedia.org/r/621579

TheDJ claimed this task.