Page MenuHomePhabricator

Extension:MobileFrontend/MobileMenu seems to be out of date
Closed, ResolvedPublic

Description

https://www.mediawiki.org/wiki/Extension:MobileFrontend/MobileMenu has many broken links and seems to be generally out of date

https://doc.wikimedia.org/mediawiki-core/master/php/MobileMenuHook_8php.html
https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/includes/menu/Group.php

\MobileFrontend\MenuBuilder used in the example doesn't seem to exist anymore..

And the hook isn't in MobileFrontened anymore, it's in MinervaNeue, passing a Group (MediaWiki\Minerva\Menu\Group)

Hooks::run( 'MobileMenu', [ 'pageactions.overflow', &$group ] );

Event Timeline

It looks like there is lots of old/outdated documentation as most of the stuff was migrated to MinervaNeue and MobileFrontend is currently not involved in building Menu for minerva.
https://doc.wikimedia.org/mediawiki-core/master/php/MobileMenuHook_8php.html -> is missing as we do not have interface for that MobileMenu, it's part of Minerva, not core.

Definitely that documentation needs improvement.

ovasileva triaged this task as Medium priority.Aug 26 2020, 6:02 PM
ovasileva moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.
Jdlrobson claimed this task.

Updated the docs today.