Page MenuHomePhabricator
Create Task
Maniphest T260579

Swiping left on Places Explore Feed Card when location is disabled causes odd visual expierence
Closed, ResolvedPublic
Actions

Description

From OTRS - https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=11474459

Tested on 6.6.2 (1745)

Steps:

  1. Without location enabled, navigate to the Places Feed Card
  2. Swipe left to reveal the save/share buttons

Expected:
Not sure

Actual:
The enable location button obscures the save/share buttons

Frequency = 5/5

IMG_2B2A22C61917-1.jpeg (2×1 px, 667 KB)

image0.png (1×621 px, 955 KB)

Event Timeline

ABorbaWMF created this task.Aug 17 2020, 5:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2020, 5:17 PM
LGoto triaged this task as Low priority.Aug 17 2020, 6:37 PM
LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
JoeWalsh subscribed.Aug 17 2020, 6:38 PM

Would either need to update the layout code for the button and lower label or disable swipe actions on this cell

• MattCleinman subscribed.Nov 18 2020, 9:39 PM

I believe we want to disable the swipe action cells - we only show them on the top read card items (as well as this one).

• MattCleinman added a comment.Nov 18 2020, 9:40 PM

Additionally, a trailing-to-leading swipe on a Random Article or Article of the Day card causes the text to disappear. This is possibly related, and could be fixed with this.

James_Dempsey added a project: iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower.Nov 24 2020, 5:49 PM
James_Dempsey moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower board.
• MattCleinman moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower board.Dec 2 2020, 8:44 PM
Tsevener moved this task from Waiting for Build to Needs QA on the iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower board.Jan 5 2021, 11:00 PM
ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower board.Jan 6 2021, 6:53 PM

Looks good on 6.8.0 (1790)

The swipe action appears to be disabled when location is disabled. The swipe action is enabled when location is enabled.

• JMinor closed this task as Resolved.Apr 26 2021, 11:22 PM
• JMinor claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL