Given the problems we've been having, it might make sense to update mediawiki.page.ready so that collapsible and sortable elements are enabled on the special page namespace e.g. the configuration only applies to other namespaces. That might make the config name confusing however.

https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.page.ready/ready.js#L23

cc @Krinkle

Patching all these special pages to explicitly call the relevant method, while tedious is probably the best solution here.

I am not sure what method you're referring here.

Sorry. I'll be clearer. The special pages should call makeCollapsible(); or tablesorter(); themselves as well as listing the dependencies via addModules/addModuleStyles rather than depend on mediawiki.page.ready

In the case of https://m.mediawiki.org/wiki/Special:AbuseLog this code would be added to the module mediawiki.htmlform :

if ( mw.loader.getState(''jquery.makeCollapsible') === 'registered' && $('.mw-collapsible').length ) {
  mw.loader.using(['jquery.makeCollapsible']).then(() => {
    $('.mw-collapsible').makeCollapsible(); } )
  });
}

(applying makeCollapsible twice has no effect so no need to worry about that)

Thanks, but I am not sure about the suggested approach.

In T260642#6393427, @Jdlrobson wrote:

Given the problems we've been having, it might make sense to update mediawiki.page.ready so that collapsible and sortable elements are enabled on the special page namespace e.g. the configuration only applies to other namespaces.

In my view updating in one place would be better than doing so in each special page. These pages were working normally before this change.

That might make the config name confusing however.

I am not sure whether apart from confusing name there's any other reason. Confusable name can be changed to reflect expanded scope.

In my view updating in one place would be better than doing so in each special page.

I think it's better to have explicit dependencies if possible as it provides self-explanatory documentation. If a special page knows it needs a form to be made collapsible it needs to do that itself. Doing this inside the module mediawiki.htmlform looks like a good place to do this as it means one place for each special page (assuming they are using HtmlForm which they should be) and makes it clear that these forms should be treated different from user generated content. That then means mediawiki.page.ready is used exclusively for content.

This lack of knowledge of which pages have collapsible forms that rely on mediawiki.page.ready makes me a little uncomfortable. If we ever want to move away from this code to another library in current form we would need to search for the collapsible class across the codebase. However, if the module is used with the makecollapsible call then things are explicitly clear.

@Jdlrobson The patch from Fomafix effectively does this by making makeCollapsed self-contained including its activation logic. See https://gerrit.wikimedia.org/r/c/mediawiki/core/+/503101. This would allow special pages to queue that module as you say, to make them responsible and aware of their dependency, but also still have the benefit of not needing additional modules or payloads just to call one function, keeping the interface declarative instead, which seems preferred.

Change 503101 had a related patch set uploaded (by Jdlrobson; owner: Fomafix):
[mediawiki/core@master] Move activating of makeCollapsible out of 'mediawiki.page.ready'

https://gerrit.wikimedia.org/r/503101

Change 503101 merged by jenkins-bot:
[mediawiki/core@master] Move activating of makeCollapsible out of 'mediawiki.page.ready'

https://gerrit.wikimedia.org/r/503101

Change 627543 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Collapsible HTMLForms need to add JS module

https://gerrit.wikimedia.org/r/627543

Change 627543 merged by jenkins-bot:
[mediawiki/core@master] Collapsible HTMLForms need to add JS module

https://gerrit.wikimedia.org/r/627543

@Jdlrobson in the second step, the form briefly flashes the expanded state then collapses. Is this as expected?

I think this is fine. Likely an existing problem.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1. Visit the desktop site https://en.wikipedia.org/wiki/Special:AbuseLog

• Observe the form starts in a collapsed state.
• Click on the form header 'search the abuse log'
• Observe the form expanded.

✅ AC2. Now visit the mobile site https://en.m.wikipedia.org/wiki/Special:AbuseLog

• Observe the form starts in expanded state (the code says otherwise should happen also see T260642#6484520)
• Now click on the form header
• Form should collapse

❓ AC3. Visit another mobile site https://en.m.wikipedia.org/wiki/Special:Contributions/Abuse_filter

• Observe the form starts in a collapsed state.
• Click on the form header
• Form should expand and collapse when clicked.

@Jdlrobson is there another page that has the form. I get the following:

For AC3 please make sure AMC is enabled and use https://en.m.wikipedia.org/wiki/Special:Contributions/Jdlrobson

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC3. Visit another mobile site https://en.m.wikipedia.org/wiki/Special:Contributions/Abuse_filter

• Observe the form starts in a collapsed state.
• Click on the form header
• Form should expand and collapse when clicked.

@Jdlrobson is there another page that has the form. I get the following:

Change 633759 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Revert "Move activating of makeCollapsible out of 'mediawiki.page.ready'"

https://gerrit.wikimedia.org/r/633759

Change 633826 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] mediawiki.htmlform: Ensure collapsible forms are enabled

https://gerrit.wikimedia.org/r/633826

Change 633759 merged by jenkins-bot:
[mediawiki/core@master] Revert "Move activating of makeCollapsible out of 'mediawiki.page.ready'"

https://gerrit.wikimedia.org/r/633759

Change 633826 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.htmlform: Ensure collapsible forms are enabled

https://gerrit.wikimedia.org/r/633826

@matmarex Can you confirm whether it is just the ordering of activation that's the issue, or whether there's more? It seems to me like such fragile contract should is a bug and is worth fixing by itself, e.g. by actually adding the missing supporting for more table structures in makeCollapsible, or by embracing this kind of reliance as a first-class primitive in mw.hook and creating some form of priority/ordering concept, e.g. mw.hook( 'wikipage.ready-after' ) or some such.

I'm asking because there's numerous other developments in the skin on-going that have been planned specifically around this code no longer being part of mediawiki.page.ready, which I can't tell right now whether that needs to be reimagined in a different way or whether this is just temporary while we fix the root cause.

What do you mean by "there's more"? There is certainly some root problem in jquery.makeCollapsible or jquery.tablesorter, which could presumably be debugged and resolved, but I did not have time to debug this further, and just making them run in this order seemed reliable enough (see T64878).

I don't know anything about planned developments, but you might want to debug this then if it's blocking some other work.