Page MenuHomePhabricator
Create Task
Maniphest T260702

Analyze custom varnish 5.1 patches considering the migration to varnish 6
Closed, ResolvedPublic
Actions

Description

Under debian/patches we currently have 36 patches on top of varnish 5.1.3. We need to know how many needs to be ported to varnish 6 and how many are already shipped with varnish 6 and therefore can be discarded.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Vgutierrez created this task.Aug 18 2020, 3:38 PM
Restricted Application added a project: SRE. · View Herald TranscriptAug 18 2020, 3:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Vgutierrez triaged this task as Medium priority.Aug 18 2020, 3:38 PM
Vgutierrez moved this task from Backlog to Caching on the Traffic board.
gerritbot added a comment.Aug 18 2020, 3:48 PM

Change 621014 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/debs/varnish4@debian-wmf] Add Origin and Description headers for every debian patch

https://gerrit.wikimedia.org/r/621014

gerritbot added a project: Patch-For-Review.Aug 18 2020, 3:48 PM

Change 621015 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/debs/varnish4@debian-wmf] Remove unused patches

https://gerrit.wikimedia.org/r/621015

Vgutierrez added a comment.EditedAug 18 2020, 4:20 PM
patchbackport/customavailable on varnish 6.0available on varnish 6.4can be removed?
0002-exp-thread-realtime.patchcustomnonoTBD (varnish-be specific)
0003-vsm-perms.patchcustomnonono
0004-storage-file-off-t.patchcustomnonoTBD (varnish-be specific)
0005-stats-shortlived.patchcustomnonono
0006-transaction-timeout.patchcustomnonoyes (adds a config parameter that is currently unused)
0007-varnishncsa-record-prefix.patchbackportyesyesyes
0008-vsv00002-5.1.patchbackportyesyesyes
0011-fix-discarding-labelsbackportyesyesyes
0012-oh-leak.patchbackportyesyesyes
0013-issue-1799.patchbackportyesyesyes
0014-n_lru_limited-counter.patchbackportyesyesyes
0015-cache_hit_grace-counter.patchbackportyesyesyes
0016-expired-objects-ignore-req.ttl.patchbackportyesyesyes
0017-new-ttl-in-vcl-calculation.patchbackportyesyesyes
0018-post-and-multiple-vcl.patchbackportyesyesyes
0019-vary-stevedore-mem-leak.patchbackportyesyesyes
0020-assert-error-http1_minimal_response.patchbackportyesyesyes
0021-dont-test-gunzip-partial.patchbackportyesyesyes
0022-deref-objcore-synth-err.patchbackportyesyesyes
0023-pass-delivery-is-no-err.patchbackportyesyesyes
0024-vbt-get-force-fresh.patchbackportyesyesyes
0025-extrachance-one-retry.patchbackportyesyesyes
0026-transient-full-cache_req_body-panic.patchbackportyesyesyes
0027-assert-error-vca_make_session.patchbackportyesyesyes
0028-panic-return-cond-fetch.patchbackportyesyesyes
0029-ban-lurker-bo-backoff.patchbackportyesyesyes
0030-startup-show-version.patchbackportyesyesyes
0031-vbt-close-stolen.patchbackportyesyesyes
0032-vbe_dir_finish-no-VBT_Wait.patchbackportyesyesyes
0033-recycled-honor-first_byte_timeout.patchbackportyesyesyes
0034-r02135.vtc-fixes.patchbackportyesyesyes
0035-vbf_stp_condfetch_crash.patchbackportyesnoyes iff target version is 6.0
0036-VSV00004.patchbackportyesyesyes
0037-force-discard.patchcustomnonoyes (failed experiment)
0038-vcl_active-lock.patchbackportyesyesyes
gerritbot added a comment.Aug 19 2020, 1:37 PM

Change 621265 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/debs/varnish4@debian-wmf] Remove unnecessary patches for Varnish 6

https://gerrit.wikimedia.org/r/621265

gerritbot added a comment.Aug 19 2020, 2:49 PM

Change 621284 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/debs/varnish4@debian-wmf] Update 0003-vsm-perms.patch

https://gerrit.wikimedia.org/r/621284

gerritbot added a comment.Aug 20 2020, 2:47 PM

Change 621532 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/debs/varnish4@debian-wmf] Update 0005-stats-shortlived.patch

https://gerrit.wikimedia.org/r/621532

gerritbot added a comment.Aug 20 2020, 2:47 PM

Change 621533 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/debs/varnish4@debian-wmf] Update 0006-transaction-timeout.patch

https://gerrit.wikimedia.org/r/621533

gerritbot added a comment.Aug 20 2020, 2:47 PM

Change 621534 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/debs/varnish4@debian-wmf] Refresh 0037-force-discard.patch

https://gerrit.wikimedia.org/r/621534

gerritbot added a comment.Aug 21 2020, 9:53 AM

Change 621693 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/debs/varnish4@debian-wmf] Update debian/control

https://gerrit.wikimedia.org/r/621693

gerritbot added a comment.Aug 21 2020, 9:53 AM

Change 621694 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/debs/varnish4@debian-wmf] Release 6.0.6-1wm1

https://gerrit.wikimedia.org/r/621694

gerritbot added a comment.Aug 24 2020, 8:07 AM

Change 621533 abandoned by Vgutierrez:
[operations/debs/varnish4@debian-wmf] Update 0006-transaction-timeout.patch

Reason:
patch no longer needed

https://gerrit.wikimedia.org/r/621533

gerritbot added a comment.Aug 24 2020, 8:07 AM

Change 621534 abandoned by Vgutierrez:
[operations/debs/varnish4@debian-wmf] Refresh 0037-force-discard.patch

Reason:
patch no longer needed

https://gerrit.wikimedia.org/r/621534

gerritbot added a comment.Aug 28 2020, 8:31 AM

Change 622964 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/debs/varnish4@debian-wmf] Add 0006-bump-api-soname

https://gerrit.wikimedia.org/r/622964

gerritbot added a comment.Aug 28 2020, 8:31 AM

Change 622965 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/debs/varnish4@debian-wmf] Bump libvarnishapi SONAME

https://gerrit.wikimedia.org/r/622965

• ema added a subtask: T261487: Varnish 6.0 needs a SONAME version bump.Aug 28 2020, 8:34 AM
gerritbot added a comment.Aug 28 2020, 8:55 AM

Change 622967 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/debs/varnish4@debian-wmf] Package vcstool.py

https://gerrit.wikimedia.org/r/622967

gerritbot added a comment.Aug 28 2020, 10:04 AM

Change 622975 had a related patch set uploaded (by Ema; owner: Ema):
[operations/debs/varnish4@debian-wmf] Work around a breaking change in GNU make 4.3

https://gerrit.wikimedia.org/r/622975

• ema mentioned this in T261632: Package varnish 6.0.x.Aug 31 2020, 11:47 AM
• ema added a parent task: T261632: Package varnish 6.0.x.
gerritbot added a comment.Sep 1 2020, 7:55 AM

Change 623524 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/debs/varnish4@debian-wmf] Drop 0003-vsm-perms.patch

https://gerrit.wikimedia.org/r/623524

gerritbot added a comment.Sep 22 2020, 7:47 AM

Change 621014 merged by Ema:
[operations/debs/varnish4@debian-wmf] Add Origin and Description headers for every debian patch

https://gerrit.wikimedia.org/r/621014

gerritbot added a comment.Sep 22 2020, 7:47 AM

Change 621015 merged by Ema:
[operations/debs/varnish4@debian-wmf] Remove unused patches

https://gerrit.wikimedia.org/r/621015

gerritbot added a comment.Sep 22 2020, 7:48 AM

Change 621265 merged by Ema:
[operations/debs/varnish4@debian-wmf] Remove unnecessary patches for Varnish 6

https://gerrit.wikimedia.org/r/621265

gerritbot added a comment.Sep 22 2020, 7:48 AM

Change 621284 merged by Ema:
[operations/debs/varnish4@debian-wmf] Update 0003-vsm-perms.patch

https://gerrit.wikimedia.org/r/621284

gerritbot added a comment.Sep 22 2020, 7:49 AM

Change 621532 merged by Ema:
[operations/debs/varnish4@debian-wmf] Update 0005-stats-shortlived.patch

https://gerrit.wikimedia.org/r/621532

gerritbot added a comment.Sep 22 2020, 7:50 AM

Change 621693 merged by Ema:
[operations/debs/varnish4@debian-wmf] Update debian/control

https://gerrit.wikimedia.org/r/621693

gerritbot added a comment.Sep 22 2020, 7:51 AM

Change 622967 merged by Ema:
[operations/debs/varnish4@debian-wmf] Package vcstool.py

https://gerrit.wikimedia.org/r/622967

gerritbot added a comment.Sep 22 2020, 7:51 AM

Change 622975 merged by Ema:
[operations/debs/varnish4@debian-wmf] Work around a breaking change in GNU make 4.3

https://gerrit.wikimedia.org/r/622975

gerritbot added a comment.Sep 22 2020, 7:55 AM

Change 623524 merged by Ema:
[operations/debs/varnish4@debian-wmf] Drop 0003-vsm-perms.patch

https://gerrit.wikimedia.org/r/623524

gerritbot added a comment.Sep 22 2020, 7:55 AM

Change 621694 merged by Ema:
[operations/debs/varnish4@debian-wmf] Release 6.0.6-1wm1

https://gerrit.wikimedia.org/r/621694

• ema closed this task as Resolved.Sep 22 2020, 7:58 AM

Most patches dropped! We're left with:

  • 0005-stats-shortlived.patch
  • 0006-bump-api-soname.patch

Closing.

• ema closed subtask T261487: Varnish 6.0 needs a SONAME version bump as Resolved.Sep 22 2020, 3:26 PM
• ema mentioned this in T263557: Upgrade production cache nodes to Varnish 6.Sep 22 2020, 3:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL