Page MenuHomePhabricator

Add translations for failed recurring email for 7 additional languages
Closed, ResolvedPublic2 Estimated Story Points

Description

In the last task, T255837, I only added the three highest priority languages. There are 7 more: Dutch, Italian, Norwegian, Polish, Portugese, Romanian, Spanish that still need translations. From @Cdenes: The copy for 10 languages is ready. Please find the translations at https://docs.google.com/document/d/1rf63tFSXsxcALNsHZZ0Mourra7KY4Y-ZUZj2TS2v0ho/edit?ts=5efb7315#.

Event Timeline

There is now a function to do this with, once the patch is merged. This is relatively 'easy' to do, just tedious and the time consumed is just translating the doc text to html. wmf_civicrm_update_8081 in wmf_civicrm.install will show how to do it.

I just want to note 3 gotchas from the previous update

  1. if you copy & paste from the doc @cdenes put together there are some weird characters in some of the address lines that you can't easily see - I would up retyping them
  2. I'm not sure if the reference that we add to help DS is consistently present in the copy
  3. look for this line $supportedLanguages = ['ja_JP', 'fr_FR', 'sv_SE'];

in drupal/sites/default/civicrm/extensions/org.wikimedia.smashpig/Civi/Api4/Action/FailureEmail/Render.php
& edit it. Note we should think about derivative languages & fall back (e.g ca_FR is not falling back to FR at this stage - I think that probably warrants a new phab)

DStrine set the point value for this task to 2.Sep 29 2020, 8:26 PM

Change 632365 had a related patch set uploaded (by Cstone; owner: Cstone):
[wikimedia/fundraising/crm@master] WIP: Add more translations for failed recurring messages.

https://gerrit.wikimedia.org/r/632365

Change 634139 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm@master] Update failure notification form to support testing & approval of qa messages

https://gerrit.wikimedia.org/r/634139

I'm not comfortable reviewing this patch due to the copy being in different languages so I have set it up (with a few patches) so I can generate tests on staging. Bonus - it permits us to deploy the updates & someone else (or us) can qa & enable individually if we want - I will forward emails on to @Cstone & @CDenes_WMF unless someone else wants to qa them

Using civicrm/contact/view?reset=1&cid=18083834 (who has been renamed for testing & now has my email in case of accidents) on staging

Screen Shot 2020-10-15 at 3.54.00 PM.png (926×1 px, 132 KB)

Requires a path configured at civicrm/admin/setting/cividatatranslate to work

Screen Shot 2020-10-15 at 4.24.41 PM.png (520×1 px, 48 KB)

Change 634141 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm@master] Fix funny characters in the PO box number

https://gerrit.wikimedia.org/r/634141

Change 634142 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm@master] Add WMF address to Swedish recurring fail

https://gerrit.wikimedia.org/r/634142

Change 634141 abandoned by Eileen:
[wikimedia/fundraising/crm@master] Fix funny characters in the PO box number

Reason:

https://gerrit.wikimedia.org/r/634141

Change 632365 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Add nl,it,nb,pl,pt,ro,es translations for failed recurring messages.

https://gerrit.wikimedia.org/r/632365

@Cstone this is now in 'done' - but did they get enabled on live? I did some patches to give us more control enabling - (ending in https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/634139 ) but those aren't merged - unless you did an install that I'm missing

Change 634139 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Update failure notification form to support testing & approval of qa messages

https://gerrit.wikimedia.org/r/634139

@MBeat33 @krobinson we have deployed this from a technical point of view - but we added another non-technical step where you can do a final QA & approval before they are live. If you got to my record (11863262 ) and try to send me a failure message you will see the screen looks a bit different - this is specifically because I'm set to Spanish - which is a language with an unapproved version available (& no approved version). The languages in this state are

Dutch, Italian, Norwegian, Polish, Portugese, Romanian, Spanish

Screen Shot 2020-10-22 at 4.51.43 PM.png (1×1 px, 173 KB)

Change 634142 merged by Eileen:
[wikimedia/fundraising/crm@master] Add WMF address to Swedish recurring fail

https://gerrit.wikimedia.org/r/634142

Thank you @Eileenmcnaughton We'll review the 7 remaining translations as we use them, pressing the Approve button if the copy looks good, and initiating any needed translations in Phab, and looping Camille in we see any.

@MBeat33 cool - let's close this then & you can open new phabs for any updates required.