Page MenuHomePhabricator
Create Task
Maniphest T260725

Delete Globalcollect adapter, fold still-used code into Ingenico adapter
Closed, ResolvedPublic
Actions

Description

Clean up all the cruft!

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Ejegg created this task.Aug 18 2020, 7:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2020, 7:58 PM
• DStrine moved this task from Triage to Q4 FY21-22 on the Fundraising-Backlog board.Aug 18 2020, 8:06 PM
Ejegg added a project: Technical-Debt.Sep 21 2021, 12:20 AM
Ejegg mentioned this in T297453: Use normalized SmashPig response properties for Ingenico on payments.Dec 10 2021, 4:19 AM
Jgreen renamed this task from Delete Globalcollect adapater, fold still-used code into Ingenico adapter to Delete Globalcollect adapter, fold still-used code into Ingenico adapter.Jul 13 2022, 7:22 PM
Ejegg merged a task: T291798: DonationInterface: Remove old GlobalCollect classes, config and directory, integrating currently used functionality into Ingenico gateway.Jan 23 2023, 4:27 PM
Ejegg added a subscriber: AndyRussG.
Ejegg mentioned this in T326600: globalcollect: Displaying fail page for exception: The payment method [cc] was not found..Jan 23 2023, 8:47 PM
Ejegg added a parent task: T291786: SmashPig: Remove unused code from old integrations.Jan 30 2023, 8:16 PM
XenoRyet moved this task from Q4 FY21-22 to Unscheduled on the Fundraising-Backlog board.Mar 13 2023, 9:46 PM
XenoRyet moved this task from Unscheduled to Current Sprint on the Fundraising-Backlog board.Apr 11 2023, 8:17 PM
XenoRyet added a project: Fundraising Sprint Highway to Hello World.Apr 11 2023, 8:25 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Highway to Hello World board.Apr 12 2023, 1:13 AM
gerritbot added a comment.Apr 12 2023, 1:57 AM

Change 908010 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] WIP createPaymentSession for Ingenico HostedCheckoutProvider

https://gerrit.wikimedia.org/r/908010

gerritbot added a project: Patch-For-Review.Apr 12 2023, 1:57 AM
gerritbot added a comment.Apr 13 2023, 11:49 PM

Change 908670 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] WIP decouple Ingenico from Globalcollect

https://gerrit.wikimedia.org/r/908670

AnnWF closed this task as a duplicate of T334773: globalcollect_gateway: should be replace to ingenico, needs replace the campaign link.Apr 17 2023, 8:10 PM
Ejegg reopened this task as Open.Apr 17 2023, 9:07 PM
AnnWF added a subtask: T334773: globalcollect_gateway: should be replace to ingenico, needs replace the campaign link.Apr 17 2023, 9:13 PM
gerritbot added a comment.Apr 18 2023, 3:08 AM

Change 909427 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Add new properties to PaymentDetailResponse

https://gerrit.wikimedia.org/r/909427

gerritbot added a comment.Apr 18 2023, 3:08 AM

Change 909428 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Deprecate old getHostedPaymentStatus call

https://gerrit.wikimedia.org/r/909428

gerritbot added a comment.Apr 18 2023, 3:08 AM

Change 909429 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Map amount, currency, submethod in Ingenico status lookup

https://gerrit.wikimedia.org/r/909429

gerritbot added a comment.Apr 18 2023, 3:08 AM

Change 909430 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Split out card-specific property mapping

https://gerrit.wikimedia.org/r/909430

gerritbot added a comment.Apr 19 2023, 2:38 AM

Change 909799 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Catch exceptions in createPaymentSession

https://gerrit.wikimedia.org/r/909799

gerritbot added a comment.Apr 19 2023, 10:49 AM

Change 908010 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] createPaymentSession for Ingenico HostedCheckoutProvider

https://gerrit.wikimedia.org/r/908010

gerritbot added a comment.Apr 19 2023, 10:49 AM

Change 909427 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Add new properties to PaymentDetailResponse

https://gerrit.wikimedia.org/r/909427

gerritbot added a comment.Apr 19 2023, 10:52 AM

Change 909428 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Deprecate old getHostedPaymentStatus call

https://gerrit.wikimedia.org/r/909428

gerritbot added a comment.Apr 19 2023, 2:28 PM

Change 909429 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Map amount, currency, submethod in Ingenico status lookup

https://gerrit.wikimedia.org/r/909429

gerritbot added a comment.Apr 20 2023, 12:28 AM

Change 910106 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Handle ApiException in getLatestPaymentStatus

https://gerrit.wikimedia.org/r/910106

gerritbot added a comment.Apr 25 2023, 1:36 PM

Change 909430 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Split out card-specific property mapping

https://gerrit.wikimedia.org/r/909430

gerritbot added a comment.Apr 25 2023, 5:26 PM

Change 911910 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Ingenico createPaymentSession: add recurring_model

https://gerrit.wikimedia.org/r/911910

gerritbot added a comment.Apr 25 2023, 5:49 PM

Change 909799 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Catch exceptions in createPaymentSession

https://gerrit.wikimedia.org/r/909799

gerritbot added a comment.Apr 25 2023, 5:52 PM

Change 910106 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Handle ApiException in getLatestPaymentStatus

https://gerrit.wikimedia.org/r/910106

AKanji-WMF added a project: Fundraising Sprint Istanbool (not Constantidouble).Apr 25 2023, 8:36 PM
AKanji-WMF moved this task from Backlog to Doing on the Fundraising Sprint Istanbool (not Constantidouble) board.Apr 25 2023, 8:46 PM
AKanji-WMF removed a project: Fundraising Sprint Highway to Hello World.Apr 25 2023, 8:49 PM
gerritbot added a comment.Apr 26 2023, 9:15 PM

Change 912374 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Ingenico disentanglement: modern processDonorReturn

https://gerrit.wikimedia.org/r/912374

AnnWF moved this task from Doing to Being Reviewed on the Fundraising Sprint Istanbool (not Constantidouble) board.Apr 27 2023, 11:28 PM
gerritbot added a comment.Apr 28 2023, 3:56 PM

Change 911910 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Ingenico createPaymentSession: add recurring_model

https://gerrit.wikimedia.org/r/911910

gerritbot added a comment.May 1 2023, 4:56 PM

Change 913961 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Ingenico disentangle: no GC inheritance

https://gerrit.wikimedia.org/r/913961

gerritbot added a comment.May 1 2023, 7:17 PM

Change 913977 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] WIP: Delete GlobalCollect

https://gerrit.wikimedia.org/r/913977

gerritbot added a comment.May 3 2023, 12:30 PM

Change 908670 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Ingenico disentanglement: clean up doPayment

https://gerrit.wikimedia.org/r/908670

gerritbot added a comment.May 3 2023, 2:38 PM

Change 912374 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Ingenico disentanglement: modern processDonorReturn

https://gerrit.wikimedia.org/r/912374

gerritbot added a comment.May 4 2023, 5:15 PM

Change 913961 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Ingenico disentanglement: no GC inheritance

https://gerrit.wikimedia.org/r/913961

gerritbot added a comment.May 9 2023, 4:35 PM

Change 917921 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Make tests use Ingenico as default adapter

https://gerrit.wikimedia.org/r/917921

gerritbot added a comment.May 9 2023, 4:39 PM

Change 917921 abandoned by Ejegg:

[mediawiki/extensions/DonationInterface@master] Make tests use Ingenico as default adapter

Reason:

Leaving the whole deletion patch together - picking it apart looks like a huge pain

https://gerrit.wikimedia.org/r/917921

XenoRyet added a project: Fundraising Sprint Jealousy Driven Development.May 9 2023, 8:12 PM
AnnWF moved this task from Backlog to Ready for Review on the Fundraising Sprint Jealousy Driven Development board.May 9 2023, 8:31 PM
AnnWF moved this task from Ready for Review to Being Reviewed on the Fundraising Sprint Jealousy Driven Development board.May 10 2023, 4:08 PM
gerritbot added a comment.May 11 2023, 3:52 PM

Change 913977 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Delete GlobalCollect

https://gerrit.wikimedia.org/r/913977

Maintenance_bot removed a project: Patch-For-Review.May 11 2023, 4:11 PM
Ejegg moved this task from Being Reviewed to Pending Deployment on the Fundraising Sprint Jealousy Driven Development board.May 11 2023, 6:11 PM
Nikerabbit added subscribers: Raymond, Nikerabbit.May 13 2023, 6:16 AM

CC @Raymond, some i18n files were deleted.

gerritbot added a comment.May 14 2023, 8:02 PM

Change 919470 had a related patch set uploaded (by Raimond Spekking; author: Raimond Spekking):

[translatewiki@master] [DonationInterface] Remove Globalcollect

https://gerrit.wikimedia.org/r/919470

gerritbot added a project: Patch-For-Review.May 14 2023, 8:02 PM
gerritbot added a comment.May 14 2023, 8:13 PM

Change 919470 merged by jenkins-bot:

[translatewiki@master] [DonationInterface] Remove Globalcollect

https://gerrit.wikimedia.org/r/919470

Raymond added a comment.May 14 2023, 8:13 PM
In T260725#8848789, @Nikerabbit wrote:

CC @Raymond, some i18n files were deleted.

@Nikerabbit Thanks for the ping. Done now.

Maintenance_bot removed a project: Patch-For-Review.May 14 2023, 8:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 7:02 AM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Jealousy Driven Development board.May 16 2023, 7:48 PM
XenoRyet closed this task as Resolved.May 22 2023, 7:28 PM
XenoRyet set Final Story Points to 8.
XenoRyet closed subtask T334773: globalcollect_gateway: should be replace to ingenico, needs replace the campaign link as Resolved.May 22 2023, 7:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL