Page MenuHomePhabricator

Remove label from Watchlist Expiry edit form field
Closed, ResolvedPublic

Description

As a Watchlist Expiry user, I want the label in for "Watchlist time period" removed from the legacy source editor, so that the watch features are not awkwardly split into two separate rows.

Background: This is a follow-up to T248494#6375651. The watchlist expiry dropdown in the edit form currently has a label above it, which makes the whole row of checkboxes etc. take up more vertical space than it needs to. One fix is for the label to be inline with the widget, but this is blocked on T251590: Inline FieldLayout isn't inline when it contains a TextInputWidget. Another (easier) fix is to remove just this one field's label from display (but keep it for screen readers etc.).

Acceptance Criteria:

  • Remove the label for "Watchlist time period" in the legacy source editor
  • There should be only one line/row (rather than 2) for watchlist related features after these changes are made

Event Timeline

Restricted Application added a project: Community-Tech. ยท View Herald TranscriptAug 19 2020, 7:43 AM
Restricted Application added a subscriber: Aklapper. ยท View Herald Transcript

Change 621129 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Hide watchlist expiry label in edit form

https://gerrit.wikimedia.org/r/621129

@Samwilson Thanks for doing this work! I have moved this ticket onto our Kanban board. Since a patch has been submitted, should it be marked as 'Needs Review,' or not yet?

General info about the ticket: We discussed this work during our morning standup today (8/19), which included @Prtksxna. We talked about the fact that we're fine with the removal of the label as a solution for now, and we'll see what kind of feedback we get (if any) about the lack of the label upon release to pilot wikis. Overall, it makes sense to go forward with this approach since, a) the ability to watch temporarily is still in place, b) the issue with the extra line for the dropdown is removed, c) the placement of the label was already a bit awkward (not only due to the extra line), and d) users will be able to understand the meaning of the dropdown due to repeated usage of the feature, the inclusion of the dropdown in other places (such as watching via star & action=watch), and explanation of the feature in documentation.

Tagging @dmaza, so he sees this update as well. Thanks!

ifried updated the task description. (Show Details)Aug 19 2020, 5:08 PM

Yes, and actually the patch has already been +2'd! So it can go straight to QA.

Sorry if I created this patch out of priority order, it's just that it was tiny and I'd finished it while demoing the issues to Prateek yesterday. :)

Change 621129 merged by jenkins-bot:
[mediawiki/core@master] Hide watchlist expiry label in edit form

https://gerrit.wikimedia.org/r/621129

Change 621243 had a related patch set uploaded (by MusikAnimal; owner: Samwilson):
[mediawiki/core@REL1_35] Hide watchlist expiry label in edit form

https://gerrit.wikimedia.org/r/621243

Change 621243 merged by jenkins-bot:
[mediawiki/core@REL1_35] Hide watchlist expiry label in edit form

https://gerrit.wikimedia.org/r/621243

dom_walden added a subscriber: dom_walden.

Vector:

MonoBook:

Timeless:

Otherwise, functions as it did before.

This does not appear to have affected how the watch checkbox appears in VisualEditor.

This is a very small change using preexisting OOUI functionality (I think) and a CSS change. Looking at the code, the changes do not appear to affect any other part of the application.

Test environment https://en.wikipedia.beta.wmflabs.org MediaWiki 1.36.0-alpha (b3be08f) 2020-08-20T08:54:51.

I have tested this on betawiki. The label has been removed and the watchlist expiry dropdown is now on the same line as the watchlist checkbox (see screenshot example below). I'm marking this work as Done.