Page MenuHomePhabricator

Generated SQL schema files lack trailing newline for sqlite and postgres types
Closed, ResolvedPublic

Description

The output of maintenance/generateSchemaSql.php has a trailing newline for --type mysql, but not for --type postgres and --type sqlite. Compare:

$ tail -1 maintenance/tables-generated.sql 
) /*$wgDBTableOptions*/;
$ tail -1 maintenance/sqlite/tables-generated.sql 
);$ tail -1 maintenance/postgres/tables-generated.sql 
);$

Might be an issue with doctrine/sql-formatter or with our script, not sure yet.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2020, 9:58 AM

Change 621218 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/core@master] Make newlines in generated schemas more consistent

https://gerrit.wikimedia.org/r/621218

Change 621218 merged by jenkins-bot:
[mediawiki/core@master] Make newlines in generated schemas more consistent

https://gerrit.wikimedia.org/r/621218

Lucas_Werkmeister_WMDE closed this task as Resolved.Aug 20 2020, 12:57 PM