Page MenuHomePhabricator
Create Task
Maniphest T260853

TypeError from Wikibase: Argument 1 passed to extractForeignIdStringSpecialNs() must implement interface MediaWiki\Linker\LinkTarget, null given, called in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error message
[ef24d542-32e3-4429-bd12-6b3574e86fd4] 2020-08-19 19:34:53: Fatal exception of type "TypeError"
Impact

The page with the given doesn’t load while logged in. Not sure how widespread the error is.

Notes

The same URL loads anonymously. Both the logged-in error and the logged-out non-error seems reproducible.

Details

Request ID
ef24d542-32e3-4429-bd12-6b3574e86fd4
Request URL
https://commons.wikimedia.org/w/index.php?title=User_talk:Steinsplitter&diff=0&oldid=440352691&uselang=en
Stack Trace
Stack Trace
#0 /srv/mediawiki/php-1.36.0-wmf.5/extensions/Wikibase/repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php(448): Wikibase\Repo\Hooks\HtmlPageLinkRendererEndHookHandler->extractForeignIdStringSpecialNs(NULL)
#1 /srv/mediawiki/php-1.36.0-wmf.5/extensions/Wikibase/repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php(440): Wikibase\Repo\Hooks\HtmlPageLinkRendererEndHookHandler->extractForeignIdStringMainNs(Title)
#2 /srv/mediawiki/php-1.36.0-wmf.5/extensions/Wikibase/repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php(419): Wikibase\Repo\Hooks\HtmlPageLinkRendererEndHookHandler->extractForeignIdString(Title)
#3 /srv/mediawiki/php-1.36.0-wmf.5/extensions/Wikibase/repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php(307): Wikibase\Repo\Hooks\HtmlPageLinkRendererEndHookHandler->parseForeignEntityId(Title)
#4 /srv/mediawiki/php-1.36.0-wmf.5/extensions/Wikibase/repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php(248): Wikibase\Repo\Hooks\HtmlPageLinkRendererEndHookHandler->internalDoHtmlPageLinkRendererEnd(MediaWiki\Linker\LinkRenderer, Title, HtmlArmor, array, RequestContext, Wikibase\Repo\Hooks\Formatters\EntityLinkFormatterFactory, NULL)
#5 /srv/mediawiki/php-1.36.0-wmf.5/extensions/Wikibase/repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php(175): Wikibase\Repo\Hooks\HtmlPageLinkRendererEndHookHandler->doHtmlPageLinkRendererEnd(MediaWiki\Linker\LinkRenderer, Title, HtmlArmor, array, RequestContext, NULL)
#6 /srv/mediawiki/php-1.36.0-wmf.5/includes/HookContainer/HookContainer.php(154): Wikibase\Repo\Hooks\HtmlPageLinkRendererEndHookHandler->onHtmlPageLinkRendererEnd(MediaWiki\Linker\LinkRenderer, Title, boolean, HtmlArmor, array, NULL)
#7 /srv/mediawiki/php-1.36.0-wmf.5/includes/HookContainer/HookRunner.php(2069): MediaWiki\HookContainer\HookContainer->run(string, array)
#8 /srv/mediawiki/php-1.36.0-wmf.5/includes/linker/LinkRenderer.php(308): MediaWiki\HookContainer\HookRunner->onHtmlPageLinkRendererEnd(MediaWiki\Linker\LinkRenderer, Title, boolean, HtmlArmor, array, NULL)
#9 /srv/mediawiki/php-1.36.0-wmf.5/includes/linker/LinkRenderer.php(215): MediaWiki\Linker\LinkRenderer->buildAElement(Title, HtmlArmor, array, boolean)
#10 /srv/mediawiki/php-1.36.0-wmf.5/includes/linker/LinkRenderer.php(242): MediaWiki\Linker\LinkRenderer->makePreloadedLink(Title, HtmlArmor, string, array, array)
#11 /srv/mediawiki/php-1.36.0-wmf.5/includes/linker/LinkRenderer.php(165): MediaWiki\Linker\LinkRenderer->makeKnownLink(Title, HtmlArmor, array, array)
#12 /srv/mediawiki/php-1.36.0-wmf.5/includes/parser/LinkHolderArray.php(326): MediaWiki\Linker\LinkRenderer->makeLink(Title, HtmlArmor)
#13 /srv/mediawiki/php-1.36.0-wmf.5/includes/parser/LinkHolderArray.php(167): LinkHolderArray->replaceInterwiki(string)
#14 /srv/mediawiki/php-1.36.0-wmf.5/includes/parser/Parser.php(4948): LinkHolderArray->replace(string)
#15 /srv/mediawiki/php-1.36.0-wmf.5/includes/parser/Parser.php(1658): Parser->replaceLinkHoldersPrivate(string)
#16 /srv/mediawiki/php-1.36.0-wmf.5/includes/parser/Parser.php(654): Parser->internalParseHalfParsed(string, boolean, boolean)
#17 /srv/mediawiki/php-1.36.0-wmf.5/includes/content/WikitextContent.php(374): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#18 /srv/mediawiki/php-1.36.0-wmf.5/includes/content/AbstractContent.php(590): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#19 /srv/mediawiki/php-1.36.0-wmf.5/includes/Revision/RenderedRevision.php(266): AbstractContent->getParserOutput(Title, integer, ParserOptions, boolean)
#20 /srv/mediawiki/php-1.36.0-wmf.5/includes/Revision/RenderedRevision.php(235): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#21 /srv/mediawiki/php-1.36.0-wmf.5/includes/Revision/RevisionRenderer.php(215): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string)
#22 /srv/mediawiki/php-1.36.0-wmf.5/includes/Revision/RevisionRenderer.php(152): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#23 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#24 /srv/mediawiki/php-1.36.0-wmf.5/includes/Revision/RenderedRevision.php(197): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#25 /srv/mediawiki/php-1.36.0-wmf.5/includes/poolcounter/PoolWorkArticleView.php(216): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#26 /srv/mediawiki/php-1.36.0-wmf.5/includes/poolcounter/PoolCounterWork.php(162): PoolWorkArticleView->doWork()
#27 /srv/mediawiki/php-1.36.0-wmf.5/includes/page/WikiPage.php(1245): PoolCounterWork->execute()
#28 /srv/mediawiki/php-1.36.0-wmf.5/includes/diff/DifferenceEngine.php(1094): WikiPage->getParserOutput(ParserOptions, integer)
#29 /srv/mediawiki/php-1.36.0-wmf.5/includes/diff/DifferenceEngine.php(1051): DifferenceEngine->getParserOutput(WikiPage, MediaWiki\Revision\RevisionStoreRecord)
#30 /srv/mediawiki/php-1.36.0-wmf.5/includes/diff/DifferenceEngine.php(879): DifferenceEngine->renderNewRevision()
#31 /srv/mediawiki/php-1.36.0-wmf.5/includes/page/Article.php(981): DifferenceEngine->showDiffPage(boolean)
#32 /srv/mediawiki/php-1.36.0-wmf.5/includes/page/Article.php(657): Article->showDiffPage()
#33 /srv/mediawiki/php-1.36.0-wmf.5/includes/actions/ViewAction.php(74): Article->view()
#34 /srv/mediawiki/php-1.36.0-wmf.5/includes/MediaWiki.php(527): ViewAction->show()
#35 /srv/mediawiki/php-1.36.0-wmf.5/includes/MediaWiki.php(313): MediaWiki->performAction(Article, Title)
#36 /srv/mediawiki/php-1.36.0-wmf.5/includes/MediaWiki.php(940): MediaWiki->performRequest()
#37 /srv/mediawiki/php-1.36.0-wmf.5/includes/MediaWiki.php(543): MediaWiki->main()
#38 /srv/mediawiki/php-1.36.0-wmf.5/index.php(53): MediaWiki->run()
#39 /srv/mediawiki/php-1.36.0-wmf.5/index.php(46): wfIndexMain()
#40 /srv/mediawiki/w/index.php(3): require(string)
#41 {main}
SubjectRepoBranchLines +/-
HtmlPageLinkRendererEndHookHandlerTest: Populate interwiki tablemediawiki/extensions/Wikibasemaster+23 -5
TypeError on commons Title::newFromText returning nullmediawiki/extensions/Wikibasemaster+26 -1
Customize query in gerrit

Related Objects

Event Timeline

Tacsipacsi created this task.Aug 19 2020, 7:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2020, 7:39 PM
Aklapper renamed this task from TypeError on Commons to TypeError from Wikibase: Argument 1 passed to extractForeignIdStringSpecialNs() must implement interface MediaWiki\Linker\LinkTarget, null given, called in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php.Aug 19 2020, 8:03 PM
Aklapper added a project: MediaWiki-extensions-WikibaseRepository.
Aklapper updated the task description. (Show Details)
Aklapper edited Stack Trace. (Show Details)
Aklapper set Phatality ID to fa82c967b6c0f61e0c43598f3c6a43fd778205d009970566cc18d5b97d03b48e.
Restricted Application added a project: Wikidata. · View Herald TranscriptAug 19 2020, 8:03 PM
Michael subscribed.Aug 20 2020, 7:50 AM
Michael added a project: Wikibase - Federated Properties (Sprint 5/6 (Hike 2)).Aug 20 2020, 7:54 AM

Seems to be related to our federated properties hike

• toan claimed this task.Aug 20 2020, 8:05 AM
• toan moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.
gerritbot added a comment.Aug 20 2020, 8:45 AM

Change 621474 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] TypeError on commons Title::newFromText returning null

https://gerrit.wikimedia.org/r/621474

gerritbot added a project: Patch-For-Review.Aug 20 2020, 8:45 AM
Michael added projects: WikibaseMediaInfo, StructuredDataOnCommons.Aug 20 2020, 8:53 AM

Since this is only happening on commons, I'm adding the respective projects.

• toan added a comment.Aug 20 2020, 10:40 AM

This is the patch that caused this https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/618991

The suggested fix would allow the links to take the same path as before this was merged.

• toan moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.Aug 20 2020, 12:19 PM
• mmodell subscribed.Aug 20 2020, 7:07 PM

Just saw this in wmf.5 with the url given as https://commons.wikimedia.org/wiki/Special:History/File:Corner_tower_of_the_Trinity_Cathedral_in_en-Solovetsky_Monastery_(Prokudin-Gorsky_20348).jpg

• mmodell mentioned this in T257973: 1.36.0-wmf.5 deployment blockers.Aug 20 2020, 7:08 PM
Agusbou2015 subscribed.Aug 20 2020, 7:11 PM
gerritbot added a comment.Aug 21 2020, 7:57 AM

Change 621474 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TypeError on commons Title::newFromText returning null

https://gerrit.wikimedia.org/r/621474

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 21 2020, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 21 2020, 8:10 AM
Addshore subscribed.Aug 24 2020, 12:29 PM

Looks very low frequency, sow ill just wait for this to be rolled out with the train rather than backporting it!

Addshore moved this task from Peer Review to Done on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.Aug 24 2020, 12:29 PM
• mmodell awarded a token.Aug 24 2020, 12:30 PM
Krinkle moved this task from Untriaged to Aug 2020 on the Wikimedia-production-error board.Aug 26 2020, 7:01 PM
Addshore closed this task as Resolved.Oct 30 2020, 5:50 PM
gerritbot added a comment.Jul 12 2022, 1:04 PM

Change 813240 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@master] HtmlPageLinkRendererEndHookHandlerTest: Populate interwiki table

https://gerrit.wikimedia.org/r/813240

Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptJul 12 2022, 1:04 PM
gerritbot added a project: Patch-For-Review.Jul 12 2022, 1:04 PM
gerritbot added a comment.Jul 12 2022, 2:03 PM

Change 813240 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] HtmlPageLinkRendererEndHookHandlerTest: Populate interwiki table

https://gerrit.wikimedia.org/r/813240

Maintenance_bot removed a project: Patch-For-Review.Jul 12 2022, 2:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL