Page MenuHomePhabricator
Create Task
Maniphest T260959

MediaWiki\Rest\HttpException should support 3xx codes and wrapped Responses
Closed, ResolvedPublic
Actions

Description

Often an exceptional condition is not a 4xx error code, it might be a redirect or require custom headers or content.

Details

SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.13.0-a12mediawiki/vendormaster+1 K -974
Rest: Use upstreamed ResponseExceptionmediawiki/services/parsoidmaster+4 -72
Rest: Use upstreamed ResponseExceptionmediawiki/services/parsoidmaster+4 -72
MediaWiki\Rest\HttpException: Support 3xx codes and wrapped Responsemediawiki/coremaster+192 -20
Customize query in gerrit

Event Timeline

cscott created this task.Aug 20 2020, 10:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2020, 10:44 PM
cscott renamed this task from MediaWiki\Rest\HttpError should support 3xx codes and wrapped Responses to MediaWiki\Rest\HttpException should support 3xx codes and wrapped Responses.Aug 20 2020, 11:49 PM

See https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/621558 for the use case, where a redirect (with custom headers) is the exceptional condition caused by a failure to extract a page id.

gerritbot added a comment.Aug 20 2020, 11:55 PM

Change 621615 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] MediaWiki\Rest\HttpException: Support 3xx codes and wrapped Response

https://gerrit.wikimedia.org/r/621615

gerritbot added a project: Patch-For-Review.Aug 20 2020, 11:55 PM
ssastry added a project: Platform Team Workboards (Clinic Duty Team).Sep 10 2020, 9:50 PM
daniel subscribed.Sep 11 2020, 1:01 PM

I'm a bit dubious about the idea. While I can see that this would be useful in some cases, it should not be the rule to use exceptions to generate non-error response. it seems to me like in most cases, this would obscure the information flow.

daniel triaged this task as Medium priority.Sep 11 2020, 3:11 PM
daniel edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Team Workboards (Clinic Duty Team).
gerritbot added a comment.Sep 11 2020, 5:06 PM

Change 626725 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Rest: Use upstreamed ResponseException

https://gerrit.wikimedia.org/r/626725

gerritbot added a comment.Sep 15 2020, 11:25 AM

Change 621615 merged by jenkins-bot:
[mediawiki/core@master] MediaWiki\Rest\HttpException: Support 3xx codes and wrapped Response

https://gerrit.wikimedia.org/r/621615

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 15 2020, 12:00 PM
gerritbot added a comment.Sep 17 2020, 5:07 PM

Change 626725 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Rest: Use upstreamed ResponseException

https://gerrit.wikimedia.org/r/626725

gerritbot added a comment.Sep 17 2020, 5:47 PM

Change 628157 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Rest: Use upstreamed ResponseException

https://gerrit.wikimedia.org/r/628157

gerritbot added a comment.Sep 21 2020, 9:06 PM

Change 628944 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a10

https://gerrit.wikimedia.org/r/628944

• Clarakosi moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.Oct 7 2020, 5:23 PM
gerritbot added a comment.Oct 14 2020, 4:56 PM

Change 628157 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Rest: Use upstreamed ResponseException

https://gerrit.wikimedia.org/r/628157

gerritbot added a comment.Oct 19 2020, 10:52 PM

Change 635100 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a12

https://gerrit.wikimedia.org/r/635100

gerritbot added a comment.Oct 20 2020, 1:28 AM

Change 635100 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a12

https://gerrit.wikimedia.org/r/635100

Pppery removed a project: Patch-For-Review.Mar 31 2023, 12:29 AM
Pppery subscribed.

All patches are merged. Can this be closed as resolved?

Pppery closed this task as Resolved.Apr 7 2023, 4:00 AM

No response, closing.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL