Page MenuHomePhabricator

CentralAuth calls "UserInvalidateEmailComplete" hook which doesn't exist, but "InvalidateEmailComplete" exists
Closed, ResolvedPublic

Description

CentralAuth currently calls the UserInvalidateEmailComplete hook (since https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/61912/), but unfortunately this hook doesn't exist; InvalidateEmailComplete however does exist.

Unfortunately I'm not sure how to proceed here (if CentralAuth's hook caller code should just be removed, or if the typo should be fixed), so I'm leaving this for other developers who know more about the CentralAuth extension. This issue was originally found while trying to document stuff on MW.org (https://www.mediawiki.org/wiki/Topic:Vs8j9igitmshxi0e).

Codesearch query here: https://codesearch.wmcloud.org/search/?q=InvalidateEmailComplete&i=nope&files=&repos=

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2020, 12:46 AM
Pppery added a subscriber: Pppery.Aug 22 2020, 12:50 AM
Reedy added a subscriber: hoo.

Change 621933 had a related patch set uploaded (by Ammarpad; owner: Reedy):
[mediawiki/extensions/CentralAuth@master] Replace UserInvalidateEmailComplete hook with InvalidateEmailComplete

https://gerrit.wikimedia.org/r/621933

Change 621738 had a related patch set uploaded (by Ammarpad; owner: Reedy):
[mediawiki/extensions/CentralAuth@REL1_35] Replace UserInvalidateEmailComplete hook with InvalidateEmailComplete

https://gerrit.wikimedia.org/r/621738

Change 621739 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/CentralAuth@REL1_34] Replace UserInvalidateEmailComplete hook with InvalidateEmailComplete

https://gerrit.wikimedia.org/r/621739

Change 621740 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/CentralAuth@REL1_31] Replace UserInvalidateEmailComplete hook with InvalidateEmailComplete

https://gerrit.wikimedia.org/r/621740

Change 621933 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Replace UserInvalidateEmailComplete hook with InvalidateEmailComplete

https://gerrit.wikimedia.org/r/621933

Change 621739 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@REL1_34] Replace UserInvalidateEmailComplete hook with InvalidateEmailComplete

https://gerrit.wikimedia.org/r/621739

Change 621738 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@REL1_35] Replace UserInvalidateEmailComplete hook with InvalidateEmailComplete

https://gerrit.wikimedia.org/r/621738

Change 621740 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@REL1_31] Replace UserInvalidateEmailComplete hook with InvalidateEmailComplete

https://gerrit.wikimedia.org/r/621740

Reedy closed this task as Resolved.Aug 24 2020, 1:13 PM
Reedy claimed this task.
Reedy triaged this task as Medium priority.