Page MenuHomePhabricator

AbuseFilter error messages show an unresolved $1 placeholder
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

When importing the file https://vi.wikipedia.org/wiki/T%E1%BA%ADp_tin:Plan_de_Son_Tay.svg, an error message is shown that says "This file (or an older revision of this file) contains elements that cannot be accepted for security reasons: $1" with the $1 not resolved.

Reported here: https://www.mediawiki.org/wiki/Topic:Vshev99tvd3fk5y0

Event Timeline

Change 621942 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] [WIP] Fix AbuseFilter warnings showing unresolved $1 placeholder

https://gerrit.wikimedia.org/r/621942

Change 621978 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Don't forget to forward error message parameters

https://gerrit.wikimedia.org/r/621978

thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-08-12 board.
thiemowmde set the point value for this task to 3.
thiemowmde changed the subtype of this task from "Task" to "Bug Report".Aug 24 2020, 8:33 AM

Change 621978 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Don't forget to forward error message parameters

https://gerrit.wikimedia.org/r/621978

Change 621942 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Avoid magic Message::__toString cast for AbuseFilter warnings

https://gerrit.wikimedia.org/r/621942