Page MenuHomePhabricator
Create Task
Maniphest T261060

AbuseFilter error messages show an unresolved $1 placeholder
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

When importing the file https://vi.wikipedia.org/wiki/T%E1%BA%ADp_tin:Plan_de_Son_Tay.svg, an error message is shown that says "This file (or an older revision of this file) contains elements that cannot be accepted for security reasons: $1" with the $1 not resolved.

Reported here: https://www.mediawiki.org/wiki/Topic:Vshev99tvd3fk5y0

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Avoid magic Message::__toString cast for AbuseFilter warningsmediawiki/extensions/FileImportermaster+17 -13
Don't forget to forward error message parametersmediawiki/extensions/FileImportermaster+22 -0
Customize query in gerrit

Related Objects

Event Timeline

thiemowmde created this task.Aug 23 2020, 8:16 AM
gerritbot added a comment.Aug 23 2020, 8:24 AM

Change 621942 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] [WIP] Fix AbuseFilter warnings showing unresolved $1 placeholder

https://gerrit.wikimedia.org/r/621942

gerritbot added a project: Patch-For-Review.Aug 23 2020, 8:24 AM
thiemowmde removed thiemowmde as the assignee of this task.Aug 23 2020, 8:24 AM
gerritbot added a comment.Aug 24 2020, 7:16 AM

Change 621978 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Don't forget to forward error message parameters

https://gerrit.wikimedia.org/r/621978

thiemowmde claimed this task.Aug 24 2020, 8:23 AM
thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-08-12 board.
thiemowmde set the point value for this task to 3.
thiemowmde changed the subtype of this task from "Task" to "Bug Report".Aug 24 2020, 8:33 AM
Lena_WMDE moved this task from Backlog to Tickets in sprint on the Move-Files-To-Commons board.Aug 25 2020, 7:38 AM
gerritbot added a comment.Aug 25 2020, 1:23 PM

Change 621978 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Don't forget to forward error message parameters

https://gerrit.wikimedia.org/r/621978

thiemowmde mentioned this in rEFLI06a08ecafd60: Don't forget to forward error message parameters.Aug 25 2020, 1:24 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Aug 25 2020, 2:00 PM
thiemowmde moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2020-08-12 board.Aug 26 2020, 8:04 AM
thiemowmde added a project: WMDE-QWERTY-Sprint-2020-08-26.
thiemowmde moved this task from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2020-08-26 board.
Lena_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-08-12 board.Aug 26 2020, 8:21 AM
Lena_WMDE moved this task from Demo to Watching on the WMDE-QWERTY-Sprint-2020-08-26 board.
Lena_WMDE moved this task from Watching to Done on the WMDE-QWERTY-Sprint-2020-08-26 board.
gerritbot added a comment.Aug 26 2020, 8:50 AM

Change 621942 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Avoid magic Message::__toString cast for AbuseFilter warnings

https://gerrit.wikimedia.org/r/621942

thiemowmde mentioned this in rEFLI09441d5bdd9b: Avoid magic Message::__toString cast for AbuseFilter warnings.Aug 26 2020, 8:54 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 26 2020, 9:10 AM
thiemowmde closed this task as Resolved.Sep 8 2020, 11:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits