Page MenuHomePhabricator
Create Task
Maniphest T261070

Vertical layout breaks in Wikisource editing mode when SyntaxHighlight is enabled
Closed, DuplicatePublic
Actions

Description

On multiple language versions of Wikisource, if I keep syntax highlighting activated, the editing mode for transcriptions is broken: the main text field is inappropriately extended to the whole page, and the scanned page, instead of being to the right of the main text field, is moved to the bottom. This makes transcribing more difficult.

The issue only happens after activating Syntax Highlight and refreshing the page. It's fixed by deactivating SH and refreshing again – which is not ideal as it forces the user to keep turning SH on and off.

Screenshots of how it should be (above) and the issue (below):

Annotation 2020-08-23 112935.png (907×1 px, 448 KB)

Annotation 2020-08-23 112858.png (907×1 px, 269 KB)

Event Timeline

Cryptex created this task.Aug 23 2020, 10:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2020, 10:32 AM
Cryptex updated the task description. (Show Details)Aug 23 2020, 10:33 AM
Aklapper changed the task status from Open to Stalled.Aug 23 2020, 2:00 PM
Aklapper removed a subscriber: All-and-every-Wikisource.

Hi @Cryptex, thanks for taking the time to report this and welcome to Wikimedia Phabricator!

Unfortunately this Wikimedia Phabricator task lacks some information.
If I go to https://it.wikisource.org/w/index.php?title=Pagina:Vocabolario_del_dialetto_napolitano_(Rocco_1882,_A_-_CAN).djvu/298&action=edit (please always include links!) with the default settings, I see a very different layout instead:

ws.jpg (950×1 px, 257 KB)

If you have time and can still reproduce the situation: Please add a more complete description to this task. That should be

  • a clear and complete list of exact steps to reproduce the situation, step by step, so that nobody needs to guess or interpret how you performed each step,
  • what happens after performing these steps to reproduce,
  • what you expected to happen instead,
  • a full link to a web address where the issue can be seen,
  • the web browser(s) and web browser version(s) that you tested.

Problems that others can reproduce can get fixed faster. Thanks!

Cryptex changed the task status from Stalled to Open.Aug 23 2020, 2:14 PM

Hi @Aklapper, thanks for replying so fast, and sorry for not being clear.

How to reproduce:

  1. Go to any Wikisource transcription editing page (for example, this one)
  2. In the toolbar above the text editing area, click on "Syntax Highlight" (if not already activated).
  3. Refresh the page (ignore the warning: Leave Page)
  4. In the toolbar above the text editing area, click on "Zoom/Altro"
  5. Click on the "Layout orizzontale/verticale" icon, to the right (two black rectangles and an arrow)

At this stage, I would expect the text editing area to be to the left, and the original page to the right (as in my first screenshot). Instead, the text editing area is shifted to the bottom right (as in my second screenshot). Occasionally you need to refresh more than one time before the issue becomes apparent.

As I mentioned in the original report, the issue is fixable by deactivating Syntax Highlight and refreshing.

I am using Firefox 79.0 (64 bit) on Windows but I have the same problem with Chrome. All beta functions in my Wikisource profile are deactivated.

Aklapper renamed this task from SyntaxHighlight breaks Wikisource editing mode to Vertical layout breaks in Wikisource editing mode when SyntaxHighlight is enabled.Aug 23 2020, 3:36 PM
Aklapper added a project: ProofreadPage.
Soda edited projects, added MediaWiki-extensions-CodeMirror; removed SyntaxHighlight.Aug 23 2020, 4:04 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptAug 23 2020, 4:04 PM
Aklapper closed this task as a duplicate of T232918: Syntax highlighting shifts the page image below the text on Wikisource.Aug 23 2020, 4:09 PM
Izno moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Aug 19 2021, 7:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL