Page MenuHomePhabricator

CU 2:0: GuidedTour highlighted row should have faded yellow
Closed, ResolvedPublic2 Estimated Story Points

Description

follow-up on T259968: CU 2.0: GuidedTour only highlights one row, even if there are other matching rows

Acceptance criteria:

  • The row with the highlighted cell should have a faded yellow background color - #fef6e7

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptAug 24 2020, 2:51 AM
Niharika triaged this task as Medium priority.Aug 26 2020, 4:03 PM
ARamirez_WMF set the point value for this task to 2.Aug 26 2020, 4:04 PM

Change 623471 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Fix GuidedTour highlighting regression

https://gerrit.wikimedia.org/r/623471

Change 623471 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Fix GuidedTour highlighting regression

https://gerrit.wikimedia.org/r/623471

Now, when you hover over a cell all matching rows also have the faded yellow background.

all_yellow.png (656ร—1 px, 104 KB)

(True for both Compare and Preliminary Check tabs.)

Previously, only the row you were hovering over had the faded yellow background (unless you pinned the highlight). @Prtksxna What do you think? I cannot remember what the original requirements were for highlighting.

Now, when you hover over a cell all matching rows also have the faded yellow background.

Yep, this is the correct behavior.

Now, when you hover over a cell all matching rows also have the faded yellow background.

Yep, this is the correct behavior.

Thanks!

Now, rows which are highlighted during the GuidedTour all have the faded yellow background color.

gt_yellow.png (561ร—1 px, 73 KB)