Page MenuHomePhabricator

[Production Commons] Vue warning - Error compiling template
Closed, ResolvedPublic

Description

Reproducible in betalabs too.

  1. On Special:MediaSearch perform any search with quickview=true and debug=true, e.g. https://commons.wikimedia.org/wiki/Special:MediaSearch?type=bitmap&q=kitten&quickview=true&debug=true
  2. Click o any image in the search result set - the Quick View is displayed and the Console displays the following error:
Vue error.trace
[Vue warn]: Error compiling template:

text ">" between v-if and v-else(-if) will be ignored.

1  |  <!-- eslint-disable vue/no-v-html --> 	<div class="wbmi-media-search-quick-view"> 		<header class="wbmi-media-search-quick-view__header"> 			<img v-if="isBitmap" :src="thumbnail" :alt="title" class="wbmi-media-search-quick-view__thumbnail 					wbmi-media-search-quick-view__thumbnail--image"> 			&gt;  			<video v-else-if="isVideo" controls="" class="wbmi-media-search-quick-view__thumbnail 					wbmi-media-search-quick-view__thumbnail--video">  				<source :src="imageinfo[ 0 ].url" :type="mimeType"> 			</video>  			<audio v-else-if="isAudio" controls="" class="wbmi-media-search-quick-view__thumbnail 					wbmi-media-search-quick-view__thumbnail--audio">  				<source :src="imageinfo[ 0 ].url" :type="mimeType"> 			</audio>  			<a ref="close" tabindex="0" class="wbmi-media-search-quick-view__close-button" role="button" @keyup.enter="closeAndRestoreFocus" @click="close"> 				<wbmi-icon :icon="icons.wbmiIconClose"> 				</wbmi-icon> 			</a> 		</header>  		<!-- File details: most of this information comes from the Commons 		Metadata API; the data available for a given file can vary widely and 		may include complex HTML generated by templates. --> 		<div class="wbmi-media-search-quick-view__body"> 			<h3 class="wbmi-media-search-quick-view__title"> 				<a ref="title" :href="canonicalurl" target="blank"> 					{{ title }} 				</a> 			</h3>  			<p v-if="description" class="wbmi-media-search-quick-view__description" v-html="description"> 			</p>  			<p v-if="artist"> 				<wbmi-icon :icon="icons.wbmiIconUserAvatar"></wbmi-icon> 				<span v-html="artist"></span> 			</p>  			<!-- Attempt to show license text, an appropriate icon, and an 			optional link to external license URL --> 			<p v-if="licenseText"> 				<wbmi-icon v-if="licenseIcon" :icon="licenseIcon"></wbmi-icon> 				<a v-if="licenseUrl" :href="licenseUrl" target="_blank"> 					<span v-html="licenseText"></span> 				</a> 				<span v-else="" v-html="licenseText"></span> 			</p>  			<!-- Sometimes this is free text, sometimes it is formatted. Can 			we make things semi-consistent? --> 			<p v-if="creationDate"> 				<wbmi-icon :icon="icons.wbmiIconClock"></wbmi-icon> 				<span v-html="creationDate"></span> 			</p>  			<p v-if="resolution"> 				<wbmi-icon :icon="icons.wbmiIconCamera"></wbmi-icon> 				<span>{{ resolution }}</span> 			</p>  			<p v-if="mimeType"> 				<wbmi-icon :icon="icons.wbmiIconPageSettings"></wbmi-icon> 				<span>{{ mimeType }}</span> 			</p>  			<wbmi-button class="wbmi-media-search-quick-view__cta" :progressive="true" @click="goToFilePage( canonicalurl )"> 				More Details 			</wbmi-button> 		</div> 	</div>
   |                                                                                                                                                                                                                                                                                                      ^^^^^^^^^^^^^

found in

---> <QuickView>
       <SearchResults>
         <WbmiTab>
           <WbmiTabs>
             <MediaSearch>
               <Root>

Event Timeline

Change 622431 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove extra closing bracket from QuickView template

https://gerrit.wikimedia.org/r/622431

Change 622449 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove extra closing bracket from QuickView template

https://gerrit.wikimedia.org/r/622449

Change 622431 abandoned by Anne Tomasevich:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove extra closing bracket from QuickView template

Reason:
based on the wrong branch

https://gerrit.wikimedia.org/r/622431

Change 622449 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove extra closing bracket from QuickView template

https://gerrit.wikimedia.org/r/622449

Checked on commons betalabs - no Vue warn were displayed.

Checked in commons wmf.8.