Page MenuHomePhabricator

Top button folding broken with new desktop improvements, covers the page title instead
Closed, ResolvedPublic

Description

Activate the new desktop improvements and go to :ro:Wikipedia:Cafenea. The top buttons do not properly fold in the "More" menu, but are displayed over the content area.

Browser: FF 79.0 on Ubuntu 18.04
Resolution: 1920x1080

Screenshot from 2020-08-26 12-18-36.png (930×1 px, 268 KB)

Event Timeline

Strainu renamed this task from Top button foldin does not work with the new desktop improvements to Top button folding does not work with the new desktop improvements.Aug 26 2020, 9:24 AM

Hi @Strainu, thanks for taking the time to report this! I can only reproduce after enabling non-default gadgets. Could you please try again with safemode=1? This allows you to test if a problem is because of your user scripts or personal gadgets without uninstalling them. See https://www.mediawiki.org/wiki/Help:Locating_broken_scripts for more information. If this does not happen in safemode, then local gadgets need to be fixed instead.

@Aklapper indeed this seems to happen only when activating Twinkle. However, I believe this is just a manifestation, not the root cause: the same result is obtained by reducing the width of the menu or increasing the number of characters in one of the buttons. I believe this shows the issue is not linked to the desktop improvements, but rather on when is the "hiding" script run.

I would appreciate some instructions on how can I call it from a gadget. Thanks!

Aklapper renamed this task from Top button folding does not work with the new desktop improvements to Top button folding broken with new desktop improvements, covers the page title instead.Aug 29 2020, 12:37 PM

Yes, you are right! Thanks for the explanation!

b.jpg (643×1 px, 167 KB)

ovasileva triaged this task as Medium priority.Sep 16 2020, 6:42 PM
ovasileva subscribed.
Jdlrobson subscribed.

I suspect this will be fixed shortly with the work we're doing in moving the search into the header next week: T263032

That said I cannot reproduce this:

Screen Shot 2020-09-18 at 11.11.00 AM.png (1×2 px, 645 KB)

At the smallest supported resolution:

Screen Shot 2020-09-18 at 11.11.26 AM.png (1×1 px, 513 KB)

@Strainu adding the collapsible class to the portlet you want to collapse under the more menu should suffice for making sure it goes under the more menu when there's not enough space.

@Strainu - the change @Jdlrobson referred to is now live. Can you check if this is still an issue. I also can't reproduce from my side (with Twinkle turned on)

Please reopen if this is still an issue.