Page MenuHomePhabricator

Use `rem` in modern Vector
Open, MediumPublic5 Estimated Story Points

Description

Relying on rem units is close to possible with accepted T248061: RFC: Remove IE 8 from basic support and proposed T262946: Bump Firefox version in basic support to 3.6 or newer.

We should consider using rems in modern Vector as

  • it provides a way of building interface with a relative sizing unit, which is providing fully accessible zooming, both on text zooming via user preferences and full-page zooming WHILE
  • it provides a much simpler handover between design and development

Browser support for rems.

Event Timeline

Nit: copying from T261334:

These are also unsupported in IE8, but are not unlocked by this RFC due to other older browsers not yet supporting them either:

  • Using rem units. This would be a very nice benefit, but even with IE 8 out of the picture not yet in reach as long we support Firefox <= 3.6 in basic.

Perhaps it's time to drop basic support for ancient firefox. Turnilo says there are 4.3m page views in the last 30 days using Firefox 3.* from real users.

Change 622742 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/Vector@master] [POC] Switch font-size to rem

https://gerrit.wikimedia.org/r/622742

ovasileva triaged this task as Medium priority.Sep 8 2020, 5:19 PM
ovasileva set the point value for this task to 5.Sep 14 2020, 5:19 PM

Nit: copying from T261334:

These are also unsupported in IE8, but are not unlocked by this RFC due to other older browsers not yet supporting them either:

  • Using rem units. This would be a very nice benefit, but even with IE 8 out of the picture not yet in reach as long we support Firefox <= 3.6 in basic.

Perhaps it's time to drop basic support for ancient firefox. Turnilo says there are 4.3m page views in the last 30 days using Firefox 3.* from real users.

@Daimona, captured in T262946.

I'm moving this back to the backlog. because as discussed in the gerrit patch here I think we should create a separate variables file for modern Vector if we're going to have different font-related variables (at least at first) in modern and legacy Vector.

The work to create those files (and generally bring more consistency to the CSS folder structure) has been captured in https://phabricator.wikimedia.org/T264309

Change 622742 abandoned by Jdlrobson:
[mediawiki/skins/Vector@master] [POC] Switch font-size to rem

Reason:
abandoning POC for now (is associated with phab ticket)

https://gerrit.wikimedia.org/r/622742

Jdlrobson moved this task from Technical to Design on the Vector board.