Page MenuHomePhabricator

Add a $wg variable to disable signature editing on new post/reply/etc.
Open, MediumPublicFeature

Description

Author: avarab

Description:
I'm using the following hack for this:


Index: lqt.js
===================================================================
--- lqt.js      (revision 68624)
+++ lqt.js      (working copy)
@@ -141,13 +141,13 @@
 
                        // Update signature editor
                        $j(container).find('input[name=wpLqtSignature]').hide();
-                       $j(container).find('.lqt-signature-preview').show();
-                       var editLink = $j('<a class="lqt-signature-edit-button"/>' );
-                       editLink.text( wgLqtMessages['lqt-edit-signature'] );
-                       editLink.click( liquidThreads.handleEditSignature );
-                       editLink.attr('href', '#');
-                       $j(container).find('.lqt-signature-preview').after(editLink);
-                       editLink.before(' ');
+                       // $j(container).find('.lqt-signature-preview').show();
+                       // var editLink = $j('<a class="lqt-signature-edit-button"/>' );
+                       // editLink.text( wgLqtMessages['lqt-edit-signature'] );
+                       // editLink.click( liquidThreads.handleEditSignature );
+                       // editLink.attr('href', '#');
+                       // $j(container).find('.lqt-signature-preview').after(editLink);
+                       // editLink.before(' ');
                }
 
                var finishSetup = function() {

It'd be nice if there were a $wg variable I could set to disable
signature editing. The motivation is to make the forum idiot proof.


Version: unspecified
Severity: major
See Also:
T34096: MobileFrontend image thumbnails, rendered math, etc gets upscaled on iPhone Retina display and hdpi Android

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:04 PM
bzimport set Reference to bz24135.
bzimport added a subscriber: Unknown Object (MLST).

Raising importance, could be workaround for critical bug 36096.
Cc Niklas and csteipp because such a config should definitely be used on Wikimedia projects and TWN, probably.

Jdforrester-WMF lowered the priority of this task from Medium to Lowest.Aug 4 2016, 11:35 PM
Jdforrester-WMF subscribed.

LiquidThreads has been replaced by StructuredDiscussions on all Wikimedia production wikis (except one, which will be done soon). It is no longer under active development or maintenance, so I'm re-classifying all open LQT tasks as "Lowest" priority.

Nemo_bis raised the priority of this task from Lowest to Medium.Feb 24 2019, 8:40 AM

Restore information removed with now-invalid rationale.

Liuxinyu970226 lowered the priority of this task from Medium to Lowest.Mar 22 2019, 1:56 AM
Liuxinyu970226 subscribed.

@Nemo_bis Changing priority won't make a task to be fixed soon, the only way to do that is you make a patch, then upload it to Gerrit and assign this task for you, other than this, there are no reason to change priority.

Remember a keystone: One Gerrit Patch Exchanges One High Priority, No Patches Exchanges Lowest

Nemo_bis raised the priority of this task from Lowest to Medium.Mar 22 2019, 1:12 PM

Sorry, I cannot make sense of the comment above. Deletion of information from our tracking of issues for translatewiki.net etc. actively impedes development and I ask you to stop it, thanks.

在T26135#5047892中,@Nemo_bis写道:

Sorry, I cannot make sense of the comment above. Deletion of information from our tracking of issues for translatewiki.net etc. actively impedes development and I ask you to stop it, thanks.

Have you read https://m.mediawiki.org/wiki/Phabricator/Project_management#Priority_levels ?

High – Someone is working or planning to work on this task soon.
Normal – Less priority than High, but someone is still planning to work on it.

By reverting again, are you really working on fixing these batch of tasks?

Change 625734 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm@master] Move another field out of general field list to update_custom_fields

https://gerrit.wikimedia.org/r/625734

Change 625734 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Move another field out of general field list to update_custom_fields

https://gerrit.wikimedia.org/r/625734

Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 15 2022, 9:40 PM
Aklapper removed a subscriber: wikibugs-l-list.