Page MenuHomePhabricator

Missing spacing between : and text on payments wiki page
Closed, ResolvedPublicBUG REPORT

Description

Summary:
This was flagged by Sophie, when she noticed the FR banners do not use spacing between 'Du Don Mensuel' and ':'

Steps to Reproduce:

  1. Open https://payments.wikimedia.org/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&ffname=adyen-test-recurring&recurring=true&payment_method=cc&uselang=fr&country=FR&gateway=adyen&amount=1.75&opt_in=0&utm_medium=sitenotice&utm_campaign=test&utm_source=B2021_0901_frFR_dsk_p1_lg_txt_cnt_optIn0.no-LP.rcc&utm_key=otherAmt_1%7EchangedAmt_1%7EmonthlyUpsell_1%7EoriginalAmt_2%7Evw_1280%7Evh_610%7Etime_4006&currency=EUR
  2. Observe missing space between Montant 'Du Don Mensuel' and ':'

image.png (430×634 px, 23 KB)

Actual Results:
Currently there is no space between 'Du Don Mensuel' and ':'

Expected Results:
French formatting rules require spacing between 'Du Don Mensuel' and ':'

Event Timeline

@CDenes_WMF I hear the capitalization in this phrase seems weird to some. Could you advise on this?

DStrine triaged this task as Medium priority.Sep 1 2020, 9:52 PM

Yeah the concern is there isn't a consistent use of capitalization. For example:
"Informations De Facturation" has De capitalized
"Adresse de courriel" does not have de capitalized

I will check with Sophie and get back to you ASAP

Hmm so I see in the code the string donate_interface-monthlybox-amount which is what's being displayed is "Montant du don mensuel" with no capitalization or ":" which means both must be getting inserted elsewhere. I will keep looking.
Update: The colon is hardcoded in. That doesn't explain the capitalization, but we could solve the spacing by adding a space to the translation string.

Is this also an issue for the frp donors?

Change 623826 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/DonationInterface@master] Add space to monthlybox amount field for french

https://gerrit.wikimedia.org/r/623826

The capitalization comes from text-transform: capitalize; on line 117 of gateway_forms/mustache/forms.css. That can probably just be removed.

Change 623831 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/DonationInterface@master] Remove capitalization for amount header

https://gerrit.wikimedia.org/r/623831

Change 623826 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Add space to monthlybox amount field for french

https://gerrit.wikimedia.org/r/623826

Change 623831 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Remove capitalization for amount header

https://gerrit.wikimedia.org/r/623831

Following up on this: When I click on the link in the description (under "to reproduce.. open:") I'm still seeing the capitalization. Should I refer to a different link now? Please lmk so I can have Sophie proof the final version without the capitalization tag. Thanks :)

Hi All, bumping my message above, as I'm still seeing capitalization when I click on original link.

Thank you!
Camille

This is not on production yet. When you see (done) next to the sprint name, that will indicate it is on production.

Sounds good, thanks for the update/explanation

I'd made the spacing change in code but it got overwritten by translate wiki. Can anyone with the right privileges go to; https://translatewiki.net/wiki/MediaWiki:Donate_interface-amount-legend/fr and add a space to the end of the text there? I'm pushing out the capitalization changes now but not the text change.

I'd made the spacing change in code but it got overwritten by translate wiki. Can anyone with the right privileges go to; https://translatewiki.net/wiki/MediaWiki:Donate_interface-amount-legend/fr and add a space to the end of the text there? I'm pushing out the capitalization changes now but not the text change.

Done @mepps

My change on translatewiki got reverted. The documentation does say that colons should be included as part of the message if needed, so that they can be localised appropriately: https://www.mediawiki.org/wiki/Localisation#Symbols,_colons,_brackets,_etc._are_parts_of_messages

Honestly I think the easiest solution is to remove the colon from the form completely. It's not necessary, and we don't have one on the "Billing Information" heading so it would increase consistency.

+1 on that idea Peter! That would certainly simplify things!

Change 627888 had a related patch set uploaded (by Pcoombe; owner: Pcoombe):
[mediawiki/extensions/DonationInterface@master] Remove colon from amount header

https://gerrit.wikimedia.org/r/627888

Change 627888 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Remove colon from amount header

https://gerrit.wikimedia.org/r/627888

mepps claimed this task.