Page MenuHomePhabricator
Create Task
Maniphest T261476

Watchlist Expiry: update dismissal time period for Firefox
Closed, ResolvedPublic
Actions

Description

Acceptance Criteria:

  • The behavior after selecting a dropdown in Firefox should be fixed to be the same as in Chrome, which means:
    • When user first sees pop-up (i.e., upon first click of star), it should display for the "short" time period before being automatically dismissed
    • When the user makes a temporary selection, the pop-up should display for the "short" time period before being automatically dismissed
    • When the user clicks the star to unwatch the page, the pop-up should display for the "short" time period before being automatically dismissed

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mediawiki.notification: Don't close notif when clicking <select> elementmediawiki/coreREL1_35+4 -3
mediawiki.notification: Don't close notif when clicking <select> elementmediawiki/coremaster+4 -3
Customize query in gerrit

Related Objects

Event Timeline

ifried created this task.Aug 27 2020, 10:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2020, 10:32 PM
ifried updated the task description. (Show Details)Aug 31 2020, 5:18 PM
ifried renamed this task from Watchlist Expiry: update dismissal time period for Firefox [placeholder] to Watchlist Expiry: update dismissal time period for Firefox.Sep 1 2020, 5:46 PM
ifried updated the task description. (Show Details)
ifried set the point value for this task to 5.
ifried moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.
ifried moved this task from Up Next (June 3-21) to Kanban-2020-21-Q1 on the Community-Tech board.
ifried edited projects, added Community-Tech (Kanban-2020-21-Q1); removed Community-Tech.
dmaza renamed this task from Watchlist Expiry: update dismissal time period for Firefox to Watchlist Expiry: update dismissal time period for Firefox [placeholder].Sep 1 2020, 6:07 PM
dmaza claimed this task.
dmaza updated the task description. (Show Details)
dmaza removed the point value 5 for this task.
dmaza moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (Kanban-2020-21-Q1) board.
• MusikAnimal subscribed.Sep 2 2020, 9:22 PM

To clarify, the specific bug we uncovered in Firefox is that the popup is dismissed when you make a selection from the dropdown, when the popup should remain open as it does in Chromium browsers.

gerritbot added a comment.Sep 3 2020, 6:05 PM

Change 623866 had a related patch set uploaded (by MusikAnimal; owner: MusikAnimal):
[mediawiki/core@master] Don't close .mw-notification when clicking on <select> element

https://gerrit.wikimedia.org/r/623866

gerritbot added a project: Patch-For-Review.Sep 3 2020, 6:05 PM
gerritbot added a comment.Sep 3 2020, 9:02 PM

Change 623866 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.notification: Don't close notif when clicking <select> element

https://gerrit.wikimedia.org/r/623866

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2020, 9:10 PM
dmaza moved this task from In Development 💻 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q1) board.Sep 3 2020, 9:12 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 3 2020, 10:00 PM
dom_walden moved this task from QA 🐛 to Product sign-off 🤘🏻 on the Community-Tech (Kanban-2020-21-Q1) board.Sep 7 2020, 8:53 AM
dom_walden subscribed.

After making a selection from the expiry dropdown, the popup displays for about 6 seconds before automatically dismissing.

It is possible, within that 6 seconds, to make another selection from the dropdown (if you change your mind). The popup displays for another 6 seconds (i.e. the timer appears to reset).

If, when the popup first appears, you open the dropdown and select "Permanent", it will remain indefinitely (until you navigate away, click on the popup or select another expiry time). This only happens if "Permanent" is your first selection after clicking the watch star. If you select another expiry option first and then select "Permanent", it dismisses after 6 seconds. I don't see many users doing this in reality. Because permanent is the default, I don't know why a user would feel the need to open the dropdown and select it.

Tested Vector, MonoBook and Timeless on Firefox 68 (not that I think the skin makes a difference).

Also tested other browsers and OSes on Vector:

  • Win10 Firefox 80
  • Win10 Chrome 85
  • Win10 IE11
  • Mac Catalina Firefox 80
  • Mac Catalina Safari 13
  • Mac Catalina Chrome 85

Test environment: https://en.wikipedia.beta.wmflabs.org MediaWiki 1.36.0-alpha (c4911b2) 2020-09-04T07:23:54 AND MediaWiki 1.36.0-alpha (e81e81e) 2020-09-06T18:54:00.

dom_walden mentioned this in T261901: Don't close notification popup when tapping on dropdown.Sep 7 2020, 10:06 AM
gerritbot added a comment.Sep 11 2020, 3:56 AM

Change 626532 had a related patch set uploaded (by Dmaza; owner: MusikAnimal):
[mediawiki/core@REL1_35] mediawiki.notification: Don't close notif when clicking <select> element

https://gerrit.wikimedia.org/r/626532

gerritbot added a project: Patch-For-Review.Sep 11 2020, 3:56 AM
dmaza renamed this task from Watchlist Expiry: update dismissal time period for Firefox [placeholder] to Watchlist Expiry: update dismissal time period for Firefox.Sep 11 2020, 4:00 AM
gerritbot added a comment.Sep 11 2020, 5:12 AM

Change 626532 merged by jenkins-bot:
[mediawiki/core@REL1_35] mediawiki.notification: Don't close notif when clicking <select> element

https://gerrit.wikimedia.org/r/626532

ReleaseTaggerBot added a project: MW-1.35-notes.Sep 11 2020, 6:01 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 11 2020, 6:10 AM
ifried closed this task as Resolved.Sep 15 2020, 10:29 PM
ifried moved this task from Product sign-off 🤘🏻 to Done 🏁 on the Community-Tech (Kanban-2020-21-Q1) board.

I have tested this on betawiki, and it looks good. The pop-up now properly dismisses when the user makes a temporary selection or when they make no selection (i.e., keeps default of permanent). As for the behavior that Dom described of explicitly selecting 'permanent' in the dropdown (which leads to a lack of automatic dismissal), I have been able to reproduce this issue in Firefox and Brave. It is low priority, but I have created a separate ticket, in case we want to address it later (T262985). I am marking this work as Done.

ifried mentioned this in T258662: Watchlist Expiry: update time period for dismissal of pop-up [MEDIUM].Sep 18 2020, 10:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits