Page MenuHomePhabricator
Create Task
Maniphest T261488

trial new termbox on desktop on a test system
Open, Stalled, Needs TriagePublic
Actions

Description

Problem:
The new termbox has proven itself on the mobile site of Wikidata. In order to reduce tech-debt and code duplication we also want to move forward with using it on the desktop site. Before we can do this we need to make a few more adaptations to make it work well on desktop and go through iterations with the editors (beta feature or similar, to be decided). As a first step UX and product want to better understand what it would look like if we just took the current version to desktop in order to better evaluate the remaining work needed. In order to do that we want to trial it on a test system without making any user-visible changes on Wikidata.

Acceptance criteria:

  • Termbox on Desktop page of Beta Wikidata is the Termbox v2 implementation as currently (September 2020) visible on Mobile Wikidata
  • This new behavior on beta is to be switched using a feature toggle (e.g. GET parameter)
  • UX and product can evaluate the current state of the new termbox on desktop on a test system

Open questions:

Details

SubjectRepoBranchLines +/-
[PoC] [DNM] How to make termbox work in desktopmediawiki/extensions/Wikibasemaster+8 -6
Don't try to show new Termbox for Lexemesmediawiki/extensions/Wikibasemaster+45 -15
labs: Turn on termbox v2 on wikidatawikioperations/mediawiki-configmaster+14 -0
Enable Termbox v2 for desktop behind a feature flagmediawiki/extensions/Wikibasemaster+97 -37
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lydia_Pintscher created this task.Aug 28 2020, 9:46 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptAug 28 2020, 9:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lydia_Pintscher moved this task from Incoming to Unconnected Stories on the Wikidata-Campsite board.Aug 28 2020, 9:47 AM
WMDE-leszek subscribed.EditedSep 1 2020, 12:35 PM

Incomplete list of possible blockers:

  • load testing - enabling termbox on desktop is certainly going to increase the load on the termbox SSR service
  • Compatibility (or lack of) with the Vector skin - so far Termbox was tailored to look and work well only on MinervaNeue skin - not a blocker for this task. We intend to have a page does not look right to identify what is missing
  • it looks like the Termbox v2 cannot currently handle rendering revisions that no longer are provided by the API (e.g. Special:Undelete case) - issue for server-side rendered termbox
WMDE-leszek updated the task description. (Show Details)Sep 1 2020, 12:37 PM
WMDE-leszek updated the task description. (Show Details)Sep 1 2020, 12:44 PM
WMDE-leszek moved this task from Unconnected Stories to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.
WMDE-leszek edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Sep 1 2020, 1:15 PM
Ladsgroup claimed this task.Sep 15 2020, 8:18 AM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptSep 15 2020, 8:18 AM
Ladsgroup added a comment.Sep 15 2020, 8:30 AM

I manged to get it to "work" in my localhost:

image.png (461×1 px, 107 KB)

Ladsgroup added a comment.Sep 15 2020, 8:46 AM

Horrible things I had to do to get it to work:

  • Make TermboxFlag php class set it to true if the setting is set
  • In RepoHooks::onBeforePageDisplay() register termbox and termbox.styles modules in case the settings is present or feature toggle is called)
  • Remove targets => [ 'mobile'] from termbox RL modules definitions
  • Prevent the old code from hydrating the termbox (I just set early return in view/resources/jquery/wikibase/jquery.wikibase.entityview.js, doing it properly will be fun)
  • Install ULS (it's not documented but termbox doesn't work without ULS)
  • Get the termbox SSR running, it's weirdly complex, I have made some patches to improve it.
gerritbot added a comment.Sep 15 2020, 3:11 PM

Change 627532 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] [PoC] [DNM] How to make termbox work in desktop

https://gerrit.wikimedia.org/r/627532

gerritbot added a project: Patch-For-Review.Sep 15 2020, 3:11 PM
gerritbot added a comment.Sep 15 2020, 3:47 PM

Change 627549 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Enable Termbox SSR for desktop behind a feature flag

https://gerrit.wikimedia.org/r/627549

Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 15 2020, 3:49 PM

Actually getting it behind feature flag wasn't that hard (mostly because of using jquery selector in the old js code).

gerritbot added a comment.Sep 18 2020, 1:09 PM

Change 627549 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Enable Termbox v2 for desktop behind a feature flag

https://gerrit.wikimedia.org/r/627549

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 18 2020, 2:00 PM
gerritbot added a comment.Sep 18 2020, 2:03 PM

Change 628337 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/mediawiki-config@master] labs: Turn on termbox v2 on wikidatawiki

https://gerrit.wikimedia.org/r/628337

gerritbot added a comment.Sep 18 2020, 2:06 PM

Change 628337 merged by jenkins-bot:
[operations/mediawiki-config@master] labs: Turn on termbox v2 on wikidatawiki

https://gerrit.wikimedia.org/r/628337

Stashbot added a comment.Sep 18 2020, 2:13 PM

Mentioned in SAL (#wikimedia-operations) [2020-09-18T14:13:14Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: labs: Turn on termbox v2 on desktop for wikidatawiki -- noop for production, sanity sync (T261488) (duration: 01m 00s)

Stashbot added a comment.Sep 18 2020, 2:15 PM

Mentioned in SAL (#wikimedia-operations) [2020-09-18T14:15:37Z] <ladsgroup@deploy1001> Synchronized wmf-config/Wikibase.php: labs: Turn on termbox v2 on desktop for wikidatawiki -- noop for production, sanity sync (T261488) (duration: 00m 56s)

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 18 2020, 2:16 PM
Lydia_Pintscher added a comment.Sep 18 2020, 6:11 PM

\o/
How can I see the beauty?

Ladsgroup added a comment.Sep 18 2020, 6:42 PM
In T261488#6475138, @Lydia_Pintscher wrote:

How can I see the beauty?

Does this count? https://wikidata.beta.wmflabs.org/wiki/Q15905 :D

WMDE-leszek changed the task status from Open to Stalled.Sep 29 2020, 6:59 AM
WMDE-leszek moved this task from Test (Verification) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

After the discussion with @Lydia_Pintscher the conclusion has been reached that the v2 termbox on desktop beta wikidata will be taken down, and re-enabled when the team is ready to perform the evaluation.
Task for turning the old termbox back on desktop beta wikidata to follow.

WMDE-leszek mentioned this in T264066: Disable termbox v2 on desktop Wikidata.Sep 29 2020, 7:04 AM
gerritbot added a comment.Sep 29 2020, 1:45 PM

Change 630852 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Don't try to show new Termbox for Lexemes

https://gerrit.wikimedia.org/r/630852

• Pablo-WMDE mentioned this in T263982: Termbox on Desktop breaks Lexeme edit links.Sep 30 2020, 2:37 PM
• Pablo-WMDE closed subtask T263982: Termbox on Desktop breaks Lexeme edit links as Resolved.Oct 1 2020, 12:01 PM
• Pablo-WMDE subscribed.EditedOct 1 2020, 12:03 PM

Should we want to re-enable the "trial" we need

gerritbot added a comment.Oct 1 2020, 12:05 PM

Change 630852 abandoned by Pablo Grass (WMDE):
[mediawiki/extensions/Wikibase@master] Don't try to show new Termbox for Lexemes

Reason:
The bug which this fixes has been reverted in Ifaec20aa47642c559254d085cb691e5affecba3c

https://gerrit.wikimedia.org/r/630852

WMDE-leszek reassigned this task from Ladsgroup to Lydia_Pintscher.Oct 6 2020, 9:44 AM
WMDE-leszek added a subscriber: Ladsgroup.
Michael mentioned this in T264893: Client: Error: invalid entity serialization.Oct 7 2020, 2:36 PM
• Pablo-WMDE added a comment.Oct 19 2020, 2:16 PM

Install ULS (it's not documented but termbox doesn't work without ULS)

The need for this is tracked in T218291: Model ULS dependency

gerritbot added a comment.Nov 19 2020, 1:31 AM

Change 627532 abandoned by Ladsgroup:
[mediawiki/extensions/Wikibase@master] [PoC] [DNM] How to make termbox work in desktop

Reason:

https://gerrit.wikimedia.org/r/627532

Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.Nov 19 2020, 2:15 AM
Addshore edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Jan 25 2021, 12:25 PM
Addshore moved this task from Incoming to Needs Wikidata PM Work on the Wikidata-Campsite board.
Addshore subscribed.

Moved per Lydia's note in an email.

Blocked until Product and UX want to do the trial.

Michael subscribed.Apr 6 2021, 10:50 AM
Lydia_Pintscher mentioned this in T289761: Consolidating wikidata user interface label editor update history.Aug 28 2021, 5:15 PM
Lydia_Pintscher merged a task: T289761: Consolidating wikidata user interface label editor update history.
Lydia_Pintscher added subscribers: Geertivp, Ainali.
• Manuel moved this task from Needs Wikidata PM Work to Miscellaneous on the Wikidata-Campsite board.Jul 12 2022, 11:53 AM
Pppery removed a project: Patch-For-Review.Apr 2 2023, 1:11 AM
Addshore unsubscribed.Jun 27 2023, 12:36 PM
Lydia_Pintscher added a comment.Aug 3 2023, 8:04 AM

Update: Work on this is now happening as part of the EntitySchema work in T324235 and in https://phabricator.wikimedia.org/project/view/6664/

Arian_Bozorg mentioned this in T368905: [ES-M4]: Investigate two methods of updating the EntitySchema termbox.Jul 1 2024, 12:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits